mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Sverdlin, Alexander" <alexander.sverdlin@siemens.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"christophe.leroy@csgroup.eu" <christophe.leroy@csgroup.eu>
Cc: "hui.wang@canonical.com" <hui.wang@canonical.com>,
	"mwalle@kernel.org" <mwalle@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"florent.trinh-thai@cs-soprasteria.com"
	<florent.trinh-thai@cs-soprasteria.com>,
	"arnd@arndb.de" <arnd@arndb.de>
Subject: Re: [PATCH] eeprom: at25: convert to spi-mem API
Date: Wed, 5 Nov 2025 07:20:07 +0000	[thread overview]
Message-ID: <db80adb8b8006fbdeee77a386feabb81537d27e6.camel@siemens.com> (raw)
In-Reply-To: <2025110513-manliness-repayment-d005@gregkh>

Hi Greg,

On Wed, 2025-11-05 at 08:15 +0900, Greg Kroah-Hartman wrote:
> > > Replace the RAW SPI accesses with spi-mem API. The latter will fall back to
> > > RAW SPI accesses if spi-mem callbacks are not implemented by a controller
> > > driver.
> > 
> > With this patch (kernel v6.17.1) our powerpc boards are totally unstable, we
> > get multiple random Oops due to bad memory accesses.
> > 
> > With this commit reverted the board is stable again.
> > 
> > The SPI driver is:
> > 
> > CONFIG_SPI=y
> > CONFIG_SPI_MASTER=y
> > CONFIG_SPI_MEM=y
> > CONFIG_SPI_FSL_LIB=y
> > CONFIG_SPI_FSL_CPM=y
> > CONFIG_SPI_FSL_SPI=y
> > 
> > How can we further investigate the issue ?
> 
> We can revert it until it comes back working properly.  Can you send a
> revert so that I can apply it?

what is known for sure is that it triggers a bug in SPI_FSL_CPM [1],
which probably justifies a revert in -stable. But there are no indications the
patch in question misbehaves itself as of now. I'm going to KASAN it on all the
HW I can get my hands on this week.

[1] https://lore.kernel.org/all/764858d5-5633-4aeb-aabe-52f9eb1eb530@csgroup.eu/

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com

  reply	other threads:[~2025-11-05  7:20 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-02 22:28 A. Sverdlin
2025-07-04 10:09 ` Arnd Bergmann
2025-11-03 16:33 ` Christophe Leroy
2025-11-03 19:12   ` Sverdlin, Alexander
2025-11-03 21:46     ` Christophe Leroy
2025-11-03 22:29       ` Sverdlin, Alexander
2025-11-03 22:36         ` Christophe Leroy
2025-11-04 13:13           ` Sverdlin, Alexander
2025-11-04 13:24             ` Christophe Leroy
2025-11-04 23:15   ` Greg Kroah-Hartman
2025-11-05  7:20     ` Sverdlin, Alexander [this message]
2025-11-07 11:49       ` Sverdlin, Alexander
2025-11-07 13:08         ` Arnd Bergmann
2025-11-07 13:44           ` Sverdlin, Alexander
2025-11-08 10:05         ` Christophe Leroy
2025-11-08 11:14           ` Christophe Leroy
2025-11-08 11:41             ` Sverdlin, Alexander
2025-11-08 16:24               ` Christophe Leroy
2025-11-10 15:09                 ` Sverdlin, Alexander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db80adb8b8006fbdeee77a386feabb81537d27e6.camel@siemens.com \
    --to=alexander.sverdlin@siemens.com \
    --cc=arnd@arndb.de \
    --cc=christophe.leroy@csgroup.eu \
    --cc=florent.trinh-thai@cs-soprasteria.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hui.wang@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mwalle@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®