Re: [patch 54/58] x86/xen/apic: Mark apic __ro_after_init

[Juergen Gross <jgross@suse.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1436 bytes --]

On 18.07.23 01:15, Thomas Gleixner wrote:
> Nothing can change it post init.
> 
> While at it mop up the whitespace damage which causes eyebleed due to an
> editor which is highlighting it.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Juergen Gross <jgross@suse.com>
> ---
>   arch/x86/xen/apic.c |   24 ++++++++++++------------
>   1 file changed, 12 insertions(+), 12 deletions(-)
> 
> --- a/arch/x86/xen/apic.c
> +++ b/arch/x86/xen/apic.c
> @@ -123,9 +123,9 @@ static int xen_cpu_present_to_apicid(int
>   		return BAD_APICID;
>   }
>   
> -static struct apic xen_pv_apic = {
> -	.name 				= "Xen PV",
> -	.probe 				= xen_apic_probe_pv,
> +static struct apic xen_pv_apic __ro_after_init = {
> +	.name				= "Xen PV",
> +	.probe				= xen_apic_probe_pv,
>   	.acpi_madt_oem_check		= xen_madt_oem_check,
>   
>   	/* .delivery_mode and .dest_mode_logical not used by XENPV */
> @@ -138,24 +138,24 @@ static struct apic xen_pv_apic = {
>   	.phys_pkg_id			= xen_phys_pkg_id, /* detect_ht */
>   
>   	.max_apic_id			= UINT_MAX,
> -	.get_apic_id 			= xen_get_apic_id,
> -	.set_apic_id 			= xen_set_apic_id, /* Can be NULL on 32-bit. */
> +	.get_apic_id			= xen_get_apic_id,
> +	.set_apic_id			= xen_set_apic_id, /* Can be NULL on 32-bit. */

While changing this line, could you please drop the comment here?

32-bit is irrelevant, as Xen PV is 64-bit only these days.


Juergen

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]