Re: [PATCH 03/07] kernel.h string cleanup

[Dave Young <hidave.darkstar@gmail.com>]

On Fri, Feb 26, 2010 at 2:55 AM, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> On Thu, Feb 25, 2010 at 11:53:59PM +0800, Dave Young wrote:
>> Cleanup kernel.h string related stuff, move to linux/string.h
>
> Ick.
>
> That's not where they're in userspace headers.

Yeah, same question, then where should they go? I think string.h is fine.

Thanks.

>
>> --- linux-2.6.orig/include/linux/kernel.h
>> +++ linux-2.6/include/linux/kernel.h
>> @@ -136,34 +137,6 @@ NORET_TYPE void do_exit(long error_code)
>>       ATTRIB_NORET;
>>  NORET_TYPE void complete_and_exit(struct completion *, long)
>>       ATTRIB_NORET;
>> -extern unsigned long simple_strtoul(const char *,char **,unsigned int);
>> -extern long simple_strtol(const char *,char **,unsigned int);
>> -extern unsigned long long simple_strtoull(const char *,char **,unsigned int);
>> -extern long long simple_strtoll(const char *,char **,unsigned int);
>> -extern int strict_strtoul(const char *, unsigned int, unsigned long *);
>> -extern int strict_strtol(const char *, unsigned int, long *);
>> -extern int strict_strtoull(const char *, unsigned int, unsigned long long *);
>> -extern int strict_strtoll(const char *, unsigned int, long long *);
>> -extern int sprintf(char * buf, const char * fmt, ...)
>> -     __attribute__ ((format (printf, 2, 3)));
>> -extern int vsprintf(char *buf, const char *, va_list)
>> -     __attribute__ ((format (printf, 2, 0)));
>> -extern int snprintf(char * buf, size_t size, const char * fmt, ...)
>> -     __attribute__ ((format (printf, 3, 4)));
>> -extern int vsnprintf(char *buf, size_t size, const char *fmt, va_list args)
>> -     __attribute__ ((format (printf, 3, 0)));
>> -extern int scnprintf(char * buf, size_t size, const char * fmt, ...)
>> -     __attribute__ ((format (printf, 3, 4)));
>> -extern int vscnprintf(char *buf, size_t size, const char *fmt, va_list args)
>> -     __attribute__ ((format (printf, 3, 0)));
>> -extern char *kasprintf(gfp_t gfp, const char *fmt, ...)
>> -     __attribute__ ((format (printf, 2, 3)));
>> -extern char *kvasprintf(gfp_t gfp, const char *fmt, va_list args);
>> -
>> -extern int sscanf(const char *, const char *, ...)
>> -     __attribute__ ((format (scanf, 2, 3)));
>> -extern int vsscanf(const char *, const char *, va_list)
>> -     __attribute__ ((format (scanf, 2, 0)));
>



-- 
Regards
dave