From: Dave Young <hidave.darkstar@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, Greg Kroah-Hartman <gregkh@suse.de>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/07] kernel.h string cleanup
Date: Fri, 26 Feb 2010 17:55:14 +0800 [thread overview]
Message-ID: <a8e1da1002260155l5e75a473oca5649ab33cce124@mail.gmail.com> (raw)
In-Reply-To: <1267170179.12041.4.camel@Joe-Laptop.home>
On Fri, Feb 26, 2010 at 3:42 PM, Joe Perches <joe@perches.com> wrote:
> On Fri, 2010-02-26 at 15:33 +0800, Dave Young wrote:
>> It will be better to move some of them to proper place instead of kernel.h
>
> Perhaps you could describe some of the reasons why
> it's better to move them.
>
> Maybe you could post the results of a timed compile
> comparison with kernel.h broken into multiple pieces
> while you're at it.
>
Thanks joe.
Spliting is necessary from my point of view.
It will be more clean to put externs/declarations to their own header files.
At the same time compiling time benifits as well.
printk/panic/string/trace header are splited then included by kernel.h so
just hexdump/int_sqrt are actually seperated.
fresh boot and same .config, make without -j, test result as following:
with the patches applied:
time:
real 15m16.504s
user 12m51.866s
sys 1m39.700s
vmlinux .text size: 003bfcd2
without the patches applied*
time:
real 15m20.518s
user 12m54.120s
sys 1m40.190s
vmlinux .text size: 003bfcea
--
Regards
dave
next prev parent reply other threads:[~2010-02-26 9:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 15:53 Dave Young
2010-02-25 18:55 ` Alexey Dobriyan
2010-02-26 1:14 ` Dave Young
2010-02-26 7:15 ` Alexey Dobriyan
2010-02-26 7:33 ` Dave Young
2010-02-26 7:42 ` Joe Perches
2010-02-26 9:55 ` Dave Young [this message]
2010-02-26 9:58 ` Alexey Dobriyan
2010-02-26 10:51 ` Dave Young
2010-02-26 14:27 ` Steven Rostedt
2010-02-27 9:55 ` Dave Young
2010-02-27 10:20 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8e1da1002260155l5e75a473oca5649ab33cce124@mail.gmail.com \
--to=hidave.darkstar@gmail.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=gregkh@suse.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome