From: Dave Young <hidave.darkstar@gmail.com>
To: rostedt@goodmis.org
Cc: Joe Perches <joe@perches.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, Greg Kroah-Hartman <gregkh@suse.de>,
Frederic Weisbecker <fweisbec@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/07] kernel.h string cleanup
Date: Sat, 27 Feb 2010 17:55:00 +0800 [thread overview]
Message-ID: <a8e1da1002270155u1d708399iaacbb5d354a14f40@mail.gmail.com> (raw)
In-Reply-To: <1267194445.6328.111.camel@gandalf.stny.rr.com>
On Fri, Feb 26, 2010 at 10:27 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> On Fri, 2010-02-26 at 17:55 +0800, Dave Young wrote:
>
>> Spliting is necessary from my point of view.
>
>> with the patches applied:
>>
>> time:
>> real 15m16.504s
>> user 12m51.866s
>> sys 1m39.700s
>>
>> vmlinux .text size: 003bfcd2
>>
>> without the patches applied*
>> time:
>> real 15m20.518s
>> user 12m54.120s
>> sys 1m40.190s
>>
>> vmlinux .text size: 003bfcea
>
> Why the change in text size? If moving stuff around in headers affects
> the final result, I'm thinking that you did something wrong.
trace/printk/panic/string stuff just being moved to another head file,
then included
in kernel.h, so there shouldn't be difference with before.
So I guess it's the hexdump/int_sqrt head file which are removed from kernel.h?
>
> The merge for x86 did a lot of file manipulation, but Thomas and Ingo
> would always test that the binary result was the same. If the binary
> result is different, then something went wrong with the file
> manipulations.
>
> -- Steve
>
>
>
>
--
Regards
dave
next prev parent reply other threads:[~2010-02-27 9:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 15:53 Dave Young
2010-02-25 18:55 ` Alexey Dobriyan
2010-02-26 1:14 ` Dave Young
2010-02-26 7:15 ` Alexey Dobriyan
2010-02-26 7:33 ` Dave Young
2010-02-26 7:42 ` Joe Perches
2010-02-26 9:55 ` Dave Young
2010-02-26 9:58 ` Alexey Dobriyan
2010-02-26 10:51 ` Dave Young
2010-02-26 14:27 ` Steven Rostedt
2010-02-27 9:55 ` Dave Young [this message]
2010-02-27 10:20 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8e1da1002270155u1d708399iaacbb5d354a14f40@mail.gmail.com \
--to=hidave.darkstar@gmail.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=gregkh@suse.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®