From: Etienne Buira <etienne.buira@free.fr>
To: "Florian Fainelli" <florian.fainelli@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Etienne Buira" <etienne.buira@free.fr>,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v3] firmware/raspberrypi: raise timeout to 3s
Date: Wed, 21 May 2025 10:04:35 +0000 [thread overview]
Message-ID: <aC2lM6xXCVK_3oWI@Z926fQmE5jqhFMgp6> (raw)
In-Reply-To: <e5659e34-511c-4137-9ffe-152bb0777146@gmx.net>
Raspberry firmware driver expected said firmware to answer by 1 second.
However, some firmware versions are buggy and can take longer with
RPI_FIRMWARE_NOTIFY_DISPLAY_DONE.
[ 2.861407] ------------[ cut here ]------------
[ 2.865512] Firmware transaction 0x00030066 timeout
Raising the timeout to 3 seconds (ought to be enough®) doesn't trigger
timeouts anymore for me and proceeds to the next failure.
Some details about firmware debugging are available here:
Link: https://github.com/raspberrypi/firmware/issues/1970
Signed-off-by: Etienne Buira <etienne.buira@free.fr>
---
v2: coding style
v3: commit message
Stefan, feel free to edit to your liking if needed, or even take
ownership of such one-liner, that would not be stealing.
drivers/firmware/raspberrypi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/raspberrypi.c
index 7ecde6921a0a..8c45a152e3ba 100644
--- a/drivers/firmware/raspberrypi.c
+++ b/drivers/firmware/raspberrypi.c
@@ -58,7 +58,7 @@ rpi_firmware_transaction(struct rpi_firmware *fw, u32 chan, u32 data)
reinit_completion(&fw->c);
ret = mbox_send_message(fw->chan, &message);
if (ret >= 0) {
- if (wait_for_completion_timeout(&fw->c, HZ)) {
+ if (wait_for_completion_timeout(&fw->c, 3 * HZ)) {
ret = 0;
} else {
ret = -ETIMEDOUT;
--
2.48.1
next prev parent reply other threads:[~2025-05-21 10:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 16:30 [PATCH] " Etienne Buira
2025-05-14 16:20 ` Stefan Wahren
2025-05-15 6:34 ` Etienne Buira
2025-05-21 8:55 ` Stefan Wahren
2025-05-21 10:04 ` Etienne Buira [this message]
2025-05-21 13:05 ` [PATCH v3] " Stefan Wahren
2025-05-15 6:41 ` [PATCH] " Etienne Buira
2025-05-15 7:42 ` Stefan Wahren
2025-05-15 9:44 ` Etienne Buira
2025-05-15 10:31 ` Stefan Wahren
2025-05-15 11:48 ` Etienne Buira
2025-05-15 17:48 ` Stefan Wahren
2025-05-15 22:27 ` Etienne Buira
2025-05-16 11:17 ` Stefan Wahren
2025-05-16 14:41 ` Searching for firmware timeout cause (was: [PATCH] firmware/raspberrypi: raise timeout to 3s) Etienne Buira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aC2lM6xXCVK_3oWI@Z926fQmE5jqhFMgp6 \
--to=etienne.buira@free.fr \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®