From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jonathan Santos <Jonathan.Santos@analog.com>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Sergiu Cuciurean <sergiu.cuciurean@analog.com>,
nuno.sa@analog.com, Michael.Hennerich@analog.com,
marcelo.schmitt@analog.com, jic23@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
marcelo.schmitt1@gmail.com, linus.walleij@linaro.org,
brgl@bgdev.pl, lgirdwood@gmail.com, broonie@kernel.org,
jonath4nns@gmail.com, dlechner@baylibre.com,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v10 07/12] iio: adc: ad7768-1: Add GPIO controller support
Date: Thu, 5 Jun 2025 09:04:22 +0300 [thread overview]
Message-ID: <aEEzZjfLVUW1kyC9@smile.fi.intel.com> (raw)
In-Reply-To: <eb48ea5f11503729b15a36ef00c89de3dd37bcc3.1749063024.git.Jonathan.Santos@analog.com>
On Wed, Jun 04, 2025 at 04:36:43PM -0300, Jonathan Santos wrote:
> From: Sergiu Cuciurean <sergiu.cuciurean@analog.com>
>
> The AD7768-1 has the ability to control other local hardware (such as gain
> stages),to power down other blocks in the signal chain, or read local
> status signals over the SPI interface.
>
> Add direct mode conditional locks in the gpio callbacks to prevent register
GPIO
> access when the device is in buffered mode.
>
> This change exports the AD7768-1's four gpios and makes them accessible
GPIOs
> at an upper layer.
...
I haven't seen in the commit message nor in the comments why GPIO regmap can't
be used. (No need to resend, just reply here, but keep in mind in case of a new
version of the series.)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-06-05 6:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 19:35 [PATCH v10 00/12] iio: adc: ad7768-1: Add features, improvements, and fixes Jonathan Santos
2025-06-04 19:35 ` [PATCH v10 01/12] iio: adc: ad7768-1: Ensure SYNC_IN pulse minimum timing requirement Jonathan Santos
2025-06-04 20:14 ` David Lechner
2025-06-07 12:22 ` Jonathan Cameron
2025-06-04 19:35 ` [PATCH v10 02/12] dt-bindings: trigger-source: add generic GPIO trigger source Jonathan Santos
2025-06-04 19:35 ` [PATCH v10 03/12] dt-bindings: iio: adc: ad7768-1: add trigger-sources property Jonathan Santos
2025-06-04 19:36 ` [PATCH v10 04/12] dt-bindings: iio: adc: ad7768-1: Document GPIO controller Jonathan Santos
2025-06-07 12:28 ` Jonathan Cameron
2025-06-04 19:36 ` [PATCH v10 05/12] dt-bindings: iio: adc: ad7768-1: document regulator provider property Jonathan Santos
2025-06-04 19:36 ` [PATCH v10 06/12] iio: adc: ad7768-1: add regulator to control VCM output Jonathan Santos
2025-06-04 19:36 ` [PATCH v10 07/12] iio: adc: ad7768-1: Add GPIO controller support Jonathan Santos
2025-06-05 6:04 ` Andy Shevchenko [this message]
2025-06-06 19:37 ` Jonathan Santos
2025-06-04 19:36 ` [PATCH v10 08/12] iio: adc: ad7768-1: add multiple scan types to support 16-bits mode Jonathan Santos
2025-06-05 6:06 ` Andy Shevchenko
2025-06-04 19:37 ` [PATCH v10 09/12] iio: adc: ad7768-1: add support for Synchronization over SPI Jonathan Santos
2025-06-05 6:10 ` Andy Shevchenko
2025-06-07 12:20 ` Jonathan Cameron
2025-06-04 19:37 ` [PATCH v10 10/12] iio: adc: ad7768-1: replace manual attribute declaration Jonathan Santos
2025-06-04 19:37 ` [PATCH v10 11/12] iio: adc: ad7768-1: add filter type and oversampling ratio attributes Jonathan Santos
2025-06-05 6:21 ` Andy Shevchenko
2025-06-04 19:37 ` [PATCH v10 12/12] iio: adc: ad7768-1: add low pass -3dB cutoff attribute Jonathan Santos
2025-06-05 6:14 ` Andy Shevchenko
2025-06-05 6:23 ` [PATCH v10 00/12] iio: adc: ad7768-1: Add features, improvements, and fixes Andy Shevchenko
2025-06-07 12:34 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEEzZjfLVUW1kyC9@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jonathan.Santos@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=jonath4nns@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=marcelo.schmitt@analog.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=sergiu.cuciurean@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®