mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Santos <Jonathan.Santos@analog.com>
To: <linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>
Cc: Jonathan Santos <Jonathan.Santos@analog.com>, <andy@kernel.org>,
	<nuno.sa@analog.com>, <Michael.Hennerich@analog.com>,
	<marcelo.schmitt@analog.com>, <jic23@kernel.org>,
	<robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
	<marcelo.schmitt1@gmail.com>, <linus.walleij@linaro.org>,
	<brgl@bgdev.pl>, <lgirdwood@gmail.com>, <broonie@kernel.org>,
	<jonath4nns@gmail.com>, <dlechner@baylibre.com>
Subject: [PATCH v10 12/12] iio: adc: ad7768-1: add low pass -3dB cutoff attribute
Date: Wed, 4 Jun 2025 16:37:49 -0300	[thread overview]
Message-ID: <e53b113a7edfa8fbe68fd6a45503f2250e264808.1749063024.git.Jonathan.Santos@analog.com> (raw)
In-Reply-To: <cover.1749063024.git.Jonathan.Santos@analog.com>

Ad7768-1 has a different -3db frequency multiplier depending on
the filter type configured. The cutoff frequency also varies according
to the current ODR.

Add a readonly low pass -3dB frequency cutoff attribute to clarify to
the user which bandwidth is being allowed depending on the filter
configurations.

Reviewed-by: Marcelo Schmitt <marcelo.schmitt@analog.com>
Reviewed-by: David Lechner <dlechner@baylibre.com>
Signed-off-by: Jonathan Santos <Jonathan.Santos@analog.com>
---
v10 Changes:
* None

v9 Changes:
* Rearraged new BIT(IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY) to 
  make the diff look cleaner.

v8 Changes:
* None

v7 Changes:
* None

v6 Changes:
* None

v5 Changes:
* None

v4 Changes:
* None

v3 Changes:
* None

v2 Changes:
* New patch in v2.
---
 drivers/iio/adc/ad7768-1.c | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c
index 8c56b7243211..475d3e1b55ec 100644
--- a/drivers/iio/adc/ad7768-1.c
+++ b/drivers/iio/adc/ad7768-1.c
@@ -152,6 +152,17 @@ enum ad7768_scan_type {
 	AD7768_SCAN_TYPE_HIGH_SPEED,
 };
 
+/*
+ * -3dB cutoff frequency multipliers (relative to ODR) for
+ * each filter type. Values are multiplied by 1000.
+ */
+static const int ad7768_filter_3db_odr_multiplier[] = {
+	[AD7768_FILTER_SINC5] = 204,
+	[AD7768_FILTER_SINC3] = 262,
+	[AD7768_FILTER_SINC3_REJ60] = 262,
+	[AD7768_FILTER_WIDEBAND] = 433,
+};
+
 static const int ad7768_mclk_div_rates[] = {
 	16, 8, 4, 2,
 };
@@ -746,6 +757,7 @@ static const struct iio_chan_spec ad7768_channels[] = {
 		.type = IIO_VOLTAGE,
 		.info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
 		.info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE) |
+					    BIT(IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY) |
 					    BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO),
 		.info_mask_shared_by_type_available = BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO),
 		.info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SAMP_FREQ),
@@ -766,7 +778,7 @@ static int ad7768_read_raw(struct iio_dev *indio_dev,
 {
 	struct ad7768_state *st = iio_priv(indio_dev);
 	const struct iio_scan_type *scan_type;
-	int scale_uv, ret;
+	int scale_uv, ret, temp;
 
 	scan_type = iio_get_current_scan_type(indio_dev, chan);
 	if (IS_ERR(scan_type))
@@ -804,6 +816,12 @@ static int ad7768_read_raw(struct iio_dev *indio_dev,
 	case IIO_CHAN_INFO_OVERSAMPLING_RATIO:
 		*val = st->oversampling_ratio;
 
+		return IIO_VAL_INT;
+
+	case IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY:
+		temp = st->samp_freq * ad7768_filter_3db_odr_multiplier[st->filter_type];
+		*val = DIV_ROUND_CLOSEST(temp, 1000);
+
 		return IIO_VAL_INT;
 	}
 
-- 
2.34.1


  parent reply	other threads:[~2025-06-04 19:38 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-04 19:35 [PATCH v10 00/12] iio: adc: ad7768-1: Add features, improvements, and fixes Jonathan Santos
2025-06-04 19:35 ` [PATCH v10 01/12] iio: adc: ad7768-1: Ensure SYNC_IN pulse minimum timing requirement Jonathan Santos
2025-06-04 20:14   ` David Lechner
2025-06-07 12:22     ` Jonathan Cameron
2025-06-04 19:35 ` [PATCH v10 02/12] dt-bindings: trigger-source: add generic GPIO trigger source Jonathan Santos
2025-06-04 19:35 ` [PATCH v10 03/12] dt-bindings: iio: adc: ad7768-1: add trigger-sources property Jonathan Santos
2025-06-04 19:36 ` [PATCH v10 04/12] dt-bindings: iio: adc: ad7768-1: Document GPIO controller Jonathan Santos
2025-06-07 12:28   ` Jonathan Cameron
2025-06-04 19:36 ` [PATCH v10 05/12] dt-bindings: iio: adc: ad7768-1: document regulator provider property Jonathan Santos
2025-06-04 19:36 ` [PATCH v10 06/12] iio: adc: ad7768-1: add regulator to control VCM output Jonathan Santos
2025-06-04 19:36 ` [PATCH v10 07/12] iio: adc: ad7768-1: Add GPIO controller support Jonathan Santos
2025-06-05  6:04   ` Andy Shevchenko
2025-06-06 19:37     ` Jonathan Santos
2025-06-04 19:36 ` [PATCH v10 08/12] iio: adc: ad7768-1: add multiple scan types to support 16-bits mode Jonathan Santos
2025-06-05  6:06   ` Andy Shevchenko
2025-06-04 19:37 ` [PATCH v10 09/12] iio: adc: ad7768-1: add support for Synchronization over SPI Jonathan Santos
2025-06-05  6:10   ` Andy Shevchenko
2025-06-07 12:20     ` Jonathan Cameron
2025-06-04 19:37 ` [PATCH v10 10/12] iio: adc: ad7768-1: replace manual attribute declaration Jonathan Santos
2025-06-04 19:37 ` [PATCH v10 11/12] iio: adc: ad7768-1: add filter type and oversampling ratio attributes Jonathan Santos
2025-06-05  6:21   ` Andy Shevchenko
2025-06-04 19:37 ` Jonathan Santos [this message]
2025-06-05  6:14   ` [PATCH v10 12/12] iio: adc: ad7768-1: add low pass -3dB cutoff attribute Andy Shevchenko
2025-06-05  6:23 ` [PATCH v10 00/12] iio: adc: ad7768-1: Add features, improvements, and fixes Andy Shevchenko
2025-06-07 12:34   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e53b113a7edfa8fbe68fd6a45503f2250e264808.1749063024.git.Jonathan.Santos@analog.com \
    --to=jonathan.santos@analog.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=brgl@bgdev.pl \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=jonath4nns@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.schmitt1@gmail.com \
    --cc=marcelo.schmitt@analog.com \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®