From: Yeoreum Yun <yeoreum.yun@arm.com>
To: Leo Yan <leo.yan@arm.com>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
James Clark <james.clark@linaro.org>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 01/10] coresight: tmc: Support atclk
Date: Fri, 27 Jun 2025 14:27:48 +0100 [thread overview]
Message-ID: <aF6cVFA7NpN2S273@e129823.arm.com> (raw)
In-Reply-To: <20250627-arm_cs_fix_clock_v4-v4-1-0ce0009c38f8@arm.com>
Hi Leo,
[...]
> @@ -789,6 +789,10 @@ static int __tmc_probe(struct device *dev, struct resource *res)
> struct coresight_desc desc = { 0 };
> struct coresight_dev_list *dev_list = NULL;
>
> + drvdata->atclk = devm_clk_get_optional_enabled(dev, "atclk");
> + if (IS_ERR(drvdata->atclk))
> + return PTR_ERR(drvdata->atclk);
> +
> ret = -ENOMEM;
>
Just another quetion.
If this function is called from tmc_platform_probe() and failed,
should it call the clk_put() for drvdata->pclk when it failed?
--
Sincerely,
Yeoreum Yun
next prev parent reply other threads:[~2025-06-27 13:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 11:51 [PATCH v4 00/10] coresight: Fix and improve clock usage Leo Yan
2025-06-27 11:51 ` [PATCH v4 01/10] coresight: tmc: Support atclk Leo Yan
2025-06-27 13:27 ` Yeoreum Yun [this message]
2025-06-27 13:49 ` Yeoreum Yun
2025-06-27 13:59 ` Leo Yan
2025-06-27 11:51 ` [PATCH v4 02/10] coresight: catu: " Leo Yan
2025-06-27 11:51 ` [PATCH v4 03/10] coresight: etm4x: " Leo Yan
2025-06-27 11:51 ` [PATCH v4 04/10] coresight: Appropriately disable programming clocks Leo Yan
2025-07-21 9:15 ` Suzuki K Poulose
2025-07-21 10:48 ` Leo Yan
2025-07-21 11:40 ` Suzuki K Poulose
2025-07-21 13:59 ` Leo Yan
2025-07-22 13:25 ` Suzuki K Poulose
[not found] ` <daece566-2cca-71dd-d21a-80dadad2c71b@huawei.com>
2025-07-23 10:23 ` Leo Yan
2025-06-27 11:51 ` [PATCH v4 05/10] coresight: Appropriately disable trace bus clocks Leo Yan
2025-07-21 9:20 ` Suzuki K Poulose
2025-07-21 13:42 ` Leo Yan
2025-06-27 11:51 ` [PATCH v4 06/10] coresight: Avoid enable programming clock duplicately Leo Yan
2025-06-27 11:51 ` [PATCH v4 07/10] coresight: Consolidate clock enabling Leo Yan
2025-06-30 5:37 ` Anshuman Khandual
2025-06-27 11:51 ` [PATCH v4 08/10] coresight: Refactor driver data allocation Leo Yan
2025-06-30 5:47 ` Anshuman Khandual
2025-06-27 11:51 ` [PATCH v4 09/10] coresight: Make clock sequence consistent Leo Yan
2025-06-27 11:51 ` [PATCH v4 10/10] coresight: Refactor runtime PM Leo Yan
2025-06-27 13:50 ` [PATCH v4 00/10] coresight: Fix and improve clock usage Yeoreum Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aF6cVFA7NpN2S273@e129823.arm.com \
--to=yeoreum.yun@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=anshuman.khandual@arm.com \
--cc=coresight@lists.linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=james.clark@linaro.org \
--cc=leo.yan@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®