[tip:locking/core 1/4] Diff in rust/kernel/sync/atomic.rs:21:

[tip:locking/core 1/4] Diff in rust/kernel/sync/atomic.rs:21:

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking/core
head:   43decb6b628eb033a1b6188e5018773c0d38be1d
commit: 14e9a18b07ec463a85094cc8942788336164319f [1/4] rust: sync: atomic: Make Atomic*Ops pub(crate)
config: x86_64-rhel-9.4-rust (https://download.01.org/0day-ci/archive/20251211/202512110753.8B3YlvtX-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
rustc: rustc 1.88.0 (6b00bc388 2025-06-23)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251211/202512110753.8B3YlvtX-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512110753.8B3YlvtX-lkp@intel.com/

All errors (new ones prefixed by >>):

   PATH=/opt/cross/clang-20/bin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
   INFO PATH=/opt/cross/rustc-1.88.0-bindgen-0.72.1/cargo/bin:/opt/cross/clang-20/bin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
   /usr/bin/timeout -k 100 12h /usr/bin/make KCFLAGS= -fno-crash-diagnostics -Wno-error=return-type -Wreturn-type -funsigned-char -Wundef W=1 --keep-going LLVM=1 -j32 -C source O=/kbuild/obj/consumer/x86_64-rhel-9.4-rust ARCH=x86_64 SHELL=/bin/bash rustfmtcheck
   make: Entering directory '/kbuild/src/consumer'
   make[1]: Entering directory '/kbuild/obj/consumer/x86_64-rhel-9.4-rust'
>> Diff in rust/kernel/sync/atomic.rs:21:
    mod predefine;
    
    pub use internal::AtomicImpl;
   -pub use ordering::{Acquire, Full, Relaxed, Release};
    pub(crate) use internal::{AtomicArithmeticOps, AtomicBasicOps, AtomicExchangeOps};
   +pub use ordering::{Acquire, Full, Relaxed, Release};
    
    use crate::build_error;
    use internal::AtomicRepr;
>> Diff in rust/kernel/sync/atomic.rs:21:
    mod predefine;
    
    pub use internal::AtomicImpl;
   -pub use ordering::{Acquire, Full, Relaxed, Release};
    pub(crate) use internal::{AtomicArithmeticOps, AtomicBasicOps, AtomicExchangeOps};
   +pub use ordering::{Acquire, Full, Relaxed, Release};
    
    use crate::build_error;
    use internal::AtomicRepr;
>> Diff in rust/kernel/sync/atomic.rs:21:
    mod predefine;
    
    pub use internal::AtomicImpl;
   -pub use ordering::{Acquire, Full, Relaxed, Release};
    pub(crate) use internal::{AtomicArithmeticOps, AtomicBasicOps, AtomicExchangeOps};
   +pub use ordering::{Acquire, Full, Relaxed, Release};
    
    use crate::build_error;
    use internal::AtomicRepr;
   make[2]: *** [Makefile:1832: rustfmt] Error 123
   make[2]: Target 'rustfmtcheck' not remade because of errors.
   make[1]: Leaving directory '/kbuild/obj/consumer/x86_64-rhel-9.4-rust'
   make: *** [Makefile:248: __sub-make] Error 2
   make: Target 'rustfmtcheck' not remade because of errors.
   make[1]: *** [Makefile:248: __sub-make] Error 2
   make: Leaving directory '/kbuild/src/consumer'
   make[1]: Target 'rustfmtcheck' not remade because of errors.

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

[PATCH] rust: sync: atomic: Fix fmt warning

[Boqun Feng]

Commit 14e9a18b07ec ("rust: sync: atomic: Make Atomic*Ops pub(crate)")
introduced an import ordering that rustfmt disagrees with. Hence fix it.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/lkml/202512110753.8B3YlvtX-lkp@intel.com/
Fixes: 14e9a18b07ec ("rust: sync: atomic: Make Atomic*Ops pub(crate)")
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
---
Hi Ingo & Peter,

Looks like I missed one rustfmt issue in the commit 14e9a18b07ec in
tip/locking/core, here is the fix. Feel free to fold it if you want.
Apologies for not catching this earlier.

 rust/kernel/sync/atomic.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rust/kernel/sync/atomic.rs b/rust/kernel/sync/atomic.rs
index 3afc376be42d..c07a53f8360b 100644
--- a/rust/kernel/sync/atomic.rs
+++ b/rust/kernel/sync/atomic.rs
@@ -21,8 +21,8 @@
 mod predefine;
 
 pub use internal::AtomicImpl;
-pub use ordering::{Acquire, Full, Relaxed, Release};
 pub(crate) use internal::{AtomicArithmeticOps, AtomicBasicOps, AtomicExchangeOps};
+pub use ordering::{Acquire, Full, Relaxed, Release};
 
 use crate::build_error;
 use internal::AtomicRepr;
-- 
2.51.0

Re: [PATCH] rust: sync: atomic: Fix fmt warning

[Miguel Ojeda]

On Thu, Dec 11, 2025 at 10:31 PM Boqun Feng <boqun.feng@gmail.com> wrote:
>
> Commit 14e9a18b07ec ("rust: sync: atomic: Make Atomic*Ops pub(crate)")
> introduced an import ordering that rustfmt disagrees with. Hence fix it.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/lkml/202512110753.8B3YlvtX-lkp@intel.com/
> Fixes: 14e9a18b07ec ("rust: sync: atomic: Make Atomic*Ops pub(crate)")
> Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
> ---
> Hi Ingo & Peter,
>
> Looks like I missed one rustfmt issue in the commit 14e9a18b07ec in
> tip/locking/core, here is the fix. Feel free to fold it if you want.
> Apologies for not catching this earlier.

Linus picked 309e49039f12 ("rust: sync: atomic: separate import
"blocks"") in mainline a few days ago (but the solution I did was to
add a newline to separate the import "blocks" with different
visibility instead).

Cheers,
Miguel

Re: [PATCH] rust: sync: atomic: Fix fmt warning

[Boqun Feng]

On Fri, Dec 12, 2025 at 12:16:45AM +0100, Miguel Ojeda wrote:
> On Thu, Dec 11, 2025 at 10:31 PM Boqun Feng <boqun.feng@gmail.com> wrote:
> >
> > Commit 14e9a18b07ec ("rust: sync: atomic: Make Atomic*Ops pub(crate)")
> > introduced an import ordering that rustfmt disagrees with. Hence fix it.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/lkml/202512110753.8B3YlvtX-lkp@intel.com/
> > Fixes: 14e9a18b07ec ("rust: sync: atomic: Make Atomic*Ops pub(crate)")
> > Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
> > ---
> > Hi Ingo & Peter,
> >
> > Looks like I missed one rustfmt issue in the commit 14e9a18b07ec in
> > tip/locking/core, here is the fix. Feel free to fold it if you want.
> > Apologies for not catching this earlier.
> 
> Linus picked 309e49039f12 ("rust: sync: atomic: separate import
> "blocks"") in mainline a few days ago (but the solution I did was to
> add a newline to separate the import "blocks" with different
> visibility instead).
> 

I see, I must miss that. Hence I'm happy to drop this patch ;-) Thank
you!

Regards,
Boqun

> Cheers,
> Miguel