mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Rob Clark <robin.clark@oss.qualcomm.com>,
	dri-devel@lists.freedesktop.org
Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
	Alexander Koskovich <akoskovich@pm.me>,
	Jie Zhang <jie.zhang@oss.qualcomm.com>,
	Akhil P Oommen <akhilpo@oss.qualcomm.com>,
	Bhaskar Reddy Valluru <bvalluru@qti.qualcomm.com>,
	Sean Paul <sean@poorly.run>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Dmitry Baryshkov <lumag@kernel.org>,
	Abhinav Kumar <abhinav.kumar@linux.dev>,
	Jessica Zhang <jesszhan0024@gmail.com>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 05/14] drm/msm/a8xx: Add missing a850 ifpc reglist entries
Date: Thu, 22 Oct 2026 09:19:21 +0200	[thread overview]
Message-ID: <aa6dda5b-419f-425f-a9b5-198a9bf7eac2@oss.qualcomm.com> (raw)
In-Reply-To: <20261021204244.67160-6-robin.clark@oss.qualcomm.com>

On 10/21/26 10:41 PM, Rob Clark wrote:
> We want to save/restore all of the CP_PROTECT regs across IFPC.
> 
> Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>
> ---


>  drivers/gpu/drm/msm/adreno/a8xx_catalog.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/msm/adreno/a8xx_catalog.c b/drivers/gpu/drm/msm/adreno/a8xx_catalog.c
> index 55a805ab438c..45cd986ad4b5 100644
> --- a/drivers/gpu/drm/msm/adreno/a8xx_catalog.c
> +++ b/drivers/gpu/drm/msm/adreno/a8xx_catalog.c
> @@ -1477,6 +1477,13 @@ static const u32 a850_ifpc_reglist_regs[] = {
>  	REG_A8XX_CP_PROTECT_GLOBAL(53),
>  	REG_A8XX_CP_PROTECT_GLOBAL(54),
>  	REG_A8XX_CP_PROTECT_GLOBAL(55),
> +	REG_A8XX_CP_PROTECT_GLOBAL(56),
> +	REG_A8XX_CP_PROTECT_GLOBAL(57),
> +	REG_A8XX_CP_PROTECT_GLOBAL(58),
> +	REG_A8XX_CP_PROTECT_GLOBAL(59),
> +	REG_A8XX_CP_PROTECT_GLOBAL(60),
> +	REG_A8XX_CP_PROTECT_GLOBAL(61),
> +	REG_A8XX_CP_PROTECT_GLOBAL(62),
>  	REG_A8XX_CP_PROTECT_GLOBAL(63),

Sounds like we should autogen this part of the list?

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

  reply	other threads:[~2026-10-22  7:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-21 20:41 [PATCH v2 00/14] drm/msm/a8xx: GPU state capture support Rob Clark
2026-10-21 20:41 ` [PATCH v2 01/14] drm/msm: Import adreno_snapshot.h Rob Clark
2026-10-21 20:41 ` [PATCH v2 02/14] drm/msm/a8xx: Export aperture helpers Rob Clark
2026-10-21 20:41 ` [PATCH v2 03/14] drm/msm/a8xx: Add a8xx_aperture_acquire_raw() Rob Clark
2026-10-21 20:41 ` [PATCH v2 04/14] drm/msm/a8xx: Export slice helper Rob Clark
2026-10-21 20:41 ` [PATCH v2 05/14] drm/msm/a8xx: Add missing a850 ifpc reglist entries Rob Clark
2026-10-22  7:19   ` Konrad Dybcio [this message]
2026-10-21 20:41 ` [PATCH v2 06/14] drm/msm/a8xx: Allow nonctx reglist to include GMU regs Rob Clark
2026-10-21 20:41 ` [PATCH v2 07/14] drm/msm/a8xx: Stop getting GMEM_PROTECT from nonctx list Rob Clark
2026-10-21 20:41 ` [PATCH v2 08/14] drm/msm/adreno: Fix PROTECT span length Rob Clark
2026-10-21 20:41 ` [PATCH v2 09/14] drm/msm/adreno: add temporary __maybe_unused Rob Clark
2026-10-21 20:41 ` [PATCH v2 10/14] drm/msm/a8xx: Import generated headers Rob Clark
2026-10-21 20:41 ` [PATCH v2 11/14] drm/msm/a8xx: devcoredump state capture support Rob Clark
2026-10-21 20:41 ` [PATCH v2 12/14] drm/msm/a8xx: Switch to generated nonctx regs Rob Clark
2026-10-22  8:03   ` Konrad Dybcio
2026-10-21 20:41 ` [PATCH v2 13/14] drm/msm/a8xx: Switch to generated protect regs Rob Clark
2026-10-22  8:27   ` Konrad Dybcio
2026-10-21 20:41 ` [PATCH v2 14/14] drm/msm/adreno: Remove temporary __maybe_unused Rob Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa6dda5b-419f-425f-a9b5-198a9bf7eac2@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=abhinav.kumar@linux.dev \
    --cc=airlied@gmail.com \
    --cc=akhilpo@oss.qualcomm.com \
    --cc=akoskovich@pm.me \
    --cc=bvalluru@qti.qualcomm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=jie.zhang@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lumag@kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=robin.clark@oss.qualcomm.com \
    --cc=sean@poorly.run \
    --cc=simona@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®