* [PATCH] hwmon: (k10temp) Fix model id range of Zen5 Turin
@ 2026-09-10 18:39 Rong Zhang
2026-09-10 19:00 ` Guenter Roeck
2026-09-11 0:48 ` Guenter Roeck
0 siblings, 2 replies; 6+ messages in thread
From: Rong Zhang @ 2026-09-10 18:39 UTC (permalink / raw)
To: Clemens Ladisch, Guenter Roeck, Gabriel Ford
Cc: Mario Limonciello, linux-hwmon, linux-kernel, Rong Zhang
Model 20h-2Fh are mobile processors with single CCD. For example, model
24h is Strix Point, i.e., Ryzen AI 7 (PRO) (H/HX) 360/365/370.
Including mobile processors in the model id range of Zen5 Turin
processors leads to bogus reporting:
k10temp-pci-00c3
Adapter: PCI adapter
Tctl: +54.1°C
Tccd4: +148.6°C
Tccd6: +148.4°C
Tccd7: +149.1°C
Tccd8: +149.2°C
Tccd9: +149.2°C
Tccd12: +149.1°C
Tccd14: +22.0°C
Tccd15: +22.0°C
Tccd16: +22.0°C
Fix it by removing the said range.
Fixes: 8440d5aca227 ("hwmon: (k10temp) Add per-CCD temperature monitoring for Zen5 Turin")
Signed-off-by: Rong Zhang <i@rong.moe>
---
drivers/hwmon/k10temp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
index 75a45010d687..3e7e63edc6a3 100644
--- a/drivers/hwmon/k10temp.c
+++ b/drivers/hwmon/k10temp.c
@@ -523,7 +523,7 @@ static int k10temp_probe(struct pci_dev *pdev, const struct pci_device_id *id)
}
} else if (boot_cpu_data.x86 == 0x1a) {
switch (boot_cpu_data.x86_model) {
- case 0x00 ... 0x2f: /* Zen5 Turin */
+ case 0x00 ... 0x1f: /* Zen5 Turin */
data->ccd_offset = 0x1F0;
k10temp_get_ccd_support(data, 16);
break;
---
base-commit: 50d05c7c76c96b90462f24debacca971d2e86713
change-id: 7b515a4b-k10temp-fix-zen5-epyc-14334e85a3b9
Thanks,
Rong
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] hwmon: (k10temp) Fix model id range of Zen5 Turin
2026-09-10 18:39 [PATCH] hwmon: (k10temp) Fix model id range of Zen5 Turin Rong Zhang
@ 2026-09-10 19:00 ` Guenter Roeck
2026-09-10 20:07 ` Rong Zhang
2026-09-11 0:48 ` Guenter Roeck
1 sibling, 1 reply; 6+ messages in thread
From: Guenter Roeck @ 2026-09-10 19:00 UTC (permalink / raw)
To: Rong Zhang, Clemens Ladisch, Gabriel Ford
Cc: Mario Limonciello, linux-hwmon, linux-kernel
On 9/10/26 11:39, Rong Zhang wrote:
> Model 20h-2Fh are mobile processors with single CCD. For example, model
> 24h is Strix Point, i.e., Ryzen AI 7 (PRO) (H/HX) 360/365/370.
>
> Including mobile processors in the model id range of Zen5 Turin
> processors leads to bogus reporting:
>
> k10temp-pci-00c3
> Adapter: PCI adapter
> Tctl: +54.1°C
> Tccd4: +148.6°C
> Tccd6: +148.4°C
> Tccd7: +149.1°C
> Tccd8: +149.2°C
> Tccd9: +149.2°C
> Tccd12: +149.1°C
> Tccd14: +22.0°C
> Tccd15: +22.0°C
> Tccd16: +22.0°C
>
> Fix it by removing the said range.
>
> Fixes: 8440d5aca227 ("hwmon: (k10temp) Add per-CCD temperature monitoring for Zen5 Turin")
> Signed-off-by: Rong Zhang <i@rong.moe>
> ---
> drivers/hwmon/k10temp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
> index 75a45010d687..3e7e63edc6a3 100644
> --- a/drivers/hwmon/k10temp.c
> +++ b/drivers/hwmon/k10temp.c
> @@ -523,7 +523,7 @@ static int k10temp_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> }
> } else if (boot_cpu_data.x86 == 0x1a) {
> switch (boot_cpu_data.x86_model) {
> - case 0x00 ... 0x2f: /* Zen5 Turin */
> + case 0x00 ... 0x1f: /* Zen5 Turin */
Doesn't that drop _all_ CCD temperature reporting for those chips ?
Guenter
> data->ccd_offset = 0x1F0;
> k10temp_get_ccd_support(data, 16);
> break;
>
> ---
> base-commit: 50d05c7c76c96b90462f24debacca971d2e86713
> change-id: 7b515a4b-k10temp-fix-zen5-epyc-14334e85a3b9
>
> Thanks,
> Rong
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] hwmon: (k10temp) Fix model id range of Zen5 Turin
2026-09-10 19:00 ` Guenter Roeck
@ 2026-09-10 20:07 ` Rong Zhang
2026-09-10 20:35 ` Mario Limonciello
2026-09-10 20:46 ` Guenter Roeck
0 siblings, 2 replies; 6+ messages in thread
From: Rong Zhang @ 2026-09-10 20:07 UTC (permalink / raw)
To: Guenter Roeck, Clemens Ladisch, Gabriel Ford
Cc: Mario Limonciello, linux-hwmon, linux-kernel
Hi Guenter,
Thanks for your review.
于 2026年9月11日 GMT+08:00 03:00:13，Guenter Roeck <linux@roeck-us.net> 写道：
> On 9/10/26 11:39, Rong Zhang wrote:
> > Model 20h-2Fh are mobile processors with single CCD. For example, model
> > 24h is Strix Point, i.e., Ryzen AI 7 (PRO) (H/HX) 360/365/370.
> >
> > Including mobile processors in the model id range of Zen5 Turin
> > processors leads to bogus reporting:
> >
> > k10temp-pci-00c3
> > Adapter: PCI adapter
> > Tctl: +54.1°C
> > Tccd4: +148.6°C
> > Tccd6: +148.4°C
> > Tccd7: +149.1°C
> > Tccd8: +149.2°C
> > Tccd9: +149.2°C
> > Tccd12: +149.1°C
> > Tccd14: +22.0°C
> > Tccd15: +22.0°C
> > Tccd16: +22.0°C
> >
> > Fix it by removing the said range.
> >
> > Fixes: 8440d5aca227 ("hwmon: (k10temp) Add per-CCD temperature monitoring for Zen5 Turin")
> > Signed-off-by: Rong Zhang <i@rong.moe>
> > ---
> > drivers/hwmon/k10temp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
> > index 75a45010d687..3e7e63edc6a3 100644
> > --- a/drivers/hwmon/k10temp.c
> > +++ b/drivers/hwmon/k10temp.c
> > @@ -523,7 +523,7 @@ static int k10temp_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> > }
> > } else if (boot_cpu_data.x86 == 0x1a) {
> > switch (boot_cpu_data.x86_model) {
> > - case 0x00 ... 0x2f: /* Zen5 Turin */
> > + case 0x00 ... 0x1f: /* Zen5 Turin */
>
> Doesn't that drop _all_ CCD temperature reporting for those chips ?
Yes, it's intentional. Mobile processors don't support Tccd at all, and
Tctl is the only available temperature metric on such processors.
In the commit message there is an example of bogus Tccd reporting.
Thanks,
Rong
>
> Guenter
>
> > data->ccd_offset = 0x1F0;
> > k10temp_get_ccd_support(data, 16);
> > break;
> >
> > ---
> > base-commit: 50d05c7c76c96b90462f24debacca971d2e86713
> > change-id: 7b515a4b-k10temp-fix-zen5-epyc-14334e85a3b9
> >
> > Thanks,
> > Rong
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] hwmon: (k10temp) Fix model id range of Zen5 Turin
2026-09-10 20:07 ` Rong Zhang
@ 2026-09-10 20:35 ` Mario Limonciello
2026-09-10 20:46 ` Guenter Roeck
1 sibling, 0 replies; 6+ messages in thread
From: Mario Limonciello @ 2026-09-10 20:35 UTC (permalink / raw)
To: Rong Zhang, Guenter Roeck, Clemens Ladisch, Gabriel Ford
Cc: linux-hwmon, linux-kernel
On 9/10/26 15:07, Rong Zhang wrote:
> Hi Guenter,
>
> Thanks for your review.
>
>
> 于 2026年9月11日 GMT+08:00 03:00:13，Guenter Roeck <linux@roeck-us.net> 写道：
>> On 9/10/26 11:39, Rong Zhang wrote:
>>> Model 20h-2Fh are mobile processors with single CCD. For example, model
>>> 24h is Strix Point, i.e., Ryzen AI 7 (PRO) (H/HX) 360/365/370.
>>>
>>> Including mobile processors in the model id range of Zen5 Turin
>>> processors leads to bogus reporting:
>>>
>>> k10temp-pci-00c3
>>> Adapter: PCI adapter
>>> Tctl: +54.1°C
>>> Tccd4: +148.6°C
>>> Tccd6: +148.4°C
>>> Tccd7: +149.1°C
>>> Tccd8: +149.2°C
>>> Tccd9: +149.2°C
>>> Tccd12: +149.1°C
>>> Tccd14: +22.0°C
>>> Tccd15: +22.0°C
>>> Tccd16: +22.0°C
>>>
>>> Fix it by removing the said range.
>>>
>>> Fixes: 8440d5aca227 ("hwmon: (k10temp) Add per-CCD temperature monitoring for Zen5 Turin")
>>> Signed-off-by: Rong Zhang <i@rong.moe>
>>> ---
>>> drivers/hwmon/k10temp.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
>>> index 75a45010d687..3e7e63edc6a3 100644
>>> --- a/drivers/hwmon/k10temp.c
>>> +++ b/drivers/hwmon/k10temp.c
>>> @@ -523,7 +523,7 @@ static int k10temp_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>>> }
>>> } else if (boot_cpu_data.x86 == 0x1a) {
>>> switch (boot_cpu_data.x86_model) {
>>> - case 0x00 ... 0x2f: /* Zen5 Turin */
>>> + case 0x00 ... 0x1f: /* Zen5 Turin */
>>
>> Doesn't that drop _all_ CCD temperature reporting for those chips ?
>
> Yes, it's intentional. Mobile processors don't support Tccd at all, and
> Tctl is the only available temperature metric on such processors.
> In the commit message there is an example of bogus Tccd reporting.
>
> Thanks,
> Rong
>
Yeah; FWIW I agree with this patch.
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
>>
>> Guenter
>>
>>> data->ccd_offset = 0x1F0;
>>> k10temp_get_ccd_support(data, 16);
>>> break;
>>>
>>> ---
>>> base-commit: 50d05c7c76c96b90462f24debacca971d2e86713
>>> change-id: 7b515a4b-k10temp-fix-zen5-epyc-14334e85a3b9
>>>
>>> Thanks,
>>> Rong
>>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] hwmon: (k10temp) Fix model id range of Zen5 Turin
2026-09-10 20:07 ` Rong Zhang
2026-09-10 20:35 ` Mario Limonciello
@ 2026-09-10 20:46 ` Guenter Roeck
1 sibling, 0 replies; 6+ messages in thread
From: Guenter Roeck @ 2026-09-10 20:46 UTC (permalink / raw)
To: Rong Zhang, Clemens Ladisch, Gabriel Ford
Cc: Mario Limonciello, linux-hwmon, linux-kernel
On 9/10/26 13:07, Rong Zhang wrote:
> Hi Guenter,
>
> Thanks for your review.
>
>
> 于 2026年9月11日 GMT+08:00 03:00:13，Guenter Roeck <linux@roeck-us.net> 写道：
>> On 9/10/26 11:39, Rong Zhang wrote:
>>> Model 20h-2Fh are mobile processors with single CCD. For example, model
>>> 24h is Strix Point, i.e., Ryzen AI 7 (PRO) (H/HX) 360/365/370.
>>>
>>> Including mobile processors in the model id range of Zen5 Turin
>>> processors leads to bogus reporting:
>>>
>>> k10temp-pci-00c3
>>> Adapter: PCI adapter
>>> Tctl: +54.1°C
>>> Tccd4: +148.6°C
>>> Tccd6: +148.4°C
>>> Tccd7: +149.1°C
>>> Tccd8: +149.2°C
>>> Tccd9: +149.2°C
>>> Tccd12: +149.1°C
>>> Tccd14: +22.0°C
>>> Tccd15: +22.0°C
>>> Tccd16: +22.0°C
>>>
>>> Fix it by removing the said range.
>>>
>>> Fixes: 8440d5aca227 ("hwmon: (k10temp) Add per-CCD temperature monitoring for Zen5 Turin")
>>> Signed-off-by: Rong Zhang <i@rong.moe>
>>> ---
>>> drivers/hwmon/k10temp.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
>>> index 75a45010d687..3e7e63edc6a3 100644
>>> --- a/drivers/hwmon/k10temp.c
>>> +++ b/drivers/hwmon/k10temp.c
>>> @@ -523,7 +523,7 @@ static int k10temp_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>>> }
>>> } else if (boot_cpu_data.x86 == 0x1a) {
>>> switch (boot_cpu_data.x86_model) {
>>> - case 0x00 ... 0x2f: /* Zen5 Turin */
>>> + case 0x00 ... 0x1f: /* Zen5 Turin */
>>
>> Doesn't that drop _all_ CCD temperature reporting for those chips ?
>
> Yes, it's intentional. Mobile processors don't support Tccd at all, and
> Tctl is the only available temperature metric on such processors.
Is that documented somewhere ?
> In the commit message there is an example of bogus Tccd reporting.
>
That does not necessarily mean that CCD reporting is not supported.
It might just mean that those processors use a different CCD offset.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] hwmon: (k10temp) Fix model id range of Zen5 Turin
2026-09-10 18:39 [PATCH] hwmon: (k10temp) Fix model id range of Zen5 Turin Rong Zhang
2026-09-10 19:00 ` Guenter Roeck
@ 2026-09-11 0:48 ` Guenter Roeck
1 sibling, 0 replies; 6+ messages in thread
From: Guenter Roeck @ 2026-09-11 0:48 UTC (permalink / raw)
To: Rong Zhang
Cc: Clemens Ladisch, Gabriel Ford, Mario Limonciello, linux-hwmon,
linux-kernel
On Fri, Sep 11, 2026 at 02:39:25AM +0800, Rong Zhang wrote:
> Model 20h-2Fh are mobile processors with single CCD. For example, model
> 24h is Strix Point, i.e., Ryzen AI 7 (PRO) (H/HX) 360/365/370.
>
> Including mobile processors in the model id range of Zen5 Turin
> processors leads to bogus reporting:
>
> k10temp-pci-00c3
> Adapter: PCI adapter
> Tctl: +54.1°C
> Tccd4: +148.6°C
> Tccd6: +148.4°C
> Tccd7: +149.1°C
> Tccd8: +149.2°C
> Tccd9: +149.2°C
> Tccd12: +149.1°C
> Tccd14: +22.0°C
> Tccd15: +22.0°C
> Tccd16: +22.0°C
>
> Fix it by removing the said range.
>
> Fixes: 8440d5aca227 ("hwmon: (k10temp) Add per-CCD temperature monitoring for Zen5 Turin")
> Signed-off-by: Rong Zhang <i@rong.moe>
> Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
Ok, I assume this is authoritative.
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-09-11 0:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-10 18:39 [PATCH] hwmon: (k10temp) Fix model id range of Zen5 Turin Rong Zhang
2026-09-10 19:00 ` Guenter Roeck
2026-09-10 20:07 ` Rong Zhang
2026-09-10 20:35 ` Mario Limonciello
2026-09-10 20:46 ` Guenter Roeck
2026-09-11 0:48 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®