[PATCH 0/3] Revise Meta Yosemite5 devicetree

[PATCH 0/3] Revise Meta Yosemite5 devicetree

[Kevin Tung]

Summary:
Revise linux device tree entry related to Meta (Facebook) Yosemite5.

Changes in v1:
- Increase i2c4/i2c12 bus speed to 400 kHz
- Update sensor configuration
- Rename sgpio P0_I3C_APML_ALERT_L

Signed-off-by: Kevin Tung <kevin.tung.openbmc@gmail.com>
---
Kevin Tung (3):
      ARM: dts: aspeed: yosemite5: Increase i2c4/i2c12 bus speed to 400 kHz
      ARM: dts: aspeed: yosemite5: Update sensor configuration
      ARM: dts: aspeed: yosemite5: Rename sgpio P0_I3C_APML_ALERT_L

 .../boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts  | 18 +++---------------
 1 file changed, 3 insertions(+), 15 deletions(-)
---
base-commit: 111e542d267576de402d0836603e1def2b60316b
change-id: 20251118-yv5_revise_dts-12e10edd95d6

Best regards,
-- 
Kevin Tung <kevin.tung.openbmc@gmail.com>

[PATCH 1/3] ARM: dts: aspeed: yosemite5: Increase i2c4/i2c12 bus speed to 400 kHz

[Kevin Tung]

Configure i2c4 and i2c12 to operate at 400 kHz instead of 100 kHz.
This update aligns the bus settings with the hardware capabilities
and improves MCTP communication performance.

Signed-off-by: Kevin Tung <kevin.tung.openbmc@gmail.com>
---
 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
index 2486981f3d6bd36f3fe780b21e834b85242f8aa9..7991e9360847532cff9aad4ad4ed57d4c30668a0 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
@@ -231,6 +231,7 @@ sbtsi@4c {
 &i2c4 {
 	multi-master;
 	mctp-controller;
+	clock-frequency = <400000>;
 	status = "okay";
 
 	mctp@10 {
@@ -782,6 +783,7 @@ adc@4b {
 &i2c12 {
 	multi-master;
 	mctp-controller;
+	clock-frequency = <400000>;
 	status = "okay";
 
 	mctp@10 {

-- 
2.51.2

[PATCH 2/3] ARM: dts: aspeed: yosemite5: Update sensor configuration

[Kevin Tung]

Remove sensors 10-0040 and 10-0045 to align with the latest
hardware design changes.

Signed-off-by: Kevin Tung <kevin.tung.openbmc@gmail.com>
---
 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
index 7991e9360847532cff9aad4ad4ed57d4c30668a0..45b8ac2e8c65a4f672e64571631b7f6944f26213 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
@@ -674,20 +674,6 @@ gpio-expander@22 {
 			"PWRGD_P3V3_AUX","ALERT_TEMP";
 	};
 
-	power-sensor@40 {
-		compatible = "ti,ina233";
-		reg = <0x40>;
-		shunt-resistor = <2000>;
-		ti,maximum-expected-current-microamp = <32768000>;
-	};
-
-	power-sensor@45 {
-		compatible = "ti,ina233";
-		reg = <0x45>;
-		shunt-resistor = <2000>;
-		ti,maximum-expected-current-microamp = <32768000>;
-	};
-
 	adc@48 {
 		compatible = "ti,ads7830";
 		reg = <0x48>;

-- 
2.51.2

Re: [PATCH 2/3] ARM: dts: aspeed: yosemite5: Update sensor configuration

[Andrew Jeffery]

On Tue, 2025-11-18 at 18:53 +0800, Kevin Tung wrote:
> Remove sensors 10-0040 and 10-0045 to align with the latest
> hardware design changes.

Can you please elaborate on this commit message? I'd like this
description to be much more specific about revisions of the hardware
design, and why you expect all instances of the previous design to
suddenly stop existing.

I can't imagine this is the only hardware change that occurred. What
other changes are lurking?

Andrew

> 
> Signed-off-by: Kevin Tung <kevin.tung.openbmc@gmail.com>
> ---
>  arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> index 7991e9360847532cff9aad4ad4ed57d4c30668a0..45b8ac2e8c65a4f672e64571631b7f6944f26213 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> @@ -674,20 +674,6 @@ gpio-expander@22 {
>  			"PWRGD_P3V3_AUX","ALERT_TEMP";
>  	};
>  
> -	power-sensor@40 {
> -		compatible = "ti,ina233";
> -		reg = <0x40>;
> -		shunt-resistor = <2000>;
> -		ti,maximum-expected-current-microamp = <32768000>;
> -	};
> -
> -	power-sensor@45 {
> -		compatible = "ti,ina233";
> -		reg = <0x45>;
> -		shunt-resistor = <2000>;
> -		ti,maximum-expected-current-microamp = <32768000>;
> -	};
> -
>  	adc@48 {
>  		compatible = "ti,ads7830";
>  		reg = <0x48>;

Re: [PATCH 2/3] ARM: dts: aspeed: yosemite5: Update sensor configuration

[Kevin Tung]

Hi Andrew,

Sure. I’ve added more detail in the v3 patch to clarify the hardware
revisions and the rationale behind this change.

Across Yosemite5 board variants, two different power monitor devices
(using different drivers) reuse the same I2C addresses 0x40 and 0x45
on bus 10. As the hardware evolved, newer board revisions replaced the
original devices with different ones at the same addresses.

Keeping these devices statically defined in the DTS can therefore
result in incorrect driver binding when running on newer hardware.
To avoid this, the 10-0040 and 10-0045 device nodes are removed from
the DTS, and the probe of the driver is instead handled in user space by
the OpenBMC Entity Manager based on the detected board configuration.

BR,
Kevin

On Mon, Nov 24, 2025 at 12:42 PM Andrew Jeffery
<andrew@codeconstruct.com.au> wrote:
>
> On Tue, 2025-11-18 at 18:53 +0800, Kevin Tung wrote:
> > Remove sensors 10-0040 and 10-0045 to align with the latest
> > hardware design changes.
>
> Can you please elaborate on this commit message? I'd like this
> description to be much more specific about revisions of the hardware
> design, and why you expect all instances of the previous design to
> suddenly stop existing.
>
> I can't imagine this is the only hardware change that occurred. What
> other changes are lurking?
>
> Andrew
>
> >
> > Signed-off-by: Kevin Tung <kevin.tung.openbmc@gmail.com>
> > ---
> >  arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts | 14 --------------
> >  1 file changed, 14 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> > index 7991e9360847532cff9aad4ad4ed57d4c30668a0..45b8ac2e8c65a4f672e64571631b7f6944f26213 100644
> > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> > @@ -674,20 +674,6 @@ gpio-expander@22 {
> >                       "PWRGD_P3V3_AUX","ALERT_TEMP";
> >       };
> >
> > -     power-sensor@40 {
> > -             compatible = "ti,ina233";
> > -             reg = <0x40>;
> > -             shunt-resistor = <2000>;
> > -             ti,maximum-expected-current-microamp = <32768000>;
> > -     };
> > -
> > -     power-sensor@45 {
> > -             compatible = "ti,ina233";
> > -             reg = <0x45>;
> > -             shunt-resistor = <2000>;
> > -             ti,maximum-expected-current-microamp = <32768000>;
> > -     };
> > -
> >       adc@48 {
> >               compatible = "ti,ads7830";
> >               reg = <0x48>;

[PATCH 3/3] ARM: dts: aspeed: yosemite5: Rename sgpio P0_I3C_APML_ALERT_L

[Kevin Tung]

Rename P0_I3C_APML_ALERT_L to FM_APML_CPU_ALERT_N for clarity.

Signed-off-by: Kevin Tung <kevin.tung.openbmc@gmail.com>
---
 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
index 45b8ac2e8c65a4f672e64571631b7f6944f26213..060757b7211a6da777c51d9f0c886796cf2450a4 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
@@ -964,7 +964,7 @@ &sgpiom0 {
 	"FAULT_P3V3_NIC_N","",
 	"FAULT_P12V_NIC_N","",
 	"FAULT_P12V_SCM_N","",
-	"P0_I3C_APML_ALERT_L","",
+	"FM_APML_CPU_ALERT_N","",
 	"ALERT_INLET_TEMP_N","",
 	"FM_CPU_PROCHOT_R_N","",
 	"FM_CPU_THERMTRIP_N","",

-- 
2.51.2

Re: [PATCH 3/3] ARM: dts: aspeed: yosemite5: Rename sgpio P0_I3C_APML_ALERT_L

[Andrew Jeffery]

On Tue, 2025-11-18 at 18:53 +0800, Kevin Tung wrote:
> Rename P0_I3C_APML_ALERT_L to FM_APML_CPU_ALERT_N for clarity.

Are user space components looking for these names? Will updating the
devicetree break older applications? I'd like to see more discussion of
these problems in the commit message.

Cheers,

Andrew

> 
> Signed-off-by: Kevin Tung <kevin.tung.openbmc@gmail.com>
> ---
>  arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> index 45b8ac2e8c65a4f672e64571631b7f6944f26213..060757b7211a6da777c51d9f0c886796cf2450a4 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> @@ -964,7 +964,7 @@ &sgpiom0 {
>  	"FAULT_P3V3_NIC_N","",
>  	"FAULT_P12V_NIC_N","",
>  	"FAULT_P12V_SCM_N","",
> -	"P0_I3C_APML_ALERT_L","",
> +	"FM_APML_CPU_ALERT_N","",
>  	"ALERT_INLET_TEMP_N","",
>  	"FM_CPU_PROCHOT_R_N","",
>  	"FM_CPU_THERMTRIP_N","",

Re: [PATCH 3/3] ARM: dts: aspeed: yosemite5: Rename sgpio P0_I3C_APML_ALERT_L

[Kevin Tung]

Hi Andrew,

I’ve sent v3 of this series to address these concerns.
The signal rename has been reverted to avoid breaking any existing
user space dependencies. In addition, a new patch has been added to
introduce additional SGPIO line names and a more detailed
discussion in the commit message.

BR,
Kevin

On Mon, Nov 24, 2025 at 12:44 PM Andrew Jeffery
<andrew@codeconstruct.com.au> wrote:
>
> On Tue, 2025-11-18 at 18:53 +0800, Kevin Tung wrote:
> > Rename P0_I3C_APML_ALERT_L to FM_APML_CPU_ALERT_N for clarity.
>
> Are user space components looking for these names? Will updating the
> devicetree break older applications? I'd like to see more discussion of
> these problems in the commit message.
>
> Cheers,
>
> Andrew
>
> >
> > Signed-off-by: Kevin Tung <kevin.tung.openbmc@gmail.com>
> > ---
> >  arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> > index 45b8ac2e8c65a4f672e64571631b7f6944f26213..060757b7211a6da777c51d9f0c886796cf2450a4 100644
> > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> > @@ -964,7 +964,7 @@ &sgpiom0 {
> >       "FAULT_P3V3_NIC_N","",
> >       "FAULT_P12V_NIC_N","",
> >       "FAULT_P12V_SCM_N","",
> > -     "P0_I3C_APML_ALERT_L","",
> > +     "FM_APML_CPU_ALERT_N","",
> >       "ALERT_INLET_TEMP_N","",
> >       "FM_CPU_PROCHOT_R_N","",
> >       "FM_CPU_THERMTRIP_N","",