* [PATCH] ipmi: ssif_bmc: Fix KUnit test link failure when KUNIT=m
@ 2026-04-07 9:46 Jian Zhang
2026-04-07 12:34 ` Corey Minyard
0 siblings, 1 reply; 2+ messages in thread
From: Jian Zhang @ 2026-04-07 9:46 UTC (permalink / raw)
To: Corey Minyard, openipmi-developer, linux-kernel; +Cc: kernel test robot
Building with CONFIG_KUNIT=m and CONFIG_SSIF_IPMI_BMC_KUNIT_TEST=y
results in link errors such as:
undefined reference to `kunit_binary_assert_format'
undefined reference to `__kunit_do_failed_assertion'
This happens because the test code is built-in while the KUnit core
is built as a module, so the required KUnit symbols are not available
at link time.
Fix this by requiring KUNIT to be built-in when enabling
SSIF_IPMI_BMC_KUNIT_TEST.
Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202604071448.zUBjPYPu-lkp@intel.com/
---
drivers/char/ipmi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig
index 72559f6050eb..669f76000197 100644
--- a/drivers/char/ipmi/Kconfig
+++ b/drivers/char/ipmi/Kconfig
@@ -189,7 +189,7 @@ config SSIF_IPMI_BMC
config SSIF_IPMI_BMC_KUNIT_TEST
bool "KUnit tests for SSIF IPMI BMC driver" if !KUNIT_ALL_TESTS
- depends on KUNIT
+ depends on KUNIT=y
depends on SSIF_IPMI_BMC
default KUNIT_ALL_TESTS
help
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ipmi: ssif_bmc: Fix KUnit test link failure when KUNIT=m
2026-04-07 9:46 [PATCH] ipmi: ssif_bmc: Fix KUnit test link failure when KUNIT=m Jian Zhang
@ 2026-04-07 12:34 ` Corey Minyard
0 siblings, 0 replies; 2+ messages in thread
From: Corey Minyard @ 2026-04-07 12:34 UTC (permalink / raw)
To: Jian Zhang; +Cc: openipmi-developer, linux-kernel, kernel test robot
On Tue, Apr 07, 2026 at 05:46:47PM +0800, Jian Zhang wrote:
> Building with CONFIG_KUNIT=m and CONFIG_SSIF_IPMI_BMC_KUNIT_TEST=y
> results in link errors such as:
>
> undefined reference to `kunit_binary_assert_format'
> undefined reference to `__kunit_do_failed_assertion'
>
> This happens because the test code is built-in while the KUnit core
> is built as a module, so the required KUnit symbols are not available
> at link time.
>
> Fix this by requiring KUNIT to be built-in when enabling
> SSIF_IPMI_BMC_KUNIT_TEST.
Got it, thanks.
-corey
>
> Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202604071448.zUBjPYPu-lkp@intel.com/
> ---
> drivers/char/ipmi/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig
> index 72559f6050eb..669f76000197 100644
> --- a/drivers/char/ipmi/Kconfig
> +++ b/drivers/char/ipmi/Kconfig
> @@ -189,7 +189,7 @@ config SSIF_IPMI_BMC
>
> config SSIF_IPMI_BMC_KUNIT_TEST
> bool "KUnit tests for SSIF IPMI BMC driver" if !KUNIT_ALL_TESTS
> - depends on KUNIT
> + depends on KUNIT=y
> depends on SSIF_IPMI_BMC
> default KUNIT_ALL_TESTS
> help
> --
> 2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-07 12:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-07 9:46 [PATCH] ipmi: ssif_bmc: Fix KUnit test link failure when KUNIT=m Jian Zhang
2026-04-07 12:34 ` Corey Minyard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®