* [PATCH v2] i3c: mipi-i3c-hci: fix IBI payload length calculation for final status
@ 2026-04-07 8:53 Billy Tsai
2026-04-08 7:39 ` Frank Li
2026-04-12 20:07 ` Alexandre Belloni
0 siblings, 2 replies; 5+ messages in thread
From: Billy Tsai @ 2026-04-07 8:53 UTC (permalink / raw)
To: Alexandre Belloni, Frank Li, Nicolas Pitre, Boris Brezillon
Cc: linux-i3c, linux-kernel, Billy Tsai
In DMA mode, the IBI status descriptor encodes the payload using
CHUNKS (number of chunks) and DATA_LENGTH (valid bytes in the last
chunk). All preceding chunks are implicitly full-sized.
The current code accumulates full chunk sizes for non-final status
descriptors, but for the final status descriptor it only adds
DATA_LENGTH. This ignores the contribution of the preceding full
chunks described by the same final status entry.
As a result, the computed IBI payload length is truncated whenever
the final status spans multiple chunks. For example, with a chunk
size of 4 bytes, CHUNKS=2 and DATA_LENGTH=1 should result in a total
payload size of 5 bytes, but the current code reports only 1 byte.
Fix the calculation by adding the size of (CHUNKS - 1) full chunks
plus DATA_LENGTH for the last chunk.
Fixes: 9ad9a52cce28 ("i3c/master: introduce the mipi-i3c-hci driver")
Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
---
Changes in v2:
- EDITME: describe what is new in this series revision.
- EDITME: use bulletpoints and terse descriptions.
- Link to v1: https://lore.kernel.org/r/20260331-i3c-hci-dma-v1-1-e5cd295c44ff@aspeedtech.com
---
Changes in v2:
- Fix IBI processing logic to properly handle IBIs without data payload.
- Link to v1: https://lore.kernel.org/r/20260331-i3c-hci-dma-v1-1-e5cd295c44ff@aspeedtech.com
---
drivers/i3c/master/mipi-i3c-hci/dma.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/i3c/master/mipi-i3c-hci/dma.c b/drivers/i3c/master/mipi-i3c-hci/dma.c
index b903a2da1fd1..c7272155c486 100644
--- a/drivers/i3c/master/mipi-i3c-hci/dma.c
+++ b/drivers/i3c/master/mipi-i3c-hci/dma.c
@@ -721,7 +721,10 @@ static void hci_dma_process_ibi(struct i3c_hci *hci, struct hci_rh_data *rh)
if (!(ibi_status & IBI_LAST_STATUS)) {
ibi_size += chunks * rh->ibi_chunk_sz;
} else {
- ibi_size += FIELD_GET(IBI_DATA_LENGTH, ibi_status);
+ if (chunks) {
+ ibi_size += (chunks - 1) * rh->ibi_chunk_sz;
+ ibi_size += FIELD_GET(IBI_DATA_LENGTH, ibi_status);
+ }
last_ptr = ptr;
break;
}
---
base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
change-id: 20260331-i3c-hci-dma-3aae908b4e8e
Best regards,
--
Billy Tsai <billy_tsai@aspeedtech.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] i3c: mipi-i3c-hci: fix IBI payload length calculation for final status
2026-04-07 8:53 [PATCH v2] i3c: mipi-i3c-hci: fix IBI payload length calculation for final status Billy Tsai
@ 2026-04-08 7:39 ` Frank Li
2026-04-09 1:31 ` Billy Tsai
2026-04-12 20:07 ` Alexandre Belloni
1 sibling, 1 reply; 5+ messages in thread
From: Frank Li @ 2026-04-08 7:39 UTC (permalink / raw)
To: Billy Tsai
Cc: Alexandre Belloni, Nicolas Pitre, Boris Brezillon, linux-i3c,
linux-kernel
On Tue, Apr 07, 2026 at 04:53:23PM +0800, Billy Tsai wrote:
> In DMA mode, the IBI status descriptor encodes the payload using
> CHUNKS (number of chunks) and DATA_LENGTH (valid bytes in the last
> chunk). All preceding chunks are implicitly full-sized.
>
> The current code accumulates full chunk sizes for non-final status
> descriptors, but for the final status descriptor it only adds
> DATA_LENGTH. This ignores the contribution of the preceding full
> chunks described by the same final status entry.
>
> As a result, the computed IBI payload length is truncated whenever
> the final status spans multiple chunks. For example, with a chunk
> size of 4 bytes, CHUNKS=2 and DATA_LENGTH=1 should result in a total
> payload size of 5 bytes, but the current code reports only 1 byte.
>
> Fix the calculation by adding the size of (CHUNKS - 1) full chunks
> plus DATA_LENGTH for the last chunk.
>
> Fixes: 9ad9a52cce28 ("i3c/master: introduce the mipi-i3c-hci driver")
> Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
> ---
> Changes in v2:
> - EDITME: describe what is new in this series revision.
> - EDITME: use bulletpoints and terse descriptions.
> - Link to v1: https://lore.kernel.org/r/20260331-i3c-hci-dma-v1-1-e5cd295c44ff@aspeedtech.com
> ---
> Changes in v2:
> - Fix IBI processing logic to properly handle IBIs without data payload.
> - Link to v1: https://lore.kernel.org/r/20260331-i3c-hci-dma-v1-1-e5cd295c44ff@aspeedtech.com
> ---
> drivers/i3c/master/mipi-i3c-hci/dma.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master/mipi-i3c-hci/dma.c b/drivers/i3c/master/mipi-i3c-hci/dma.c
> index b903a2da1fd1..c7272155c486 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/dma.c
> +++ b/drivers/i3c/master/mipi-i3c-hci/dma.c
> @@ -721,7 +721,10 @@ static void hci_dma_process_ibi(struct i3c_hci *hci, struct hci_rh_data *rh)
> if (!(ibi_status & IBI_LAST_STATUS)) {
> ibi_size += chunks * rh->ibi_chunk_sz;
> } else {
> - ibi_size += FIELD_GET(IBI_DATA_LENGTH, ibi_status);
> + if (chunks) {
> + ibi_size += (chunks - 1) * rh->ibi_chunk_sz;
> + ibi_size += FIELD_GET(IBI_DATA_LENGTH, ibi_status);
this should be added to ibi_size reguardless chucks.
if (chunks)
ibi_size += (chunks - 1) * rh->ibi_chunk_sz;
ibi_size += FIELD_GET(IBI_DATA_LENGTH, ibi_status);
Frank
> + }
> last_ptr = ptr;
> break;
> }
>
> ---
> base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
> change-id: 20260331-i3c-hci-dma-3aae908b4e8e
>
> Best regards,
> --
> Billy Tsai <billy_tsai@aspeedtech.com>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] i3c: mipi-i3c-hci: fix IBI payload length calculation for final status
2026-04-08 7:39 ` Frank Li
@ 2026-04-09 1:31 ` Billy Tsai
2026-04-09 3:57 ` Frank Li
0 siblings, 1 reply; 5+ messages in thread
From: Billy Tsai @ 2026-04-09 1:31 UTC (permalink / raw)
To: Frank Li
Cc: Alexandre Belloni, Nicolas Pitre, Boris Brezillon, linux-i3c,
linux-kernel
> > In DMA mode, the IBI status descriptor encodes the payload using
> > CHUNKS (number of chunks) and DATA_LENGTH (valid bytes in the last
> > chunk). All preceding chunks are implicitly full-sized.
> >
> > The current code accumulates full chunk sizes for non-final status
> > descriptors, but for the final status descriptor it only adds
> > DATA_LENGTH. This ignores the contribution of the preceding full
> > chunks described by the same final status entry.
> >
> > As a result, the computed IBI payload length is truncated whenever
> > the final status spans multiple chunks. For example, with a chunk
> > size of 4 bytes, CHUNKS=2 and DATA_LENGTH=1 should result in a total
> > payload size of 5 bytes, but the current code reports only 1 byte.
> >
> > Fix the calculation by adding the size of (CHUNKS - 1) full chunks
> > plus DATA_LENGTH for the last chunk.
> >
> > Fixes: 9ad9a52cce28 ("i3c/master: introduce the mipi-i3c-hci driver")
> > Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
> > ---
> > Changes in v2:
> > - EDITME: describe what is new in this series revision.
> > - EDITME: use bulletpoints and terse descriptions.
> > - Link to v1: https://lore.kernel.org/r/20260331-i3c-hci-dma-v1-1-e5cd295c44ff@aspeedtech.com
> > ---
> > Changes in v2:
> > - Fix IBI processing logic to properly handle IBIs without data payload.
> > - Link to v1: https://lore.kernel.org/r/20260331-i3c-hci-dma-v1-1-e5cd295c44ff@aspeedtech.com
> > ---
> > drivers/i3c/master/mipi-i3c-hci/dma.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/i3c/master/mipi-i3c-hci/dma.c b/drivers/i3c/master/mipi-i3c-hci/dma.c
> > index b903a2da1fd1..c7272155c486 100644
> > --- a/drivers/i3c/master/mipi-i3c-hci/dma.c
> > +++ b/drivers/i3c/master/mipi-i3c-hci/dma.c
> > @@ -721,7 +721,10 @@ static void hci_dma_process_ibi(struct i3c_hci *hci, struct hci_rh_data *rh)
> > if (!(ibi_status & IBI_LAST_STATUS)) {
> > ibi_size += chunks * rh->ibi_chunk_sz;
> > } else {
> > - ibi_size += FIELD_GET(IBI_DATA_LENGTH, ibi_status);
> > + if (chunks) {
> > + ibi_size += (chunks - 1) * rh->ibi_chunk_sz;
> > + ibi_size += FIELD_GET(IBI_DATA_LENGTH, ibi_status);
> this should be added to ibi_size reguardless chucks.
>
> if (chunks)
> ibi_size += (chunks - 1) * rh->ibi_chunk_sz;
>
> ibi_size += FIELD_GET(IBI_DATA_LENGTH, ibi_status);
According to the HCI spec, CHUNKS represents the number of valid data
chunks in the IBI Data Ring, while DATA_LENGTH (in DMA mode) represents
the number of valid bytes in the last data chunk.
This implies that DATA_LENGTH is only meaningful when at least one
chunk exists. If CHUNKS == 0, there is no "last data chunk", and thus
DATA_LENGTH is expected to be 0.
So a combination of CHUNKS == 0 with a non-zero DATA_LENGTH would be
an invalid descriptor encoding.
To follow your suggestion and still keep the logic robust, we can
always account DATA_LENGTH, but add a defensive check for this
invalid condition:
if (chunks)
ibi_size += (chunks - 1) * rh->ibi_chunk_sz;
if (unlikely(!chunks &&
FIELD_GET(IBI_DATA_LENGTH, ibi_status)))
WARN_ON(1);
ibi_size += FIELD_GET(IBI_DATA_LENGTH, ibi_status);
This way we handle the normal case as expected, while still catching
any invalid encoding from the controller.
Thanks
Billy Tsai
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] i3c: mipi-i3c-hci: fix IBI payload length calculation for final status
2026-04-09 1:31 ` Billy Tsai
@ 2026-04-09 3:57 ` Frank Li
0 siblings, 0 replies; 5+ messages in thread
From: Frank Li @ 2026-04-09 3:57 UTC (permalink / raw)
To: Billy Tsai
Cc: Alexandre Belloni, Nicolas Pitre, Boris Brezillon, linux-i3c,
linux-kernel
On Thu, Apr 09, 2026 at 01:31:16AM +0000, Billy Tsai wrote:
>
> > > In DMA mode, the IBI status descriptor encodes the payload using
> > > CHUNKS (number of chunks) and DATA_LENGTH (valid bytes in the last
> > > chunk). All preceding chunks are implicitly full-sized.
> > >
> > > The current code accumulates full chunk sizes for non-final status
> > > descriptors, but for the final status descriptor it only adds
> > > DATA_LENGTH. This ignores the contribution of the preceding full
> > > chunks described by the same final status entry.
> > >
> > > As a result, the computed IBI payload length is truncated whenever
> > > the final status spans multiple chunks. For example, with a chunk
> > > size of 4 bytes, CHUNKS=2 and DATA_LENGTH=1 should result in a total
> > > payload size of 5 bytes, but the current code reports only 1 byte.
> > >
> > > Fix the calculation by adding the size of (CHUNKS - 1) full chunks
> > > plus DATA_LENGTH for the last chunk.
> > >
> > > Fixes: 9ad9a52cce28 ("i3c/master: introduce the mipi-i3c-hci driver")
> > > Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
> > > ---
> > > Changes in v2:
> > > - EDITME: describe what is new in this series revision.
> > > - EDITME: use bulletpoints and terse descriptions.
> > > - Link to v1: https://lore.kernel.org/r/20260331-i3c-hci-dma-v1-1-e5cd295c44ff@aspeedtech.com
> > > ---
> > > Changes in v2:
> > > - Fix IBI processing logic to properly handle IBIs without data payload.
> > > - Link to v1: https://lore.kernel.org/r/20260331-i3c-hci-dma-v1-1-e5cd295c44ff@aspeedtech.com
> > > ---
> > > drivers/i3c/master/mipi-i3c-hci/dma.c | 5 ++++-
> > > 1 file changed, 4 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/i3c/master/mipi-i3c-hci/dma.c b/drivers/i3c/master/mipi-i3c-hci/dma.c
> > > index b903a2da1fd1..c7272155c486 100644
> > > --- a/drivers/i3c/master/mipi-i3c-hci/dma.c
> > > +++ b/drivers/i3c/master/mipi-i3c-hci/dma.c
> > > @@ -721,7 +721,10 @@ static void hci_dma_process_ibi(struct i3c_hci *hci, struct hci_rh_data *rh)
> > > if (!(ibi_status & IBI_LAST_STATUS)) {
> > > ibi_size += chunks * rh->ibi_chunk_sz;
> > > } else {
> > > - ibi_size += FIELD_GET(IBI_DATA_LENGTH, ibi_status);
> > > + if (chunks) {
> > > + ibi_size += (chunks - 1) * rh->ibi_chunk_sz;
> > > + ibi_size += FIELD_GET(IBI_DATA_LENGTH, ibi_status);
>
> > this should be added to ibi_size reguardless chucks.
> >
> > if (chunks)
> > ibi_size += (chunks - 1) * rh->ibi_chunk_sz;
> >
> > ibi_size += FIELD_GET(IBI_DATA_LENGTH, ibi_status);
>
> According to the HCI spec, CHUNKS represents the number of valid data
> chunks in the IBI Data Ring, while DATA_LENGTH (in DMA mode) represents
> the number of valid bytes in the last data chunk.
>
> This implies that DATA_LENGTH is only meaningful when at least one
> chunk exists. If CHUNKS == 0, there is no "last data chunk", and thus
> DATA_LENGTH is expected to be 0.
>
> So a combination of CHUNKS == 0 with a non-zero DATA_LENGTH would be
> an invalid descriptor encoding.
If it is true, your code should be fine.
Reviewed-by: Frank Li <Frank.Li@nxp.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] i3c: mipi-i3c-hci: fix IBI payload length calculation for final status
2026-04-07 8:53 [PATCH v2] i3c: mipi-i3c-hci: fix IBI payload length calculation for final status Billy Tsai
2026-04-08 7:39 ` Frank Li
@ 2026-04-12 20:07 ` Alexandre Belloni
1 sibling, 0 replies; 5+ messages in thread
From: Alexandre Belloni @ 2026-04-12 20:07 UTC (permalink / raw)
To: Frank Li, Nicolas Pitre, Boris Brezillon, Billy Tsai
Cc: linux-i3c, linux-kernel
On Tue, 07 Apr 2026 16:53:23 +0800, Billy Tsai wrote:
> In DMA mode, the IBI status descriptor encodes the payload using
> CHUNKS (number of chunks) and DATA_LENGTH (valid bytes in the last
> chunk). All preceding chunks are implicitly full-sized.
>
> The current code accumulates full chunk sizes for non-final status
> descriptors, but for the final status descriptor it only adds
> DATA_LENGTH. This ignores the contribution of the preceding full
> chunks described by the same final status entry.
>
> [...]
Applied, thanks!
[1/1] i3c: mipi-i3c-hci: fix IBI payload length calculation for final status
https://git.kernel.org/i3c/c/d35a6db887ee
Best regards,
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-04-12 20:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-07 8:53 [PATCH v2] i3c: mipi-i3c-hci: fix IBI payload length calculation for final status Billy Tsai
2026-04-08 7:39 ` Frank Li
2026-04-09 1:31 ` Billy Tsai
2026-04-09 3:57 ` Frank Li
2026-04-12 20:07 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®