mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Matthew Sakai <msakai@redhat.com>
Cc: Colin Ian King <colin.i.king@gmail.com>,
	dm-devel@lists.linux.dev,  kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] dm vdo: Fix spelling mistake "postive" -> "positive"
Date: Thu, 3 Sep 2026 15:25:59 -0400 (EDT)	[thread overview]
Message-ID: <ae8b93d1-2967-d4bf-4c2d-2b110b9d2fc4@crashcourse.ca> (raw)
In-Reply-To: <1d2cd544-97a6-4ddd-8758-048bbd104eb5@redhat.com>

On Thu, 3 Sep 2026, Matthew Sakai wrote:

> I had to look at this for quite a while to figure out what was going on.
> We made the same spelling error twice in the same function and somehow only
> noticed the first one previously? Anyway,
>
> Reviewed-by: Matthew Sakai <msakai@redhat.com>
>
> On 9/3/26 11:23 AM, Colin Ian King wrote:
> > There is another spelling mistake in a vdo_log_error message that
> > I somehow overlooked last time. Fix it.
> >
> > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> > ---
> >   drivers/md/dm-vdo/dm-vdo-target.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/md/dm-vdo/dm-vdo-target.c
> > b/drivers/md/dm-vdo/dm-vdo-target.c
> > index 1d8375cc3c3e..043549b1fc2e 100644
> > --- a/drivers/md/dm-vdo/dm-vdo-target.c
> > +++ b/drivers/md/dm-vdo/dm-vdo-target.c
> > @@ -443,7 +443,7 @@ static int __must_check parse_slab_size(const char
> > *slab_str, block_count_t *sla
> >     	result = kstrtoull(slab_str, 10, &value);
> >   	if (result) {
> > -		vdo_log_error("optional parameter error: invalid slab size,
> > must be a postive integer");
> > +		vdo_log_error("optional parameter error: invalid slab size,
> > must be a positive integer");
> >   		return -EINVAL;
> >   	}

  My rule from years back was ... you find one typo, you "grep -rw"
the entire kernel tree.

rday

  reply	other threads:[~2026-09-03 20:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03 15:23 Colin Ian King
2026-09-03 19:06 ` Matthew Sakai
2026-09-03 19:25   ` Robert P. J. Day [this message]
2026-09-03 19:29     ` Colin King (gmail)
  -- strict thread matches above, loose matches on Subject: below --
2026-03-28 12:33 Colin Ian King
2026-03-31 12:40 ` Matthew Sakai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae8b93d1-2967-d4bf-4c2d-2b110b9d2fc4@crashcourse.ca \
    --to=rpjday@crashcourse.ca \
    --cc=colin.i.king@gmail.com \
    --cc=dm-devel@lists.linux.dev \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=msakai@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®