mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Colin King (gmail)" <colin.i.king@gmail.com>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>,
	Matthew Sakai <msakai@redhat.com>
Cc: dm-devel@lists.linux.dev, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] dm vdo: Fix spelling mistake "postive" -> "positive"
Date: Thu, 3 Sep 2026 20:29:19 +0100	[thread overview]
Message-ID: <d12c133f-2caf-4c9d-928b-b8372dd1c7dc@gmail.com> (raw)
In-Reply-To: <ae8b93d1-2967-d4bf-4c2d-2b110b9d2fc4@crashcourse.ca>


[-- Attachment #1.1: Type: text/plain, Size: 1530 bytes --]

On 03/09/2026 20:25, Robert P. J. Day wrote:
> On Thu, 3 Sep 2026, Matthew Sakai wrote:
> 
>> I had to look at this for quite a while to figure out what was going on.
>> We made the same spelling error twice in the same function and somehow only
>> noticed the first one previously? Anyway,
>>
>> Reviewed-by: Matthew Sakai <msakai@redhat.com>
>>
>> On 9/3/26 11:23 AM, Colin Ian King wrote:
>>> There is another spelling mistake in a vdo_log_error message that
>>> I somehow overlooked last time. Fix it.
>>>
>>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>>> ---
>>>    drivers/md/dm-vdo/dm-vdo-target.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/md/dm-vdo/dm-vdo-target.c
>>> b/drivers/md/dm-vdo/dm-vdo-target.c
>>> index 1d8375cc3c3e..043549b1fc2e 100644
>>> --- a/drivers/md/dm-vdo/dm-vdo-target.c
>>> +++ b/drivers/md/dm-vdo/dm-vdo-target.c
>>> @@ -443,7 +443,7 @@ static int __must_check parse_slab_size(const char
>>> *slab_str, block_count_t *sla
>>>      	result = kstrtoull(slab_str, 10, &value);
>>>    	if (result) {
>>> -		vdo_log_error("optional parameter error: invalid slab size,
>>> must be a postive integer");
>>> +		vdo_log_error("optional parameter error: invalid slab size,
>>> must be a positive integer");
>>>    		return -EINVAL;
>>>    	}
> 
>    My rule from years back was ... you find one typo, you "grep -rw"
> the entire kernel tree.

Yup, normally do, somehow this slipped through :-(

> 
> rday


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

  reply	other threads:[~2026-09-03 19:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03 15:23 Colin Ian King
2026-09-03 19:06 ` Matthew Sakai
2026-09-03 19:25   ` Robert P. J. Day
2026-09-03 19:29     ` Colin King (gmail) [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-03-28 12:33 Colin Ian King
2026-03-31 12:40 ` Matthew Sakai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d12c133f-2caf-4c9d-928b-b8372dd1c7dc@gmail.com \
    --to=colin.i.king@gmail.com \
    --cc=dm-devel@lists.linux.dev \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=msakai@redhat.com \
    --cc=rpjday@crashcourse.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®