From: <Ryan.Wanner@microchip.com>
To: <claudiu.beznea@tuxon.dev>, <andrew+netdev@lunn.ch>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <robh@kernel.org>, <krzk+dt@kernel.org>,
<onor+dt@kernel.org>, <alexandre.belloni@bootlin.com>
Cc: <Nicolas.Ferre@microchip.com>, <netdev@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 5/6] ARM: dts: microchip: sama7d65: Add MCP16502 to sama7d65 curiosity
Date: Mon, 14 Apr 2025 15:38:32 +0000 [thread overview]
Message-ID: <af92ffff-f900-4f29-8d26-2516a3c91805@microchip.com> (raw)
In-Reply-To: <6e52883b-2811-4ac2-9763-5974ca463274@tuxon.dev>
Hi Claudiu,
On 4/11/25 07:30, Claudiu Beznea wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Hi, Ryan,
>
> On 01.04.2025 19:13, Ryan.Wanner@microchip.com wrote:
>> From: Ryan Wanner <Ryan.Wanner@microchip.com>
>>
>> Add MCP16502 to the sama7d65_curiosity board to control voltages in the
>> MPU. The device is connected to twi 10 interface
>>
>> Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com>
>> ---
>> .../dts/microchip/at91-sama7d65_curiosity.dts | 135 ++++++++++++++++++
>> 1 file changed, 135 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dts b/arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dts
>> index 441370dbb4c2..81abc387112d 100644
>> --- a/arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dts
>> +++ b/arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dts
>> @@ -30,6 +30,15 @@ memory@60000000 {
>> device_type = "memory";
>> reg = <0x60000000 0x40000000>;
>> };
>> +
>> + reg_5v: regulator-5v {
>> + compatible = "regulator-fixed";
>> + regulator-name = "5V_MAIN";
>> + regulator-min-microvolt = <5000000>;
>> + regulator-max-microvolt = <5000000>;
>> + regulator-always-on;
>> + };
>> +
>> };
>>
>> &dma0 {
>> @@ -99,6 +108,132 @@ channel@4 {
>> label = "VDDCPU";
>> };
>> };
>> +
>> + pmic@5b {
>> + compatible = "microchip,mcp16502";
>> + reg = <0x5b>;
>> + lvin-supply = <®_5v>;
>> + pvin1-supply = <®_5v>;
>> + pvin2-supply = <®_5v>;
>> + pvin3-supply = <®_5v>;
>> + pvin4-supply = <®_5v>;
>> + status = "okay";
>> +
>> + regulators {
>> + vdd_3v3: VDD_IO {
>> + regulator-name = "VDD_IO";
>> + regulator-min-microvolt = <3300000>;
>> + regulator-max-microvolt = <3300000>;
>> + regulator-initial-mode = <2>;
>> + regulator-allowed-modes = <2>, <4>;
>> + regulator-always-on;
>> +
>> + regulator-state-standby {
>> + regulator-on-in-suspend;
>> + regulator-suspend-microvolt = <3300000>;
>> + regulator-mode = <4>;
>> + };
>> +
>> + regulator-state-mem {
>> + regulator-off-in-suspend;
>> + regulator-mode = <4>;
>> + };
>> + };
>> +
>> + vddioddr: VDD_DDR {
>> + regulator-name = "VDD_DDR";
>> + regulator-min-microvolt = <1350000>;
>> + regulator-max-microvolt = <1350000>;
>> + regulator-initial-mode = <2>;
>> + regulator-allowed-modes = <2>, <4>;
>> + regulator-always-on;
>> +
>> + regulator-state-standby {
>> + regulator-on-in-suspend;
>> + regulator-suspend-microvolt = <1350000>;
>> + regulator-mode = <4>;
>> + };
>> +
>> + regulator-state-mem {
>> + regulator-on-in-suspend;
>> + regulator-suspend-microvolt = <1350000>;
>> + regulator-mode = <4>;
>> + };
>> + };
>> +
>> + vddcore: VDD_CORE {
>> + regulator-name = "VDD_CORE";
>> + regulator-min-microvolt = <1050000>;
>> + regulator-max-microvolt = <1050000>;
>> + regulator-initial-mode = <2>;
>> + regulator-allowed-modes = <2>, <4>;
>> + regulator-always-on;
>> +
>> + regulator-state-standby {
>> + regulator-on-in-suspend;
>> + regulator-suspend-microvolt = <1050000>;
>> + regulator-mode = <4>;
>> + };
>> +
>> + regulator-state-mem {
>> + regulator-off-in-suspend;
>> + regulator-mode = <4>;
>> + };
>> + };
>> +
>> + vddcpu: VDD_OTHER {
>> + regulator-name = "VDD_OTHER";
>> + regulator-min-microvolt = <1050000>;
>> + regulator-max-microvolt = <1250000>;
>> + regulator-initial-mode = <2>;
>> + regulator-allowed-modes = <2>, <4>;
>> + regulator-ramp-delay = <3125>;
>> + regulator-always-on;
>> +
>> + regulator-state-standby {
>> + regulator-on-in-suspend;
>> + regulator-suspend-microvolt = <1050000>;
>> + regulator-mode = <4>;
>> + };
>> +
>> + regulator-state-mem {
>> + regulator-off-in-suspend;
>> + regulator-mode = <4>;
>> + };
>> + };
>> +
>> + vldo1: LDO1 {
>> + regulator-name = "LDO1";
>> + regulator-min-microvolt = <1800000>;
>> + regulator-max-microvolt = <1800000>;
>> + regulator-always-on;
>> +
>> + regulator-state-standby {
>> + regulator-suspend-microvolt = <1800000>;
>> + regulator-on-in-suspend;
>> + };
>> +
>> + regulator-state-mem {
>> + regulator-off-in-suspend;
>> + };
>> + };
>> +
>> + vldo2: LDO2 {
>> + regulator-name = "LDO2";
>> + regulator-min-microvolt = <1200000>;
>> + regulator-max-microvolt = <3700000>;
>> +
>> + regulator-state-standby {
>> + regulator-suspend-microvolt = <1800000>;
>
> I can't find the schematics for this board. Is there a reason for keeping
> this @1.8V in suspend?
Sorry this was an error on my part, there is no reason to have this
@1.8V in suspend mode.
Best,
Ryan
>
> Thank you,
> Claudiu
>
>> + regulator-on-in-suspend;
>> + };
>> +
>> + regulator-state-mem {
>> + regulator-off-in-suspend;
>> + };
>> + };
>> + };
>> + };
>> };
>>
>> &main_xtal {
>
next prev parent reply other threads:[~2025-04-14 15:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 16:13 [PATCH 0/6] Enable FLEXCOMs and GMAC for SAMA7D65 SoC Ryan.Wanner
2025-04-01 16:13 ` [PATCH 1/6] dt-bindings: net: cdns,macb: add sama7d65 ethernet interface Ryan.Wanner
2025-04-02 0:54 ` Jakub Kicinski
2025-04-02 13:28 ` Conor Dooley
2025-04-01 16:13 ` [PATCH 2/6] ARM: dts: microchip: sama7d65: Add gmac interfaces for sama7d65 SoC Ryan.Wanner
2025-04-01 16:13 ` [PATCH 3/6] ARM: dts: microchip: sama7d65: Add FLEXCOMs to " Ryan.Wanner
2025-04-11 14:29 ` Claudiu Beznea
2025-04-01 16:13 ` [PATCH 4/6] ARM: dts: microchip: sama7d65: Enable GMAC interface Ryan.Wanner
2025-04-11 14:29 ` Claudiu Beznea
2025-04-01 16:13 ` [PATCH 5/6] ARM: dts: microchip: sama7d65: Add MCP16502 to sama7d65 curiosity Ryan.Wanner
2025-04-11 14:30 ` Claudiu Beznea
2025-04-14 15:38 ` Ryan.Wanner [this message]
2025-04-27 13:43 ` Claudiu Beznea
2025-04-01 16:13 ` [PATCH 6/6] ARM: dts: microchip: sama7d65_curiosity: add EEPROM Ryan.Wanner
2025-04-27 13:44 ` [PATCH 0/6] Enable FLEXCOMs and GMAC for SAMA7D65 SoC Claudiu Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af92ffff-f900-4f29-8d26-2516a3c91805@microchip.com \
--to=ryan.wanner@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew+netdev@lunn.ch \
--cc=claudiu.beznea@tuxon.dev \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=onor+dt@kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®