From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Stepan Ionichev <sozdayvek@gmail.com>
Cc: andy@kernel.org, geert@linux-m68k.org,
gregkh@linuxfoundation.org, hcazarim@yahoo.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] auxdisplay: Kconfig: drop unneeded quotes in PANEL_BOOT_MESSAGE dep
Date: Sun, 17 May 2026 08:58:01 +0300 [thread overview]
Message-ID: <aglY6bn-cnMySChf@ashevche-desk.local> (raw)
In-Reply-To: <20260515133005.32305-1-sozdayvek@gmail.com>
On Fri, May 15, 2026 at 06:30:04PM +0500, Stepan Ionichev wrote:
> The PANEL_BOOT_MESSAGE dependency uses a quoted-string comparison
> against the PANEL_CHANGE_MESSAGE bool symbol:
>
> depends on PANEL_CHANGE_MESSAGE="y"
>
> This is the only such pattern under drivers/auxdisplay/ (grep shows
> no other Kconfig file in the tree uses depends on FOO="y" with
> quotes for a plain bool symbol). The quoted form is parsed by
> Kconfig but is not idiomatic; the common form for the same intent
> is the unquoted tristate-style dependency:
>
> depends on PANEL_CHANGE_MESSAGE
>
> which evaluates true when PANEL_CHANGE_MESSAGE is y or m. Since
> PANEL_CHANGE_MESSAGE is declared as bool (not tristate), there is
> no behaviour change in practice: y is the only enabled value
> either form can match.
>
> Drop the quoted comparison so the dependency matches the prevailing
> kernel Kconfig style and so it is obvious to readers that the
> comparison works.
Pushed to my review and testing queue, thanks!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-05-17 5:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 13:30 Stepan Ionichev
2026-05-17 5:51 ` Andy Shevchenko
2026-05-17 5:58 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aglY6bn-cnMySChf@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=hcazarim@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sozdayvek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®