[PATCH] auxdisplay: Kconfig: drop unneeded quotes in PANEL_BOOT_MESSAGE dep

[PATCH] auxdisplay: Kconfig: drop unneeded quotes in PANEL_BOOT_MESSAGE dep

[Stepan Ionichev]

The PANEL_BOOT_MESSAGE dependency uses a quoted-string comparison
against the PANEL_CHANGE_MESSAGE bool symbol:

	depends on PANEL_CHANGE_MESSAGE="y"

This is the only such pattern under drivers/auxdisplay/ (grep shows
no other Kconfig file in the tree uses depends on FOO="y" with
quotes for a plain bool symbol). The quoted form is parsed by
Kconfig but is not idiomatic; the common form for the same intent
is the unquoted tristate-style dependency:

	depends on PANEL_CHANGE_MESSAGE

which evaluates true when PANEL_CHANGE_MESSAGE is y or m. Since
PANEL_CHANGE_MESSAGE is declared as bool (not tristate), there is
no behaviour change in practice: y is the only enabled value
either form can match.

Drop the quoted comparison so the dependency matches the prevailing
kernel Kconfig style and so it is obvious to readers that the
comparison works.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/CAHp75VfsA_LsbEKjxoeMdbhPbWj7OHZ7=0SYNA3c=ZLj_M94Bw@mail.gmail.com
Signed-off-by: Stepan Ionichev <sozdayvek@gmail.com>
---
 drivers/auxdisplay/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
index bedc6133f..1ea7c0391 100644
--- a/drivers/auxdisplay/Kconfig
+++ b/drivers/auxdisplay/Kconfig
@@ -327,7 +327,7 @@ config PANEL_CHANGE_MESSAGE
 	  say 'N' and keep the default message with the version.
 
 config PANEL_BOOT_MESSAGE
-	depends on PANEL_CHANGE_MESSAGE="y"
+	depends on PANEL_CHANGE_MESSAGE
 	string "New initialization message"
 	default ""
 	help
-- 
2.43.0

Re: [PATCH] auxdisplay: Kconfig: drop unneeded quotes in PANEL_BOOT_MESSAGE dep

[Andy Shevchenko]

On Fri, May 15, 2026 at 06:30:04PM +0500, Stepan Ionichev wrote:
> The PANEL_BOOT_MESSAGE dependency uses a quoted-string comparison
> against the PANEL_CHANGE_MESSAGE bool symbol:
> 
> 	depends on PANEL_CHANGE_MESSAGE="y"
> 
> This is the only such pattern under drivers/auxdisplay/ (grep shows
> no other Kconfig file in the tree uses depends on FOO="y" with
> quotes for a plain bool symbol). The quoted form is parsed by
> Kconfig but is not idiomatic; the common form for the same intent
> is the unquoted tristate-style dependency:
> 
> 	depends on PANEL_CHANGE_MESSAGE

Strictly speaking we need to have =y in case if PANEL_CHANGE_MESSAGE becomes a
tristate. But I don't believe it will ever happen IRL.

> which evaluates true when PANEL_CHANGE_MESSAGE is y or m. Since
> PANEL_CHANGE_MESSAGE is declared as bool (not tristate), there is
> no behaviour change in practice: y is the only enabled value
> either form can match.
> 
> Drop the quoted comparison so the dependency matches the prevailing
> kernel Kconfig style and so it is obvious to readers that the
> comparison works.

Thanks, I'm going to apply this.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] auxdisplay: Kconfig: drop unneeded quotes in PANEL_BOOT_MESSAGE dep

[Andy Shevchenko]

On Fri, May 15, 2026 at 06:30:04PM +0500, Stepan Ionichev wrote:
> The PANEL_BOOT_MESSAGE dependency uses a quoted-string comparison
> against the PANEL_CHANGE_MESSAGE bool symbol:
> 
> 	depends on PANEL_CHANGE_MESSAGE="y"
> 
> This is the only such pattern under drivers/auxdisplay/ (grep shows
> no other Kconfig file in the tree uses depends on FOO="y" with
> quotes for a plain bool symbol). The quoted form is parsed by
> Kconfig but is not idiomatic; the common form for the same intent
> is the unquoted tristate-style dependency:
> 
> 	depends on PANEL_CHANGE_MESSAGE
> 
> which evaluates true when PANEL_CHANGE_MESSAGE is y or m. Since
> PANEL_CHANGE_MESSAGE is declared as bool (not tristate), there is
> no behaviour change in practice: y is the only enabled value
> either form can match.
> 
> Drop the quoted comparison so the dependency matches the prevailing
> kernel Kconfig style and so it is obvious to readers that the
> comparison works.

Pushed to my review and testing queue, thanks!

-- 
With Best Regards,
Andy Shevchenko