From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Revert "lib: fix _parse_integer_limit() to handle overflow"
Date: Fri, 3 Jul 2026 09:05:00 +0300 [thread overview]
Message-ID: <akdRDEbm2OhC0kpE@ashevche-desk.local> (raw)
In-Reply-To: <ec031afa-c7bc-4444-b73c-3bcc9aae046c@yandex.ru>
On Fri, Jul 03, 2026 at 08:55:03AM +0300, Dmitry Antipov wrote:
> On 7/2/26 9:06 PM, Alexey Dobriyan wrote:
>
> > 1) this patch breaks scanf() which uses _parse_integer_limit()
> > internally, and is supposed to get overflowed result (however
> > incorrect it may be)
> >
> > 2) using check_mul_overflow() and check_add_overflow() as written
> > doesn't add any overflow protection because it is under branch where
> > such overflow can't happen if radix is kept <=16,
>
> It would be helpful to see an examples (preferably designed
> as KUnit tests) to illustrate these breakages.
+1. We need test cases, since there were none what is the real life example of
the breakage?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-07-03 6:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 18:06 Alexey Dobriyan
2026-07-03 5:55 ` Dmitry Antipov
2026-07-03 6:05 ` Andy Shevchenko [this message]
2026-07-03 6:52 ` Dmitry Antipov
2026-07-03 10:21 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akdRDEbm2OhC0kpE@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dmantipov@yandex.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox