From: Alexey Dobriyan <adobriyan@gmail.com>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Revert "lib: fix _parse_integer_limit() to handle overflow"
Date: Fri, 3 Jul 2026 13:21:57 +0300 [thread overview]
Message-ID: <e1ac4c3b-2591-4496-bc80-0a479e326aee@p183> (raw)
In-Reply-To: <8283a924-2598-4627-b2d2-11912a8b4fd7@yandex.ru>
On Fri, Jul 03, 2026 at 09:52:34AM +0300, Dmitry Antipov wrote:
> On 7/3/26 9:05 AM, Andy Shevchenko wrote:
>
> > +1. We need test cases, since there were none what is the real life example of
> > the breakage?
>
> I've (qemu-)tried:
>
> CONFIG_PRINTF_KUNIT_TEST=y
> CONFIG_SCANF_KUNIT_TEST=y
> CONFIG_CMDLINE_KUNIT_TEST=y
>
> on x86_64, arm, and riscv - without seeing anything suspicious...
This code was written in such a way to have common code between old
scanf/strtoul code (which parsed incorrectly) and new kstrt*() code.
scanf/strtoul instances were left alone to rot.
You can not do "res = ULLONG_MAX;"
prev parent reply other threads:[~2026-07-03 10:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 18:06 Alexey Dobriyan
2026-07-03 5:55 ` Dmitry Antipov
2026-07-03 6:05 ` Andy Shevchenko
2026-07-03 6:52 ` Dmitry Antipov
2026-07-03 10:21 ` Alexey Dobriyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1ac4c3b-2591-4496-bc80-0a479e326aee@p183 \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@intel.com \
--cc=dmantipov@yandex.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®