[PATCH] gpiolib: remove trailing comma from sentinel in GPIO_LOOKUP_SINGLE

[PATCH] gpiolib: remove trailing comma from sentinel in GPIO_LOOKUP_SINGLE

[Dmitry Torokhov]

The GPIO_LOOKUP_SINGLE macro defines a lookup table with a single entry
followed by an empty sentinel entry. The sentinel entry has a trailing
comma which is unnecessary. Remove it.

Assisted-by: Antigravity:gemini-3.5-flash
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 include/linux/gpio/machine.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/gpio/machine.h b/include/linux/gpio/machine.h
index 5eb88f5d0630..1a141056716f 100644
--- a/include/linux/gpio/machine.h
+++ b/include/linux/gpio/machine.h
@@ -54,7 +54,7 @@ static struct gpiod_lookup_table _name = {				\
 	.dev_id = _dev_id,						\
 	.table = {							\
 		GPIO_LOOKUP(_key, _chip_hwnum, _con_id, _flags),	\
-		{},							\
+		{ }							\
 	},								\
 }
 
-- 
2.55.0.795.g602f6c329a-goog


-- 
Dmitry

Re: [PATCH] gpiolib: remove trailing comma from sentinel in GPIO_LOOKUP_SINGLE

[Andy Shevchenko]

On Mon, Jul 13, 2026 at 04:29:16PM -0700, Dmitry Torokhov wrote:
> The GPIO_LOOKUP_SINGLE macro defines a lookup table with a single entry

GPIO_LOOKUP_SINGLE()

> followed by an empty sentinel entry. The sentinel entry has a trailing
> comma which is unnecessary. Remove it.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] gpiolib: remove trailing comma from sentinel in GPIO_LOOKUP_SINGLE

[Bartosz Golaszewski]

On Mon, 13 Jul 2026 16:29:16 -0700, Dmitry Torokhov wrote:
> The GPIO_LOOKUP_SINGLE macro defines a lookup table with a single entry
> followed by an empty sentinel entry. The sentinel entry has a trailing
> comma which is unnecessary. Remove it.
> 
> 

Applied, thanks!

[1/1] gpiolib: remove trailing comma from sentinel in GPIO_LOOKUP_SINGLE
      https://git.kernel.org/brgl/c/7cefedf0c4a2d943f96f440b433bf71a1a8261d7

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

Re: [PATCH] gpiolib: remove trailing comma from sentinel in GPIO_LOOKUP_SINGLE

[Bartosz Golaszewski]

On Tue, 14 Jul 2026 10:41:39 +0200, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> said:
> On Mon, Jul 13, 2026 at 04:29:16PM -0700, Dmitry Torokhov wrote:
>> The GPIO_LOOKUP_SINGLE macro defines a lookup table with a single entry
>
> GPIO_LOOKUP_SINGLE()
>

I fixed it when applying.

>> followed by an empty sentinel entry. The sentinel entry has a trailing
>> comma which is unnecessary. Remove it.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>

I queued it but I do consider it a bit of a needless churn TBH.

Bart

Re: [PATCH] gpiolib: remove trailing comma from sentinel in GPIO_LOOKUP_SINGLE

[Andy Shevchenko]

On Wed, Jul 15, 2026 at 08:11:06AM +0000, Bartosz Golaszewski wrote:
> On Tue, 14 Jul 2026 10:41:39 +0200, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> said:
> > On Mon, Jul 13, 2026 at 04:29:16PM -0700, Dmitry Torokhov wrote:
> >> The GPIO_LOOKUP_SINGLE macro defines a lookup table with a single entry
> >
> > GPIO_LOOKUP_SINGLE()
> 
> I fixed it when applying.

Thanks!

> >> followed by an empty sentinel entry. The sentinel entry has a trailing
> >> comma which is unnecessary. Remove it.
> >
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> I queued it but I do consider it a bit of a needless churn TBH.

You should really be against Uwe's patches then! :-)

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] gpiolib: remove trailing comma from sentinel in GPIO_LOOKUP_SINGLE

[Bartosz Golaszewski]

On Wed, 15 Jul 2026 10:36:22 +0200, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> said:
> On Wed, Jul 15, 2026 at 08:11:06AM +0000, Bartosz Golaszewski wrote:
>> On Tue, 14 Jul 2026 10:41:39 +0200, Andy Shevchenko
>> <andriy.shevchenko@linux.intel.com> said:
>> > On Mon, Jul 13, 2026 at 04:29:16PM -0700, Dmitry Torokhov wrote:
>> >> The GPIO_LOOKUP_SINGLE macro defines a lookup table with a single entry
>> >
>> > GPIO_LOOKUP_SINGLE()
>>
>> I fixed it when applying.
>
> Thanks!
>
>> >> followed by an empty sentinel entry. The sentinel entry has a trailing
>> >> comma which is unnecessary. Remove it.
>> >
>> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>
>> I queued it but I do consider it a bit of a needless churn TBH.
>
> You should really be against Uwe's patches then! :-)
>

He's fixing more stuff and removing trailing commas is just part of it. And as
you can see - I did apply it and will apply Uwe's series too.

Bart