From: "Maciej W. Rozycki" <macro@imgtec.com>
To: Paul Burton <paul.burton@imgtec.com>
Cc: Matt Redfearn <matt.redfearn@imgtec.com>,
Ralf Baechle <ralf@linux-mips.org>, <linux-mips@linux-mips.org>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Thomas Gleixner <tglx@linutronix.de>,
<linux-kernel@vger.kernel.org>,
James Hogan <james.hogan@imgtec.com>
Subject: Re: [PATCH 3/5] MIPS: Only change $28 to thread_info if coming from user mode
Date: Mon, 5 Dec 2016 17:41:49 +0000 [thread overview]
Message-ID: <alpine.DEB.2.00.1612051733070.6743@tp.orcam.me.uk> (raw)
In-Reply-To: <40031221.jIbnRxB01Q@np-p-burton>
On Mon, 5 Dec 2016, Paul Burton wrote:
> Agreed we ought to use .set reorder (or rather, not use .set noreorder)
> wherever possible but FYI one thing I've only noticed recently is that we
> don't actually get any reordering anyway, presumably because we don't provide
> any -O flags when building asm source. I haven't yet done the legwork or
> figuring out whether we've ever had optimisation & if so what changed...
Reordering or `-O2' is the default for GAS, you actually have to pass a
different `-O*' option explicitly to GAS to disable it. NB it's *not* the
same as passing one of the `-O*' options to GCC, you'd need e.g. `-Wa,-O'.
So perhaps one of our Makefiles or a particular configuration of the GCC
driver does the wrong thing?
Maciej
next prev parent reply other threads:[~2016-12-05 17:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 13:39 [PATCH 0/5] MIPS: Add per-cpu IRQ stack Matt Redfearn
2016-12-02 13:39 ` [PATCH 1/5] MIPS: Introduce irq_stack Matt Redfearn
2016-12-06 22:13 ` Jason A. Donenfeld
2016-12-07 9:25 ` Matt Redfearn
2016-12-02 13:39 ` [PATCH 2/5] MIPS: Stack unwinding while on IRQ stack Matt Redfearn
2016-12-02 13:39 ` [PATCH 3/5] MIPS: Only change $28 to thread_info if coming from user mode Matt Redfearn
2016-12-05 16:20 ` Maciej W. Rozycki
2016-12-05 16:52 ` Matt Redfearn
2016-12-05 17:22 ` Maciej W. Rozycki
2016-12-05 17:27 ` Paul Burton
2016-12-05 17:41 ` Maciej W. Rozycki [this message]
2016-12-02 13:39 ` [PATCH 4/5] MIPS: Switch to the irq_stack in interrupts Matt Redfearn
2016-12-02 13:39 ` [PATCH 5/5] MIPS: Select HAVE_IRQ_EXIT_ON_IRQ_STACK Matt Redfearn
2016-12-06 22:09 ` [PATCH 0/5] MIPS: Add per-cpu IRQ stack Jason A. Donenfeld
2016-12-07 9:30 ` Matt Redfearn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1612051733070.6743@tp.orcam.me.uk \
--to=macro@imgtec.com \
--cc=Jason@zx2c4.com \
--cc=james.hogan@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=matt.redfearn@imgtec.com \
--cc=paul.burton@imgtec.com \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®