From: Parag Warudkar <parag.lkml@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Parag Warudkar <parag.lkml@gmail.com>,
Jens Axboe <jaxboe@fusionio.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"James.Bottomley@hansenpartnership.com"
<James.Bottomley@hansenpartnership.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
Linux SCSI List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] SCSI IOCTL: Check for device deletion [was Re: __elv_add_request OOPS]
Date: Wed, 25 May 2011 16:42:15 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.2.02.1105251638220.8972@ubuntu-natty> (raw)
In-Reply-To: <BANLkTimndXcBJ9wwJrcTt3Pf3vaNVUUtwg@mail.gmail.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 761 bytes --]
On Wed, 25 May 2011, Linus Torvalds wrote:
> On Wed, May 25, 2011 at 1:18 PM, Parag Warudkar <parag.lkml@gmail.com> wrote:
> > SDEV_OFFLINE, /* Device offlined (by error handling or
> > * user request */
>
> So how do you fix the error or online it again? No chance it should
> have commands passed to it to do that?
Yeah - that makes sense. By that logic, looks like we can only disallow
for SDEV_DEL (if we decide to do that check here).
> I don't know. My point is that I don't see why we should look at the
> state at this point at all. We do that _later_.
If we can do it later, well and good. I just didn't think it would hurt to
check upfront in ioctl if we are dealing with a dead device.
Parag
next prev parent reply other threads:[~2011-05-25 20:42 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-24 4:29 __elv_add_request OOPS Parag Warudkar
2011-05-24 10:44 ` Jens Axboe
2011-05-25 1:41 ` [PATCH] SCSI IOCTL: Check for device deletion [was Re: __elv_add_request OOPS] Parag Warudkar
2011-05-25 7:37 ` Jens Axboe
2011-05-25 18:44 ` Parag Warudkar
2011-05-25 18:55 ` Linus Torvalds
2011-05-25 19:02 ` Jens Axboe
2011-05-25 19:13 ` Linus Torvalds
2011-05-25 19:17 ` Jens Axboe
2011-05-25 19:52 ` Parag Warudkar
2011-05-25 20:03 ` Linus Torvalds
2011-05-25 20:18 ` Parag Warudkar
2011-05-25 20:26 ` Linus Torvalds
2011-05-25 20:42 ` Parag Warudkar [this message]
2011-05-25 20:52 ` James Bottomley
2011-05-25 23:00 ` Parag Warudkar
2011-05-25 23:14 ` Linus Torvalds
2011-05-25 23:45 ` Parag Warudkar
2011-05-25 23:52 ` Linus Torvalds
[not found] ` <1306370123.1641.76.camel@mulgrave.site>
2011-05-26 1:01 ` Linus Torvalds
2011-05-26 1:06 ` James Bottomley
2011-05-26 1:43 ` Parag Warudkar
2011-05-27 3:53 ` James Bottomley
2011-05-27 5:43 ` Jens Axboe
2011-05-27 20:21 ` James Bottomley
2011-05-28 12:42 ` Jens Axboe
2011-06-08 6:50 ` Torsten Hilbrich
2011-05-25 20:20 ` James Bottomley
2011-05-25 20:22 ` Parag Warudkar
2011-05-25 20:29 ` James Bottomley
2011-05-25 20:26 ` __elv_add_request OOPS James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1105251638220.8972@ubuntu-natty \
--to=parag.lkml@gmail.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®