mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ASoC: wm8804: Cleanup of post_table
@ 2014-01-12 11:31 Daniel Matuschek
  2014-01-12 17:03 ` Crazy Audio
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel Matuschek @ 2014-01-12 11:31 UTC (permalink / raw)
  To: alsa-devel
  Cc: info, Dimitris.Papastamos, Liam Girdwood, Mark Brown,
	Jaroslav Kysela, Takashi Iwai, patches, linux-kernel


Signed-off-by: Daniel 
Matuschek <inof@crazy-audio.com>

  Existing post_table has duplicate settings for some PLL settings.
  Only the first setting was used with mclk_div=1
  With the updated post_table, the driver
  uses mclk_div=0 whenever it is possible. This allows the WM8804
  to work at 256xfs internal clock and only use 128xfs
  internal clock for high sample rates where 256xfs is not
  supported anymore.

---
  sound/soc/codecs/wm8804.c |    2 --
  1 file changed, 2 deletions(-)

diff --git a/sound/soc/codecs/wm8804.c b/sound/soc/codecs/wm8804.c
index 1704b1e..f605b8b 100644
--- a/sound/soc/codecs/wm8804.c
+++ b/sound/soc/codecs/wm8804.c
@@ -307,9 +307,7 @@ static struct {
  	unsigned int mclkdiv;
  } post_table[] = {
  	{  2,  0, 0 },
-	{  4,  0, 1 },
  	{  4,  1, 0 },
-	{  8,  1, 1 },
  	{  8,  2, 0 },
  	{ 16,  2, 1 },
  	{ 12,  3, 0 },
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ASoC: wm8804: Cleanup of post_table
  2014-01-12 11:31 [PATCH] ASoC: wm8804: Cleanup of post_table Daniel Matuschek
@ 2014-01-12 17:03 ` Crazy Audio
  0 siblings, 0 replies; 2+ messages in thread
From: Crazy Audio @ 2014-01-12 17:03 UTC (permalink / raw)
  To: Daniel Matuschek
  Cc: alsa-devel, Dimitris.Papastamos, Liam Girdwood, Mark Brown,
	Jaroslav Kysela, Takashi Iwai, patches, linux-kernel

Please ignore this patch. I did some regression tests, that shows, that it does not work correctly with MCLK=256xfs
I will create a new patch...


Am 12.01.2014 um 12:31 schrieb Daniel Matuschek <daniel@matuschek.net>:

> 
> Signed-off-by: Daniel Matuschek <inof@crazy-audio.com>
> 
> Existing post_table has duplicate settings for some PLL settings.
> Only the first setting was used with mclk_div=1
> With the updated post_table, the driver
> uses mclk_div=0 whenever it is possible. This allows the WM8804
> to work at 256xfs internal clock and only use 128xfs
> internal clock for high sample rates where 256xfs is not
> supported anymore.
> 
> ---
> sound/soc/codecs/wm8804.c |    2 --
> 1 file changed, 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/wm8804.c b/sound/soc/codecs/wm8804.c
> index 1704b1e..f605b8b 100644
> --- a/sound/soc/codecs/wm8804.c
> +++ b/sound/soc/codecs/wm8804.c
> @@ -307,9 +307,7 @@ static struct {
> 	unsigned int mclkdiv;
> } post_table[] = {
> 	{  2,  0, 0 },
> -	{  4,  0, 1 },
> 	{  4,  1, 0 },
> -	{  8,  1, 1 },
> 	{  8,  2, 0 },
> 	{ 16,  2, 1 },
> 	{ 12,  3, 0 },
> -- 
> 1.7.9.5
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-01-12 17:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-12 11:31 [PATCH] ASoC: wm8804: Cleanup of post_table Daniel Matuschek
2014-01-12 17:03 ` Crazy Audio

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®