From: Thomas Gleixner <tglx@linutronix.de>
To: Huang Shijie <shijie.huang@arm.com>
Cc: jiang.liu@linux.intel.com, marc.zyngier@arm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irqdomain: remove the confused log
Date: Tue, 25 Aug 2015 21:34:00 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1508252131280.15006@nanos> (raw)
In-Reply-To: <1440496131-29192-1-git-send-email-shijie.huang@arm.com>
On Tue, 25 Aug 2015, Huang Shijie wrote:
> When the dynamic debug is enabled for irq domain, the kernel will print out:
> ------------------------------------------------------
> irqdomain:__irq_domain_add: irq: Added domain (null)
> ------------------------------------------------------
>
> It does not print out the irq domain's name, since the @domain->name is NULL.
> Keep the log here just makes people nervous.
Well, it might be NULL in your case, but there are enough cases where
its not NULL and the output valuable.
Aside of that I don't understand what's making one nervous
here. People who enable that debug stuff should know that this can be
NULL and just deal with it. If they get nervous about it they probably
should not try to debug that code in the first place.
Thanks,
tglx
next prev parent reply other threads:[~2015-08-25 19:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 9:48 Huang Shijie
2015-08-25 19:34 ` Thomas Gleixner [this message]
2015-08-26 1:37 ` Huang Shijie
2015-08-26 7:50 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1508252131280.15006@nanos \
--to=tglx@linutronix.de \
--cc=jiang.liu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=shijie.huang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®