From: Thomas Gleixner <tglx@linutronix.de>
To: Huang Shijie <shijie.huang@arm.com>
Cc: jiang.liu@linux.intel.com, marc.zyngier@arm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irqdomain: remove the confused log
Date: Wed, 26 Aug 2015 09:50:14 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1508260948470.15006@nanos> (raw)
In-Reply-To: <20150826013747.GA30900@free64-pc.asiapac.arm.com>
On Wed, 26 Aug 2015, Huang Shijie wrote:
> On Tue, Aug 25, 2015 at 09:34:00PM +0200, Thomas Gleixner wrote:
> > On Tue, 25 Aug 2015, Huang Shijie wrote:
> >
> > > When the dynamic debug is enabled for irq domain, the kernel will print out:
> > > ------------------------------------------------------
> > > irqdomain:__irq_domain_add: irq: Added domain (null)
> > > ------------------------------------------------------
> > >
> > > It does not print out the irq domain's name, since the @domain->name is NULL.
> > > Keep the log here just makes people nervous.
> >
> > Well, it might be NULL in your case, but there are enough cases where
> > its not NULL and the output valuable.
> In which case ?
>
> The domain is allocated by kzalloc_node(), so @domain->name is NULL in the function.
> The @domain->name is set in other function, such as irq_domain_associate().
Indeed. I misread the patch, sorry. Yes that thing can go.
Thanks,
tglx
prev parent reply other threads:[~2015-08-26 7:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 9:48 Huang Shijie
2015-08-25 19:34 ` Thomas Gleixner
2015-08-26 1:37 ` Huang Shijie
2015-08-26 7:50 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1508260948470.15006@nanos \
--to=tglx@linutronix.de \
--cc=jiang.liu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=shijie.huang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®