* [PATCH] irq_remapping: move structs outside #ifdef
@ 2015-09-18 16:06 Paolo Bonzini
2015-09-18 18:43 ` Thomas Gleixner
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2015-09-18 16:06 UTC (permalink / raw)
To: linux-kernel, kvm
Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin,
maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT),
Jiang Liu, Joerg Roedel, Feng Wu, Paolo Bonzini
This is friendlier to clients of the code, who are going to prepare
vcpu_data structs unconditionally, even if CONFIG_IRQ_REMAP is not
defined.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
Please ack, I'd like to include it in the 4.4 pull request.
arch/x86/include/asm/irq_remapping.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/x86/include/asm/irq_remapping.h b/arch/x86/include/asm/irq_remapping.h
index 046c7fb1ca43..a210eba2727c 100644
--- a/arch/x86/include/asm/irq_remapping.h
+++ b/arch/x86/include/asm/irq_remapping.h
@@ -33,6 +33,11 @@ enum irq_remap_cap {
IRQ_POSTING_CAP = 0,
};
+struct vcpu_data {
+ u64 pi_desc_addr; /* Physical address of PI Descriptor */
+ u32 vector; /* Guest vector of the interrupt */
+};
+
#ifdef CONFIG_IRQ_REMAP
extern bool irq_remapping_cap(enum irq_remap_cap cap);
@@ -58,11 +63,6 @@ static inline struct irq_domain *arch_get_ir_parent_domain(void)
return x86_vector_domain;
}
-struct vcpu_data {
- u64 pi_desc_addr; /* Physical address of PI Descriptor */
- u32 vector; /* Guest vector of the interrupt */
-};
-
#else /* CONFIG_IRQ_REMAP */
static inline bool irq_remapping_cap(enum irq_remap_cap cap) { return 0; }
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] irq_remapping: move structs outside #ifdef
2015-09-18 16:06 [PATCH] irq_remapping: move structs outside #ifdef Paolo Bonzini
@ 2015-09-18 18:43 ` Thomas Gleixner
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Gleixner @ 2015-09-18 18:43 UTC (permalink / raw)
To: Paolo Bonzini
Cc: linux-kernel, kvm, Ingo Molnar, H. Peter Anvin,
maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT),
Jiang Liu, Joerg Roedel, Feng Wu
On Fri, 18 Sep 2015, Paolo Bonzini wrote:
> This is friendlier to clients of the code, who are going to prepare
> vcpu_data structs unconditionally, even if CONFIG_IRQ_REMAP is not
> defined.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
> ---
> Please ack, I'd like to include it in the 4.4 pull request.
>
> arch/x86/include/asm/irq_remapping.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/x86/include/asm/irq_remapping.h b/arch/x86/include/asm/irq_remapping.h
> index 046c7fb1ca43..a210eba2727c 100644
> --- a/arch/x86/include/asm/irq_remapping.h
> +++ b/arch/x86/include/asm/irq_remapping.h
> @@ -33,6 +33,11 @@ enum irq_remap_cap {
> IRQ_POSTING_CAP = 0,
> };
>
> +struct vcpu_data {
> + u64 pi_desc_addr; /* Physical address of PI Descriptor */
> + u32 vector; /* Guest vector of the interrupt */
> +};
> +
> #ifdef CONFIG_IRQ_REMAP
>
> extern bool irq_remapping_cap(enum irq_remap_cap cap);
> @@ -58,11 +63,6 @@ static inline struct irq_domain *arch_get_ir_parent_domain(void)
> return x86_vector_domain;
> }
>
> -struct vcpu_data {
> - u64 pi_desc_addr; /* Physical address of PI Descriptor */
> - u32 vector; /* Guest vector of the interrupt */
> -};
> -
> #else /* CONFIG_IRQ_REMAP */
>
> static inline bool irq_remapping_cap(enum irq_remap_cap cap) { return 0; }
> --
> 1.8.3.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-18 18:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-18 16:06 [PATCH] irq_remapping: move structs outside #ifdef Paolo Bonzini
2015-09-18 18:43 ` Thomas Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®