mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Andi Kleen <andi@firstfloor.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
	Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] x86: Fix thermal throttling reporting after kexec
Date: Thu, 1 Oct 2015 14:15:54 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.11.1510011413151.4500@nanos> (raw)
In-Reply-To: <1443125443-24691-1-git-send-email-andi@firstfloor.org>

On Thu, 24 Sep 2015, Andi Kleen wrote:
> The per CPU thermal vector init code checks if the thermal
> vector is already installed and complains and bails out if
> it is.
> 
> This happens after kexec, as kernel shut down does
> not clear the thermal vector APIC register.

So the obvious question is, why don't we do that.

> Just remove the check. I checked the code and there's
> no valid code paths where the thermal init code for a CPU
> could be called multiple times.

I'm not against removing that check as it does not really add value,
but we still should clear the APIC register at shut down, right?

Thanks,

	tglx

  reply	other threads:[~2015-10-01 12:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-24 20:10 Andi Kleen
2015-10-01 12:15 ` Thomas Gleixner [this message]
2015-10-01 17:27   ` Andi Kleen
2015-10-01 21:41     ` Thomas Gleixner
2015-10-01 21:50       ` Andi Kleen
2015-10-01 22:04         ` Andi Kleen
2015-10-02 20:33           ` Thomas Gleixner
2015-10-11 19:37             ` Thomas Gleixner
2015-10-12 20:32 Andi Kleen
2015-10-12 20:33 ` Thomas Gleixner
2015-10-13 10:43   ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1510011413151.4500@nanos \
    --to=tglx@linutronix.de \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®