mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org
Subject: Re: [PATCH 1/2] arch/x86: Fix sparse warning symbol not declared
Date: Sun, 12 Feb 2017 11:57:11 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1702121146370.3734@nanos> (raw)
In-Reply-To: <1486881870-2490-2-git-send-email-me@tobin.cc>

On Sun, 12 Feb 2017, Tobin C. Harding wrote:

A few nitpicks.

> Subject: [PATCH 1/2] arch/x86: Fix sparse warning symbol not declared

arch/x86: is not the correct prefix. Run git log on a file to figure out
what the usual prefix is. The file was checked in with 'purgatory', but I'd
prefer 'x86/purgatory' for future changes.

> This patch adds static declaration to a number of variables. Fixes
> sparse symbol was not declared warnings.

Please read 'Documentation...SubmittingPatches' and look for 'This patch'.

I give you an example for a changelog:

  Sparse emits several 'symbol not declared' warnings.

  Make the variables and functions, which have only file scope static.

Now try to map that to the advise in Documentation.

Thanks,

	tglx

  reply	other threads:[~2017-02-12 10:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-12  6:44 [PATCH 0/2] arch/x86: Fix sparse warning Tobin C. Harding
2017-02-12  6:44 ` [PATCH 1/2] arch/x86: Fix sparse warning symbol not declared Tobin C. Harding
2017-02-12 10:57   ` Thomas Gleixner [this message]
2017-02-12  6:44 ` [PATCH 2/2] " Tobin C. Harding
2017-02-12 11:06   ` Thomas Gleixner
2017-02-13 20:26     ` Tobin Harding
2017-02-13 21:24       ` Thomas Gleixner
2017-02-21  8:19         ` Tobin Harding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1702121146370.3734@nanos \
    --to=tglx@linutronix.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@tobin.cc \
    --cc=mingo@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®