mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: simran singhal <singhalsimran0@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 3/6] staging: rtl8192e: Fix block comments warning
Date: Sat, 18 Feb 2017 16:30:44 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1702181628130.3112@hadrien> (raw)
In-Reply-To: <20170218152351.GA28908@singhal-Inspiron-5558>



On Sat, 18 Feb 2017, simran singhal wrote:

> Align * on a line, to conform to the kernal coding
> style for block comments.

It is not clear what is means to align * on a line.  What line?

What has been done is to add a space at the beginning of the line.  But
then the line goes over 80 characters and doesn't line up any more on the
right side.  I would guess that you should have gotten a new warning by
having gone over 80 characters. Fixing one warning should not introduce a
new one, especially for something purely decorative, like this.

julia

>
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
> ---
>  drivers/staging/rtl8192e/rtl819x_HT.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h
> index 6eb018f..48d101a 100644
> --- a/drivers/staging/rtl8192e/rtl819x_HT.h
> +++ b/drivers/staging/rtl8192e/rtl819x_HT.h
> @@ -11,7 +11,7 @@
>   *
>   * Contact Information:
>   * wlanfae <wlanfae@realtek.com>
> -******************************************************************************/
> + ******************************************************************************/
>  #ifndef _RTL819XU_HTTYPE_H_
>  #define _RTL819XU_HTTYPE_H_
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170218152351.GA28908%40singhal-Inspiron-5558.
> For more options, visit https://groups.google.com/d/optout.
>

  reply	other threads:[~2017-02-18 15:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-18 15:23 simran singhal
2017-02-18 15:30 ` Julia Lawall [this message]
     [not found]   ` <5192275f-5b36-4e1d-8d66-afc735f3a8f6@googlegroups.com>
2017-02-18 16:16     ` [Outreachy kernel] " Julia Lawall
     [not found]       ` <da5a9bc2-9a49-4fac-b7e8-eb686d14ad1e@googlegroups.com>
2017-02-18 17:11         ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1702181628130.3112@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=singhalsimran0@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®