[PATCH 3/6] staging: rtl8192e: Fix block comments warning

[PATCH 3/6] staging: rtl8192e: Fix block comments warning

[simran singhal]

Align * on a line, to conform to the kernal coding
style for block comments.

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
 drivers/staging/rtl8192e/rtl819x_HT.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h
index 6eb018f..48d101a 100644
--- a/drivers/staging/rtl8192e/rtl819x_HT.h
+++ b/drivers/staging/rtl8192e/rtl819x_HT.h
@@ -11,7 +11,7 @@
  *
  * Contact Information:
  * wlanfae <wlanfae@realtek.com>
-******************************************************************************/
+ ******************************************************************************/
 #ifndef _RTL819XU_HTTYPE_H_
 #define _RTL819XU_HTTYPE_H_
 
-- 
2.7.4

Re: [Outreachy kernel] [PATCH 3/6] staging: rtl8192e: Fix block comments warning

[Julia Lawall]

On Sat, 18 Feb 2017, simran singhal wrote:

> Align * on a line, to conform to the kernal coding
> style for block comments.

It is not clear what is means to align * on a line.  What line?

What has been done is to add a space at the beginning of the line.  But
then the line goes over 80 characters and doesn't line up any more on the
right side.  I would guess that you should have gotten a new warning by
having gone over 80 characters. Fixing one warning should not introduce a
new one, especially for something purely decorative, like this.

julia

>
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
> ---
>  drivers/staging/rtl8192e/rtl819x_HT.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h
> index 6eb018f..48d101a 100644
> --- a/drivers/staging/rtl8192e/rtl819x_HT.h
> +++ b/drivers/staging/rtl8192e/rtl819x_HT.h
> @@ -11,7 +11,7 @@
>   *
>   * Contact Information:
>   * wlanfae <wlanfae@realtek.com>
> -******************************************************************************/
> + ******************************************************************************/
>  #ifndef _RTL819XU_HTTYPE_H_
>  #define _RTL819XU_HTTYPE_H_
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170218152351.GA28908%40singhal-Inspiron-5558.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH 3/6] staging: rtl8192e: Fix block comments warning

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 3052 bytes --]



On Sat, 18 Feb 2017, SIMRAN SINGHAL wrote:

>
>
> On Saturday, February 18, 2017 at 9:00:51 PM UTC+5:30, Julia Lawall wrote:
>
>
>       On Sat, 18 Feb 2017, simran singhal wrote:
>
>       > Align * on a line, to conform to the kernal coding
>       > style for block comments.
>
>       It is not clear what is means to align * on a line.  What line?
>
>       What has been done is to add a space at the beginning of the
>       line.  But
>       then the line goes over 80 characters and doesn't line up any
>       more on the
>       right side.  I would guess that you should have gotten a new
>       warning by
>       having gone over 80 characters. Fixing one warning should not
>       introduce a
>       new one, especially for something purely decorative, like this.
>
>       julia
>
>  Julia, I am not getting any new warning. It's not gone over 80 characters.

OK, it looked like it would be too long on my screen.

Are the right sides of the * lines lined up after the change?

julia

>  
>       >
>       > Signed-off-by: simran singhal <singhal...@gmail.com>
>       > ---
>       >  drivers/staging/rtl8192e/rtl819x_HT.h | 2 +-
>       >  1 file changed, 1 insertion(+), 1 deletion(-)
>       >
>       > diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h
>       b/drivers/staging/rtl8192e/rtl819x_HT.h
>       > index 6eb018f..48d101a 100644
>       > --- a/drivers/staging/rtl8192e/rtl819x_HT.h
>       > +++ b/drivers/staging/rtl8192e/rtl819x_HT.h
>       > @@ -11,7 +11,7 @@
>       >   *
>       >   * Contact Information:
>       >   * wlanfae <wla...@realtek.com>
>       >-**************************************************************************
>       ****/
>       > +***************************************************************************
>       ***/
>       >  #ifndef _RTL819XU_HTTYPE_H_
>       >  #define _RTL819XU_HTTYPE_H_
>       >
>       > --
>       > 2.7.4
>       >
>       > --
>       > You received this message because you are subscribed to the
>       Google Groups "outreachy-kernel" group.
>       > To unsubscribe from this group and stop receiving emails from
>       it, send an email to outreachy-kern...@googlegroups.com.
>       > To post to this group, send email to
>       outreach...@googlegroups.com.
>       > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20170218152351.GA28908%4
>       0singhal-Inspiron-5558.
>       > For more options, visit https://groups.google.com/d/optout.
>       >
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/5192275f-5b36-4e1d-8d66-
> afc735f3a8f6%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>

Re: [Outreachy kernel] [PATCH 3/6] staging: rtl8192e: Fix block comments warning

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 4716 bytes --]

On Sat, 18 Feb 2017, SIMRAN SINGHAL wrote:

>
>
> On Saturday, February 18, 2017 at 9:46:48 PM UTC+5:30, Julia Lawall wrote:
>
>
>       On Sat, 18 Feb 2017, SIMRAN SINGHAL wrote:
>
>       >
>       >
>       > On Saturday, February 18, 2017 at 9:00:51 PM UTC+5:30, Julia
>       Lawall wrote:
>       >
>       >
>       >       On Sat, 18 Feb 2017, simran singhal wrote:
>       >
>       >       > Align * on a line, to conform to the kernal coding
>       >       > style for block comments.
>       >
>       >       It is not clear what is means to align * on a line.
>        What line?
>       >
>       >       What has been done is to add a space at the beginning of
>       the
>       >       line.  But
>       >       then the line goes over 80 characters and doesn't line
>       up any
>       >       more on the
>       >       right side.  I would guess that you should have gotten a
>       new
>       >       warning by
>       >       having gone over 80 characters. Fixing one warning
>       should not
>       >       introduce a
>       >       new one, especially for something purely decorative,
>       like this.
>       >
>       >       julia
>       >
>       >  Julia, I am not getting any new warning. It's not gone over
>       80 characters.
>
>       OK, it looked like it would be too long on my screen.
>
>       Are the right sides of the * lines lined up after the change?
>
>       julia
>
> In the right sides of the * lines, stars are lined up. 

OK, thanks.

julia

>       >  
>       >       >
>       >       > Signed-off-by: simran singhal <singhal...@gmail.com>
>       >       > ---
>       >       >  drivers/staging/rtl8192e/rtl819x_HT.h | 2 +-
>       >       >  1 file changed, 1 insertion(+), 1 deletion(-)
>       >       >
>       >       > diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h
>       >       b/drivers/staging/rtl8192e/rtl819x_HT.h
>       >       > index 6eb018f..48d101a 100644
>       >       > --- a/drivers/staging/rtl8192e/rtl819x_HT.h
>       >       > +++ b/drivers/staging/rtl8192e/rtl819x_HT.h
>       >       > @@ -11,7 +11,7 @@
>       >       >   *
>       >       >   * Contact Information:
>       >       >   * wlanfae <wla...@realtek.com>
>       >      >-*************************************************************************
>       *
>       >       ****/
>       >       >+**************************************************************************
>       *
>       >       ***/
>       >       >  #ifndef _RTL819XU_HTTYPE_H_
>       >       >  #define _RTL819XU_HTTYPE_H_
>       >       >
>       >       > --
>       >       > 2.7.4
>       >       >
>       >       > --
>       >       > You received this message because you are subscribed
>       to the
>       >       Google Groups "outreachy-kernel" group.
>       >       > To unsubscribe from this group and stop receiving
>       emails from
>       >       it, send an email to outreachy-kern...@googlegroups.com.
>       >       > To post to this group, send email to
>       >       outreach...@googlegroups.com.
>       >       > To view this discussion on the webvisithttps://groups.google.com/d/msgid/outreachy-kernel/20170218152351.GA28
>       908%4
>       >       0singhal-Inspiron-5558.
>       >       > For more options, visit
>       https://groups.google.com/d/optout.
>       >       >
>       >
>       > --
>       > You received this message because you are subscribed to the
>       Google Groups
>       > "outreachy-kernel" group.
>       > To unsubscribe from this group and stop receiving emails from
>       it, send an
>       > email to outreachy-kern...@googlegroups.com.
>       > To post to this group, send email to
>       outreach...@googlegroups.com.
>       > To view this discussion on the webvisithttps://groups.google.com/d/msgid/outreachy-kernel/5192275f-5b36-4e1d-
>       8d66-
>       > afc735f3a8f6%40googlegroups.com.
>       > For more options, visit https://groups.google.com/d/optout.
>       >
>       >
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/da5a9bc2-9a49-4fac-b7e8-
> eb686d14ad1e%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>