[PATCH v4] staging: pi433: Fixes minor typo errors

[PATCH v4] staging: pi433: Fixes minor typo errors

[harsha]

From: Harsha Sharma <harshasharmaiitr@gmail.com>

Fixes checkpatch warning -- "occured" and "succesfully" are misspelled

Signed-off-by: Harsha Sharma <harshasharmaiitr@gmail.com>
---
Changes in v4:
 -Correct the format of the subject.
 -Signed-off properly.
 drivers/staging/pi433/pi433_if.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index 6b9b7df..6a10478 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -473,7 +473,7 @@ struct pi433_instance {
 	}
 
 
-	/* rx done, wait was interrupted or error occured */
+	/* rx done, wait was interrupted or error occurred */
 abort:
 	dev->interrupt_rx_allowed = true;
 	SET_CHECKED(rf69_set_mode(dev->spi, standby));
@@ -1033,7 +1033,7 @@ static int setup_GPIOs(struct pi433_device *device)
 		if (retval)
 			return retval;
 
-		dev_dbg(&device->spi->dev, "%s succesfully configured", name);
+		dev_dbg(&device->spi->dev, "%s successfully configured", name);
 	}
 
 	return 0;
-- 
1.9.1

Re: [Outreachy kernel] [PATCH v4] staging: pi433: Fixes minor typo errors

[Julia Lawall]

On Fri, 8 Sep 2017, harsha wrote:

> From: Harsha Sharma <harshasharmaiitr@gmail.com>
>
> Fixes checkpatch warning -- "occured" and "succesfully" are misspelled
>
> Signed-off-by: Harsha Sharma <harshasharmaiitr@gmail.com>
> ---
> Changes in v4:
>  -Correct the format of the subject.
>  -Signed-off properly.

It's not signed off properly.  Like Greg just said (maybe the mails
crossed), the sign off needs to be the same as the From line.  This
probably relates to your git configuration or your mailer.  Send the patch
to yourself before sending it out on the mailing list to be sure that
everything is ok.

julia

>  drivers/staging/pi433/pi433_if.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index 6b9b7df..6a10478 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -473,7 +473,7 @@ struct pi433_instance {
>  	}
>
>
> -	/* rx done, wait was interrupted or error occured */
> +	/* rx done, wait was interrupted or error occurred */
>  abort:
>  	dev->interrupt_rx_allowed = true;
>  	SET_CHECKED(rf69_set_mode(dev->spi, standby));
> @@ -1033,7 +1033,7 @@ static int setup_GPIOs(struct pi433_device *device)
>  		if (retval)
>  			return retval;
>
> -		dev_dbg(&device->spi->dev, "%s succesfully configured", name);
> +		dev_dbg(&device->spi->dev, "%s successfully configured", name);
>  	}
>
>  	return 0;
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1504863598-16301-1-git-send-email-harshasharmaiitr%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH v4] staging: pi433: Fixes minor typo errors

[Dan Carpenter]

On Fri, Sep 08, 2017 at 11:45:20AM +0200, Julia Lawall wrote:
> 
> 
> On Fri, 8 Sep 2017, harsha wrote:
> 
> > From: Harsha Sharma <harshasharmaiitr@gmail.com>
> >
> > Fixes checkpatch warning -- "occured" and "succesfully" are misspelled
> >
> > Signed-off-by: Harsha Sharma <harshasharmaiitr@gmail.com>
> > ---
> > Changes in v4:
> >  -Correct the format of the subject.
> >  -Signed-off properly.
> 
> It's not signed off properly.  Like Greg just said (maybe the mails
> crossed), the sign off needs to be the same as the From line.  This
> probably relates to your git configuration or your mailer.  Send the patch
> to yourself before sending it out on the mailing list to be sure that
> everything is ok.
> 

This is actually OK-ish...  It's better when we don't have the extra
From: and there is no need for that with gmail, but we sometimes allow
it for companies which have broken mailservers.

regards,
dan carpenter

Re: [Outreachy kernel] [PATCH v4] staging: pi433: Fixes minor typo errors

[Julia Lawall]

On Fri, 8 Sep 2017, Dan Carpenter wrote:

> On Fri, Sep 08, 2017 at 11:45:20AM +0200, Julia Lawall wrote:
> >
> >
> > On Fri, 8 Sep 2017, harsha wrote:
> >
> > > From: Harsha Sharma <harshasharmaiitr@gmail.com>
> > >
> > > Fixes checkpatch warning -- "occured" and "succesfully" are misspelled
> > >
> > > Signed-off-by: Harsha Sharma <harshasharmaiitr@gmail.com>
> > > ---
> > > Changes in v4:
> > >  -Correct the format of the subject.
> > >  -Signed-off properly.
> >
> > It's not signed off properly.  Like Greg just said (maybe the mails
> > crossed), the sign off needs to be the same as the From line.  This
> > probably relates to your git configuration or your mailer.  Send the patch
> > to yourself before sending it out on the mailing list to be sure that
> > everything is ok.
> >
>
> This is actually OK-ish...  It's better when we don't have the extra
> From: and there is no need for that with gmail, but we sometimes allow
> it for companies which have broken mailservers.

Oops, I'm sorry. I didn't see the extra From line.

SubmittingPatches says that the From line should be provided:

The ``from`` line must be the very first line in the message body,
and has the form:

        From: Original Author <author@example.com>

It does say:

If the ``from`` line is missing, then the ``From:`` line from the email
header will be used to determine the patch author in the changelog.

But it doesn't convey the same spirit as "we sometimes allow".

julia


>
> regards,
> dan carpenter
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170908095039.ns6kjwa2j5jbrrbi%40mwanda.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH v4] staging: pi433: Fixes minor typo errors

[Dan Carpenter]

True.

Of course, normally the from line means you're forwarding a patch from
someone else and then it's totally appropriate.  I don't like From lines
because it's just an extra thing to check.  How do we know that they're
not just pretending to be someone from @MajorCorporation.com?

regards,
dan carpenter