From: Julia Lawall <julia.lawall@lip6.fr>
To: Harsha Sharma <harshasharmaiitr@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 01/10] staging: rtl8723bs: Add spaces around '='
Date: Sun, 10 Sep 2017 21:44:07 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1709102143550.6548@hadrien> (raw)
In-Reply-To: <7b2a57c6f3eb01142a73e92124fdf06a7504e68e.1505052882.git.harshasharmaiitr@gmail.com>
On Sun, 10 Sep 2017, Harsha Sharma wrote:
> Use one space around (on each side of) '=' operator
>
> Signed-off-by: Harsha Sharma <harshasharmaiitr@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> index 0215899..7f22ca9 100644
> --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> @@ -121,7 +121,7 @@
>
> static int rtw_enusbss = 0;/* 0:disable, 1:enable */
>
> -static int rtw_hwpdn_mode =2;/* 0:disable, 1:enable, 2: by EFUSE config */
> +static int rtw_hwpdn_mode = 2;/* 0:disable, 1:enable, 2: by EFUSE config */
>
> #ifdef CONFIG_HW_PWRP_DETECTION
> static int rtw_hwpwrp_detect = 1;
> @@ -183,7 +183,7 @@
>
> module_param(rtw_hw_wps_pbc, int, 0644);
>
> -static uint rtw_max_roaming_times =2;
> +static uint rtw_max_roaming_times = 2;
> module_param(rtw_max_roaming_times, uint, 0644);
> MODULE_PARM_DESC(rtw_max_roaming_times,"The max roaming times to try");
>
> @@ -255,8 +255,8 @@ static uint loadparam(struct adapter *padapter, _nic_hdl pnetdev)
>
> registry_par->vrtl_carrier_sense = (u8)rtw_vrtl_carrier_sense ;
> registry_par->vcs_type = (u8)rtw_vcs_type;
> - registry_par->rts_thresh =(u16)rtw_rts_thresh;
> - registry_par->frag_thresh =(u16)rtw_frag_thresh;
> + registry_par->rts_thresh = (u16)rtw_rts_thresh;
> + registry_par->frag_thresh = (u16)rtw_frag_thresh;
> registry_par->preamble = (u8)rtw_preamble;
> registry_par->scan_mode = (u8)rtw_scan_mode;
> registry_par->adhoc_tx_pwr = (u8)rtw_adhoc_tx_pwr;
> @@ -652,8 +652,8 @@ static u8 rtw_init_default_value(struct adapter *padapter)
> #ifdef CONFIG_GTK_OL
> psecuritypriv->binstallKCK_KEK = _FAIL;
> #endif /* CONFIG_GTK_OL */
> - psecuritypriv->sw_encrypt =pregistrypriv->software_encrypt;
> - psecuritypriv->sw_decrypt =pregistrypriv->software_decrypt;
> + psecuritypriv->sw_encrypt = pregistrypriv->software_encrypt;
> + psecuritypriv->sw_decrypt = pregistrypriv->software_decrypt;
>
> psecuritypriv->dot11AuthAlgrthm = dot11AuthAlgrthm_Open; /* open system */
> psecuritypriv->dot11PrivacyAlgrthm = _NO_PRIVACY_;
> @@ -777,7 +777,7 @@ u8 rtw_init_drv_sw(struct adapter *padapter)
> goto exit;
> }
>
> - padapter->cmdpriv.padapter =padapter;
> + padapter->cmdpriv.padapter = padapter;
>
> if ((rtw_init_evt_priv(&padapter->evtpriv)) == _FAIL) {
> RT_TRACE(_module_os_intfs_c_, _drv_err_, ("\n Can't init evt_priv\n"));
> @@ -986,7 +986,7 @@ int _netdev_open(struct net_device *pnetdev)
>
> DBG_871X("MAC Address = "MAC_FMT"\n", MAC_ARG(pnetdev->dev_addr));
>
> - status =rtw_start_drv_threads(padapter);
> + status = rtw_start_drv_threads(padapter);
> if (status == _FAIL) {
> DBG_871X("Initialize driver software resource Failed!\n");
> goto netdev_open_error;
> @@ -1641,7 +1641,7 @@ int rtw_resume_process_wow(struct adapter *padapter)
> }
>
> /* Disable WOW, set H2C command */
> - poidparam.subcode =WOWLAN_DISABLE;
> + poidparam.subcode = WOWLAN_DISABLE;
> padapter->HalFunc.SetHwRegHandler(padapter, HW_VAR_WOWLAN, (u8 *)&poidparam);
>
> psta = rtw_get_stainfo(&padapter->stapriv, get_bssid(&padapter->mlmepriv));
> @@ -1705,7 +1705,7 @@ int rtw_resume_process_wow(struct adapter *padapter)
> DBG_871X_LEVEL(_drv_always_, "do not reset timer\n");
> }
>
> - pwrpriv->wowlan_mode =false;
> + pwrpriv->wowlan_mode = false;
>
> /* clean driver side wake up reason. */
> pwrpriv->wowlan_wake_reason = 0;
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/7b2a57c6f3eb01142a73e92124fdf06a7504e68e.1505052882.git.harshasharmaiitr%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
next prev parent reply other threads:[~2017-09-10 19:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-10 15:10 [PATCH 00/10] staging: rtl8723bs: Follow linux-kernel coding style Harsha Sharma
2017-09-10 15:15 ` [PATCH 01/10] staging: rtl8723bs: Add spaces around '=' Harsha Sharma
2017-09-10 19:44 ` Julia Lawall [this message]
2017-09-10 15:17 ` [PATCH 02/10] staging: rtl8723bs: Add spaces around '+', '|', '*' Harsha Sharma
2017-09-10 19:36 ` [Outreachy kernel] " Julia Lawall
2017-09-10 17:21 ` [PATCH 03/10] staging: rtl8723bs: Add spaces around '?', '==', '||', '!=' Harsha Sharma
2017-09-10 20:01 ` [Outreachy kernel] " Julia Lawall
2017-09-10 17:23 ` [PATCH 04/10] staging: rtl8723bs: Remove unnecessary spaces at the start of line Harsha Sharma
2017-09-10 20:33 ` [Outreachy kernel] " Julia Lawall
2017-09-10 17:29 ` [PATCH 05/10] staging: rtl8723bs: Add space between concatenated strings Harsha Sharma
2017-09-11 11:09 ` [Outreachy kernel] " Julia Lawall
2017-09-10 17:32 ` [PATCH 06/10] staging: rtl8723bs: Add space after ',' Harsha Sharma
2017-09-11 11:13 ` [Outreachy kernel] " Julia Lawall
2017-09-11 16:44 ` Greg KH
2017-09-10 17:34 ` [PATCH 07/10] staging: rtl8723bs: Removed unneccesary space Harsha Sharma
2017-09-11 16:46 ` Greg KH
2017-09-10 17:36 ` [PATCH 08/10] staging: rtl8723bs: Remove unnecessary space Harsha Sharma
2017-09-10 17:39 ` [PATCH 09/10] staging: rtl8723bs: Remove unneccesary braces and change position of open brace Harsha Sharma
2017-09-10 20:18 ` [PATCH] spelling.txt: Add "unnecessary" typo variants Joe Perches
2017-09-10 17:41 ` [PATCH 10/10] staging: rtl8723bs: Remove unnecessary blank lines Harsha Sharma
2017-09-12 10:08 ` [PATCH v2 07/10] staging: rtl8723bs: Remove unneccesary space Harsha Sharma
2017-09-12 10:22 ` [Outreachy kernel] " Julia Lawall
2017-09-12 10:33 ` [PATCH v3 07/10] staging: rtl8723bs: Remove unnecessary space Harsha Sharma
2017-09-12 13:35 ` [PATCH v2 06/10] staging: rtl8723bs: Add space after ',' Harsha Sharma
2017-09-12 20:41 ` Greg KH
2017-10-08 12:44 ` Harsha Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1709102143550.6548@hadrien \
--to=julia.lawall@lip6.fr \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=harshasharmaiitr@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®