From: Julia Lawall <julia.lawall@lip6.fr>
To: Harsha Sharma <harshasharmaiitr@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2 07/10] staging: rtl8723bs: Remove unneccesary space
Date: Tue, 12 Sep 2017 12:22:18 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1709121221390.3149@hadrien> (raw)
In-Reply-To: <1505210936-24971-1-git-send-email-harshasharmaiitr@gmail.com>
It'sa small detail, but perhaps you could fix the spelling of unnecessary
(1 c and 2 s's).
julia
On Tue, 12 Sep 2017, Harsha Sharma wrote:
> Remove space between function name and open parenthesis '('
> Remove space before ';', '++', ','
>
> Signed-off-by: Harsha Sharma <harshasharmaiitr@gmail.com>
> ---
> Change in v2:
> -Merge patches 07/10 and 08/10
>
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> index eb21821..61be2b8 100644
> --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> @@ -235,8 +235,8 @@
> MODULE_PARM_DESC(rtw_decrypt_phy_file, "Enable Decrypt PHY File");
>
> int _netdev_open(struct net_device *pnetdev);
> -int netdev_open (struct net_device *pnetdev);
> -static int netdev_close (struct net_device *pnetdev);
> +int netdev_open(struct net_device *pnetdev);
> +static int netdev_close(struct net_device *pnetdev);
>
> static uint loadparam(struct adapter *padapter, _nic_hdl pnetdev)
> {
> @@ -258,7 +258,7 @@ static uint loadparam(struct adapter *padapter, _nic_hdl pnetdev)
> if (registry_par->channel > 14)
> registry_par->channel = 1;
>
> - registry_par->vrtl_carrier_sense = (u8)rtw_vrtl_carrier_sense ;
> + registry_par->vrtl_carrier_sense = (u8)rtw_vrtl_carrier_sense;
> registry_par->vcs_type = (u8)rtw_vcs_type;
> registry_par->rts_thresh = (u16)rtw_rts_thresh;
> registry_par->frag_thresh = (u16)rtw_frag_thresh;
> @@ -607,7 +607,7 @@ u32 rtw_start_drv_threads(struct adapter *padapter)
> return _status;
> }
>
> -void rtw_stop_drv_threads (struct adapter *padapter)
> +void rtw_stop_drv_threads(struct adapter *padapter)
> {
> RT_TRACE(_module_os_intfs_c_, _drv_info_, ("+rtw_stop_drv_threads\n"));
>
> @@ -1228,7 +1228,7 @@ void rtw_dev_unload(struct adapter *padapter)
> DBG_871X("stop cmdthd timeout\n");
> break;
> } else {
> - cnt ++;
> + cnt++;
> DBG_871X("cmdthd is running(%d)\n", cnt);
> msleep(10);
> }
> @@ -1879,7 +1879,7 @@ int rtw_resume_common(struct adapter *padapter)
> pwrpriv->pno_in_resume = false;
> #endif
> }
> - DBG_871X_LEVEL(_drv_always_, "%s:%d in %d ms\n", __func__ , ret,
> + DBG_871X_LEVEL(_drv_always_, "%s:%d in %d ms\n", __func__, ret,
> jiffies_to_msecs(jiffies - start_time));
>
> return ret;
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1505210936-24971-1-git-send-email-harshasharmaiitr%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
next prev parent reply other threads:[~2017-09-12 10:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-10 15:10 [PATCH 00/10] staging: rtl8723bs: Follow linux-kernel coding style Harsha Sharma
2017-09-10 15:15 ` [PATCH 01/10] staging: rtl8723bs: Add spaces around '=' Harsha Sharma
2017-09-10 19:44 ` [Outreachy kernel] " Julia Lawall
2017-09-10 15:17 ` [PATCH 02/10] staging: rtl8723bs: Add spaces around '+', '|', '*' Harsha Sharma
2017-09-10 19:36 ` [Outreachy kernel] " Julia Lawall
2017-09-10 17:21 ` [PATCH 03/10] staging: rtl8723bs: Add spaces around '?', '==', '||', '!=' Harsha Sharma
2017-09-10 20:01 ` [Outreachy kernel] " Julia Lawall
2017-09-10 17:23 ` [PATCH 04/10] staging: rtl8723bs: Remove unnecessary spaces at the start of line Harsha Sharma
2017-09-10 20:33 ` [Outreachy kernel] " Julia Lawall
2017-09-10 17:29 ` [PATCH 05/10] staging: rtl8723bs: Add space between concatenated strings Harsha Sharma
2017-09-11 11:09 ` [Outreachy kernel] " Julia Lawall
2017-09-10 17:32 ` [PATCH 06/10] staging: rtl8723bs: Add space after ',' Harsha Sharma
2017-09-11 11:13 ` [Outreachy kernel] " Julia Lawall
2017-09-11 16:44 ` Greg KH
2017-09-10 17:34 ` [PATCH 07/10] staging: rtl8723bs: Removed unneccesary space Harsha Sharma
2017-09-11 16:46 ` Greg KH
2017-09-10 17:36 ` [PATCH 08/10] staging: rtl8723bs: Remove unnecessary space Harsha Sharma
2017-09-10 17:39 ` [PATCH 09/10] staging: rtl8723bs: Remove unneccesary braces and change position of open brace Harsha Sharma
2017-09-10 20:18 ` [PATCH] spelling.txt: Add "unnecessary" typo variants Joe Perches
2017-09-10 17:41 ` [PATCH 10/10] staging: rtl8723bs: Remove unnecessary blank lines Harsha Sharma
2017-09-12 10:08 ` [PATCH v2 07/10] staging: rtl8723bs: Remove unneccesary space Harsha Sharma
2017-09-12 10:22 ` Julia Lawall [this message]
2017-09-12 10:33 ` [PATCH v3 07/10] staging: rtl8723bs: Remove unnecessary space Harsha Sharma
2017-09-12 13:35 ` [PATCH v2 06/10] staging: rtl8723bs: Add space after ',' Harsha Sharma
2017-09-12 20:41 ` Greg KH
2017-10-08 12:44 ` Harsha Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1709121221390.3149@hadrien \
--to=julia.lawall@lip6.fr \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=harshasharmaiitr@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®