From: Julia Lawall <julia.lawall@lip6.fr>
To: Harsha Sharma <harshasharmaiitr@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 06/10] staging: rtl8723bs: Add space after ','
Date: Mon, 11 Sep 2017 13:13:18 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1709111313030.6947@hadrien> (raw)
In-Reply-To: <f38c5d1ba5518dce605cd9eb5d7adbdee3f7544d.1505052882.git.harshasharmaiitr@gmail.com>
On Sun, 10 Sep 2017, Harsha Sharma wrote:
> Space required after ','
>
> Signed-off-by: Harsha Sharma <harshasharmaiitr@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> index b320df8..ecb01cf 100644
> --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> @@ -45,7 +45,7 @@
> static int rtw_power_mgnt = 1;
> static int rtw_ips_mode = IPS_NORMAL;
> module_param(rtw_ips_mode, int, 0644);
> -MODULE_PARM_DESC(rtw_ips_mode,"The default IPS mode");
> +MODULE_PARM_DESC(rtw_ips_mode, "The default IPS mode");
>
> static int rtw_smart_ps = 2;
>
> @@ -185,7 +185,7 @@
>
> static uint rtw_max_roaming_times = 2;
> module_param(rtw_max_roaming_times, uint, 0644);
> -MODULE_PARM_DESC(rtw_max_roaming_times,"The max roaming times to try");
> +MODULE_PARM_DESC(rtw_max_roaming_times, "The max roaming times to try");
>
> module_param(rtw_mc2u_disable, int, 0644);
>
> @@ -206,10 +206,10 @@
> static int rtw_tx_pwr_by_rate = 0;
>
> module_param(rtw_tx_pwr_lmt_enable, int, 0644);
> -MODULE_PARM_DESC(rtw_tx_pwr_lmt_enable,"0:Disable, 1:Enable, 2: Depend on efuse");
> +MODULE_PARM_DESC(rtw_tx_pwr_lmt_enable, "0:Disable, 1:Enable, 2: Depend on efuse");
>
> module_param(rtw_tx_pwr_by_rate, int, 0644);
> -MODULE_PARM_DESC(rtw_tx_pwr_by_rate,"0:Disable, 1:Enable, 2: Depend on efuse");
> +MODULE_PARM_DESC(rtw_tx_pwr_by_rate, "0:Disable, 1:Enable, 2: Depend on efuse");
>
> char *rtw_phy_file_path = "";
> module_param(rtw_phy_file_path, charp, 0644);
> @@ -224,10 +224,10 @@
> /* BIT6 - RF_TXPWR_LMT, 0: non-support, 1: support */
> static int rtw_load_phy_file = (BIT2 | BIT6);
> module_param(rtw_load_phy_file, int, 0644);
> -MODULE_PARM_DESC(rtw_load_phy_file,"PHY File Bit Map");
> +MODULE_PARM_DESC(rtw_load_phy_file, "PHY File Bit Map");
> static int rtw_decrypt_phy_file = 0;
> module_param(rtw_decrypt_phy_file, int, 0644);
> -MODULE_PARM_DESC(rtw_decrypt_phy_file,"Enable Decrypt PHY File");
> +MODULE_PARM_DESC(rtw_decrypt_phy_file, "Enable Decrypt PHY File");
>
> int _netdev_open(struct net_device *pnetdev);
> int netdev_open (struct net_device *pnetdev);
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/f38c5d1ba5518dce605cd9eb5d7adbdee3f7544d.1505052882.git.harshasharmaiitr%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
next prev parent reply other threads:[~2017-09-11 11:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-10 15:10 [PATCH 00/10] staging: rtl8723bs: Follow linux-kernel coding style Harsha Sharma
2017-09-10 15:15 ` [PATCH 01/10] staging: rtl8723bs: Add spaces around '=' Harsha Sharma
2017-09-10 19:44 ` [Outreachy kernel] " Julia Lawall
2017-09-10 15:17 ` [PATCH 02/10] staging: rtl8723bs: Add spaces around '+', '|', '*' Harsha Sharma
2017-09-10 19:36 ` [Outreachy kernel] " Julia Lawall
2017-09-10 17:21 ` [PATCH 03/10] staging: rtl8723bs: Add spaces around '?', '==', '||', '!=' Harsha Sharma
2017-09-10 20:01 ` [Outreachy kernel] " Julia Lawall
2017-09-10 17:23 ` [PATCH 04/10] staging: rtl8723bs: Remove unnecessary spaces at the start of line Harsha Sharma
2017-09-10 20:33 ` [Outreachy kernel] " Julia Lawall
2017-09-10 17:29 ` [PATCH 05/10] staging: rtl8723bs: Add space between concatenated strings Harsha Sharma
2017-09-11 11:09 ` [Outreachy kernel] " Julia Lawall
2017-09-10 17:32 ` [PATCH 06/10] staging: rtl8723bs: Add space after ',' Harsha Sharma
2017-09-11 11:13 ` Julia Lawall [this message]
2017-09-11 16:44 ` [Outreachy kernel] " Greg KH
2017-09-10 17:34 ` [PATCH 07/10] staging: rtl8723bs: Removed unneccesary space Harsha Sharma
2017-09-11 16:46 ` Greg KH
2017-09-10 17:36 ` [PATCH 08/10] staging: rtl8723bs: Remove unnecessary space Harsha Sharma
2017-09-10 17:39 ` [PATCH 09/10] staging: rtl8723bs: Remove unneccesary braces and change position of open brace Harsha Sharma
2017-09-10 20:18 ` [PATCH] spelling.txt: Add "unnecessary" typo variants Joe Perches
2017-09-10 17:41 ` [PATCH 10/10] staging: rtl8723bs: Remove unnecessary blank lines Harsha Sharma
2017-09-12 10:08 ` [PATCH v2 07/10] staging: rtl8723bs: Remove unneccesary space Harsha Sharma
2017-09-12 10:22 ` [Outreachy kernel] " Julia Lawall
2017-09-12 10:33 ` [PATCH v3 07/10] staging: rtl8723bs: Remove unnecessary space Harsha Sharma
2017-09-12 13:35 ` [PATCH v2 06/10] staging: rtl8723bs: Add space after ',' Harsha Sharma
2017-09-12 20:41 ` Greg KH
2017-10-08 12:44 ` Harsha Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1709111313030.6947@hadrien \
--to=julia.lawall@lip6.fr \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=harshasharmaiitr@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®