mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: David Woodhouse <dwmw@amazon.co.uk>
Cc: arjan@linux.intel.com, karahmed@amazon.de, x86@kernel.org,
	linux-kernel@vger.kernel.org, tim.c.chen@linux.intel.com,
	bp@alien8.de, peterz@infradead.org, pbonzini@redhat.com,
	ak@linux.intel.com, torvalds@linux-foundation.org,
	gregkh@linux-foundation.org
Subject: Re: [PATCH 4/4] x86/pti: Do not enable PTI on fixed Intel processors
Date: Sat, 20 Jan 2018 21:08:11 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1801202107300.1998@nanos> (raw)
In-Reply-To: <1516449813-7654-5-git-send-email-dwmw@amazon.co.uk>

On Sat, 20 Jan 2018, David Woodhouse wrote:

> When they advertise the IA32_ARCH_CAPABILITIES MSR and it has the RDCL_NO
> bit set, they don't need KPTI either.

Do they exist today? And do we have documentation for that new MSR already?

Thanks,

	tglx

> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
> ---
>  arch/x86/kernel/cpu/common.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
> index e5d66e9..80572ae 100644
> --- a/arch/x86/kernel/cpu/common.c
> +++ b/arch/x86/kernel/cpu/common.c
> @@ -900,8 +900,13 @@ static void __init early_identify_cpu(struct cpuinfo_x86 *c)
>  
>  	setup_force_cpu_cap(X86_FEATURE_ALWAYS);
>  
> -	if (c->x86_vendor != X86_VENDOR_AMD)
> -		setup_force_cpu_bug(X86_BUG_CPU_MELTDOWN);
> +	if (c->x86_vendor != X86_VENDOR_AMD) {
> +		unsigned long ia32_cap = 0;
> +		if (cpu_has(c, X86_FEATURE_ARCH_CAPABILITIES))
> +			rdmsrl(MSR_IA32_ARCH_CAPABILITIES, ia32_cap);
> +		if (!(ia32_cap & ARCH_CAP_RDCL_NO))
> +			setup_force_cpu_bug(X86_BUG_CPU_MELTDOWN);
> +	}
>  
>  	setup_force_cpu_bug(X86_BUG_SPECTRE_V1);
>  	setup_force_cpu_bug(X86_BUG_SPECTRE_V2);
> -- 
> 2.7.4
> 
> 

  reply	other threads:[~2018-01-20 20:08 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-20 12:03 [PATCH 0/4] Basic Speculation Control feature support David Woodhouse
2018-01-20 12:03 ` [PATCH 1/4] x86/cpufeatures: Add Intel feature bits for Speculation Control David Woodhouse
2018-01-20 20:29   ` Borislav Petkov
2018-01-20 21:51   ` Steven Noonan
2018-01-20 21:57     ` David Woodhouse
2018-01-20 12:03 ` [PATCH 2/4] x86/cpufeatures: Add AMD feature bits for Prediction Command David Woodhouse
2018-01-21 12:16   ` Borislav Petkov
2018-01-21 12:22     ` David Woodhouse
2018-01-21 12:34       ` Borislav Petkov
2018-01-21 12:41         ` David Woodhouse
2018-01-21 17:36       ` Tom Lendacky
2018-01-21 17:51         ` Borislav Petkov
2018-01-20 12:03 ` [PATCH 3/4] x86/msr: Add definitions for new speculation control MSRs David Woodhouse
2018-01-20 12:03 ` [PATCH 4/4] x86/pti: Do not enable PTI on fixed Intel processors David Woodhouse
2018-01-20 20:08   ` Thomas Gleixner [this message]
2018-01-20 20:13     ` Thomas Gleixner
2018-01-20 20:13     ` Woodhouse, David
2018-01-20 20:13     ` Woodhouse, David

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1801202107300.1998@nanos \
    --to=tglx@linutronix.de \
    --cc=ak@linux.intel.com \
    --cc=arjan@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=dwmw@amazon.co.uk \
    --cc=gregkh@linux-foundation.org \
    --cc=karahmed@amazon.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tim.c.chen@linux.intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®