* [PATCH] RFC: bus: fix semicolon.cocci warnings
@ 2018-06-15 17:59 Julia Lawall
2018-06-15 18:06 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2018-06-15 17:59 UTC (permalink / raw)
To: Linus Walleij; +Cc: kbuild-all, linux-kernel
From: kbuild test robot <fengguang.wu@intel.com>
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
Fixes: 7d8c3a62781b ("RFC: bus: 96boards Low-Speed Connector")
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---
tree:
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-integrator.git ultra96
head: 27803f286226e1b5b5893aabfd55feec08b73bae
commit: 7d8c3a62781bbd8b42119b3af2c90f4d9eef3748 [20/21] RFC: bus:
96boards Low-Speed Connector
96boards-secure96.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/bus/96boards-mezzanines/96boards-secure96.c
+++ b/drivers/bus/96boards-mezzanines/96boards-secure96.c
@@ -223,7 +223,7 @@ out_unreg_leds:
platform_device_unregister(sec->leds_device);
for (i = 0; i < ARRAY_SIZE(ledinfos); i++) {
mezzanine_ls_put_gpiod(ls, sec->secure96_leds[i].gpiod);
- };
+ }
return ERR_PTR(ret);
}
EXPORT_SYMBOL_GPL(secure96_populate);
@@ -244,6 +244,6 @@ void secure96_depopulate(void *data)
platform_device_unregister(sec->leds_device);
for (i = 0; i < ARRAY_SIZE(ledinfos); i++) {
mezzanine_ls_put_gpiod(sec->ls, sec->secure96_leds[i].gpiod);
- };
+ }
}
EXPORT_SYMBOL_GPL(secure96_depopulate);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] RFC: bus: fix semicolon.cocci warnings
2018-06-15 17:59 [PATCH] RFC: bus: fix semicolon.cocci warnings Julia Lawall
@ 2018-06-15 18:06 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2018-06-15 18:06 UTC (permalink / raw)
To: Julia Lawall, Linus Walleij; +Cc: kbuild-all, linux-kernel
On Fri, 2018-06-15 at 19:59 +0200, Julia Lawall wrote:
> From: kbuild test robot <fengguang.wu@intel.com>
>
> Remove unneeded semicolon.
[]
> +++ b/drivers/bus/96boards-mezzanines/96boards-secure96.c
> @@ -223,7 +223,7 @@ out_unreg_leds:
> platform_device_unregister(sec->leds_device);
> for (i = 0; i < ARRAY_SIZE(ledinfos); i++) {
> mezzanine_ls_put_gpiod(ls, sec->secure96_leds[i].gpiod);
> - };
> + }
> return ERR_PTR(ret);
> }
> EXPORT_SYMBOL_GPL(secure96_populate);
> @@ -244,6 +244,6 @@ void secure96_depopulate(void *data)
> platform_device_unregister(sec->leds_device);
> for (i = 0; i < ARRAY_SIZE(ledinfos); i++) {
> mezzanine_ls_put_gpiod(sec->ls, sec->secure96_leds[i].gpiod);
> - };
> + }
> }
> EXPORT_SYMBOL_GPL(secure96_depopulate);
While these are clearly correct, perhaps it would
be better to remove the braces too.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-15 18:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-15 17:59 [PATCH] RFC: bus: fix semicolon.cocci warnings Julia Lawall
2018-06-15 18:06 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®