mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] media: place CEC menu before MEDIA_SUPPORT
Date: Tue, 28 Apr 2020 16:06:26 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.2004281600310.12370@ramsan.of.borg> (raw)
In-Reply-To: <32565659d6778e92bd9ac7d17622149bd95973c5.1586944045.git.mchehab+huawei@kernel.org>

 	Hi Mauro,

On Wed, 15 Apr 2020, Mauro Carvalho Chehab wrote:
> The only item that opens at the CEC Kconfig menu is related
> to Remote Controller. Also, its support should not depend on
> media support, so it makes sense to keep both RC and CEC together.
>
> After this change, the main media menus that are visible
> under "Device Drivers" menu are:
>
> 	<*> Remote Controller support  --->
> 	[ ] HDMI CEC RC integration (NEW)
> 	< > HDMI CEC drivers
> 	<M> Multimedia support  --->
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

Thanks for your patch, which is now commit 46d2a3b964ddbe63 ("media:
place CEC menu before MEDIA_SUPPORT") in media/master.

> --- a/drivers/media/cec/Kconfig
> +++ b/drivers/media/cec/Kconfig
> @@ -11,3 +20,14 @@ config CEC_PIN_ERROR_INJ
> 	depends on CEC_PIN && DEBUG_FS
> 	help
> 	  This option enables CEC error injection using debugfs.
> +
> +config MEDIA_CEC_SUPPORT
> +	bool
> +	prompt "HDMI CEC drivers"

This is now visible in a media-less and head-less kernel...

> +	default y if !MEDIA_SUPPORT_FILTER

... and in that case even defaults to y:

     $ grep MEDIA .config
     CONFIG_MEDIA_CEC_SUPPORT=y
     # CONFIG_MEDIA_SUPPORT is not set

Is that intentional?

> +	help
> +	  Enable support for HDMI CEC (Consumer Electronics Control),
> +	  which is an optional HDMI feature.
> +
> +	  Say Y when you have an HDMI receiver, transmitter or a USB CEC
> +	  adapter that supports HDMI CEC.
> --

Gr{oetje,eeting}s,

 						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
 							    -- Linus Torvalds

           reply	other threads:[~2020-04-28 14:06 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <32565659d6778e92bd9ac7d17622149bd95973c5.1586944045.git.mchehab+huawei@kernel.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.2004281600310.12370@ramsan.of.borg \
    --to=geert@linux-m68k.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab+huawei@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®