Re: [PATCH 2/4] media: place CEC menu before MEDIA_SUPPORT

Re: [PATCH 2/4] media: place CEC menu before MEDIA_SUPPORT

[Geert Uytterhoeven]

 	Hi Mauro,

On Wed, 15 Apr 2020, Mauro Carvalho Chehab wrote:
> The only item that opens at the CEC Kconfig menu is related
> to Remote Controller. Also, its support should not depend on
> media support, so it makes sense to keep both RC and CEC together.
>
> After this change, the main media menus that are visible
> under "Device Drivers" menu are:
>
> 	<*> Remote Controller support  --->
> 	[ ] HDMI CEC RC integration (NEW)
> 	< > HDMI CEC drivers
> 	<M> Multimedia support  --->
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

Thanks for your patch, which is now commit 46d2a3b964ddbe63 ("media:
place CEC menu before MEDIA_SUPPORT") in media/master.

> --- a/drivers/media/cec/Kconfig
> +++ b/drivers/media/cec/Kconfig
> @@ -11,3 +20,14 @@ config CEC_PIN_ERROR_INJ
> 	depends on CEC_PIN && DEBUG_FS
> 	help
> 	  This option enables CEC error injection using debugfs.
> +
> +config MEDIA_CEC_SUPPORT
> +	bool
> +	prompt "HDMI CEC drivers"

This is now visible in a media-less and head-less kernel...

> +	default y if !MEDIA_SUPPORT_FILTER

... and in that case even defaults to y:

     $ grep MEDIA .config
     CONFIG_MEDIA_CEC_SUPPORT=y
     # CONFIG_MEDIA_SUPPORT is not set

Is that intentional?

> +	help
> +	  Enable support for HDMI CEC (Consumer Electronics Control),
> +	  which is an optional HDMI feature.
> +
> +	  Say Y when you have an HDMI receiver, transmitter or a USB CEC
> +	  adapter that supports HDMI CEC.
> --

Gr{oetje,eeting}s,

 						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
 							    -- Linus Torvalds