mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-mips@vger.kernel.org,
	 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	 open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] MIPS: SiByte: Fix missing function prototypes
Date: Thu, 19 Nov 2026 08:31:50 +0000 (GMT)	[thread overview]
Message-ID: <alpine.DEB.2.21.2611190811510.54328@angie.orcam.me.uk> (raw)
In-Reply-To: <b6546264-4c51-45e4-9728-a433527fb355@gmail.com>

On Wed, 18 Nov 2026, Florian Fainelli wrote:

> > >   static inline int __maybe_unused bcm1250_m3_war(void)
> > >   {
> > > -	if (IS_ENABLED(CONFIG_SB1_PASS_2_WORKAROUNDS))
> > > -		return sb1250_m3_workaround_needed();
> > > +#ifdef CONFIG_SB1_PASS_2_WORKAROUNDS
> > > +	return sb1250_m3_workaround_needed();
> > > +#else
> > >   	return 0;
> > > +#endif
> > >   }
> > 
> >   It seems a style regression, why is this change needed?
> 
> The declaration is wrapped under #ifdef CONFIG_SB1_PASS_2_WORKAROUNDS, which
> would hide the prototype when the option was disabled. The if (IS_ENABLED()
> would not compile in that case since we would have lacked a visible
> declaration. We could keep this and just make the prototype unconditionally
> visible instead.

 I've pondered it a bit more and I'm not entirely happy with the use of a 
platform header in generic code in the first place.  Would <asm/bugs.h> be 
a better place for the prototype?

  Maciej

  reply	other threads:[~2026-11-19  8:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 19:19 Florian Fainelli
2026-11-17 16:16 ` Thomas Bogendoerfer
2026-11-18  1:57 ` Maciej W. Rozycki
2026-11-19  1:13   ` Florian Fainelli
2026-11-19  8:31     ` Maciej W. Rozycki [this message]
2026-11-19 17:41       ` Florian Fainelli
2026-11-19 15:07     ` Thomas Bogendoerfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.2611190811510.54328@angie.orcam.me.uk \
    --to=macro@orcam.me.uk \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®