From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "Maciej W. Rozycki" <macro@orcam.me.uk>,
linux-mips@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] MIPS: SiByte: Fix missing function prototypes
Date: Thu, 19 Nov 2026 16:07:35 +0100 [thread overview]
Message-ID: <av8Qt2gJyDRJntEL@alpha.franken.de> (raw)
In-Reply-To: <b6546264-4c51-45e4-9728-a433527fb355@gmail.com>
On Wed, Nov 18, 2026 at 05:13:26PM -0800, Florian Fainelli wrote:
> On 11/17/26 17:57, Maciej W. Rozycki wrote:
> > On Fri, 13 Nov 2026, Florian Fainelli wrote:
> >
> > > The SB1250 SWARM build reports missing prototypes for platform time
> > > initialization, SoC setup, IRQ and SMP helpers, and both RTC backends.
> >
> > Thank you for doing this. I've meant to for a long time, but have been
> > distracted with higher priority stuff.
> >
> > > static inline int __maybe_unused bcm1250_m3_war(void)
> > > {
> > > - if (IS_ENABLED(CONFIG_SB1_PASS_2_WORKAROUNDS))
> > > - return sb1250_m3_workaround_needed();
> > > +#ifdef CONFIG_SB1_PASS_2_WORKAROUNDS
> > > + return sb1250_m3_workaround_needed();
> > > +#else
> > > return 0;
> > > +#endif
> > > }
> >
> > It seems a style regression, why is this change needed?
>
> The declaration is wrapped under #ifdef CONFIG_SB1_PASS_2_WORKAROUNDS, which
> would hide the prototype when the option was disabled. The if (IS_ENABLED()
> would not compile in that case since we would have lacked a visible
> declaration. We could keep this and just make the prototype unconditionally
> visible instead.
>
> Thomas, I can send a v3 as an incremental fixup or complete replacement?
incremental fixup please
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2026-11-19 15:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 19:19 Florian Fainelli
2026-11-17 16:16 ` Thomas Bogendoerfer
2026-11-18 1:57 ` Maciej W. Rozycki
2026-11-19 1:13 ` Florian Fainelli
2026-11-19 8:31 ` Maciej W. Rozycki
2026-11-19 17:41 ` Florian Fainelli
2026-11-19 15:07 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av8Qt2gJyDRJntEL@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=macro@orcam.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®