mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jan Beulich <JBeulich@novell.com>
Cc: a.p.zijlstra@chello.nl, mingo@elte.hu, tglx@linutronix.de,
	mingo@redhat.com, npiggin@suse.de, linux-kernel@vger.kernel.org,
	hpa@zytor.com
Subject: Re: [tip:core/locking] locking, x86: Slightly shorten  __ticket_spin_trylock()
Date: Wed, 2 Dec 2009 09:05:00 -0800 (PST)	[thread overview]
Message-ID: <alpine.LFD.2.00.0912020857270.2872@localhost.localdomain> (raw)
In-Reply-To: <alpine.LFD.2.00.0912020853240.2872@localhost.localdomain>



On Wed, 2 Dec 2009, Linus Torvalds wrote:
> 
> So stop making excuses. Just admit that 'bool' was wrong, and you made a 
> fundamental mistake in choosing it. The fact is, the compiler can do 
> whatever the hell it does, which is not necessarily sensible with any 
> other type. 'bool' really is special.

Btw, even if gcc just treats 'bool' as 'char' (which is the sane thing to 
do on x86 anyway - I don't see why it should ever do anything else), we 
actually mess up in the kernel and make that type confusion even worse.

Do this:

	git grep typedef.*bool

and then do this:

	git grep 'define bool'

and then sit down and cry silently.

		Linus

  reply	other threads:[~2009-12-02 17:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-27 15:09 [PATCH] x86: slightly " Jan Beulich
2009-12-02 10:45 ` [tip:core/locking] locking, x86: Slightly " tip-bot for Jan Beulich
2009-12-02 13:29   ` Ingo Molnar
2009-12-02 14:06     ` Jan Beulich
2009-12-02 14:12       ` Avi Kivity
2009-12-02 14:25         ` Jan Beulich
2009-12-02 14:36           ` Avi Kivity
2009-12-02 14:59             ` Jan Beulich
2009-12-02 14:21       ` Ingo Molnar
2009-12-02 14:57         ` Jan Beulich
2009-12-02 15:33           ` Linus Torvalds
2009-12-02 15:26   ` Linus Torvalds
2009-12-02 16:24     ` Jan Beulich
2009-12-02 16:56       ` Linus Torvalds
2009-12-02 17:05         ` Linus Torvalds [this message]
2009-12-02 17:23           ` H. Peter Anvin
2009-12-02 17:48             ` Linus Torvalds
2009-12-02 17:58               ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0912020857270.2872@localhost.localdomain \
    --to=torvalds@linux-foundation.org \
    --cc=JBeulich@novell.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=npiggin@suse.de \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®