mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, Greg KH <gregkh@suse.de>,
	Rik van Riel <riel@redhat.com>, John Stoffel <john@stoffel.org>,
	Hedi Berriche <hedi@sgi.com>, Mike Travis <travis@sgi.com>,
	Ingo Molnar <mingo@elte.hu>, Jack Steiner <steiner@sgi.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Robin Holt <holt@sgi.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Patch 1/1] init: Provide a kernel start parameter to increase pid_max v2
Date: Sun, 25 Apr 2010 10:15:07 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.2.00.1004251002480.3739@i5.linux-foundation.org> (raw)
In-Reply-To: <20100425071606.GB1275@ucw.cz>



On Sun, 25 Apr 2010, Pavel Machek wrote:
> 
> Issue with max_pids is that it can break userspace, right?

Iirc, some _really_ old code used 'short' for pid_t, and we wanted to be 
really safe when we raised the limits. 

I seriously doubt we need to worry about old binaries like that on any 16+ 
CPU machines, though.

The other issue is just the size of the pidmap[] array. Instead of walking 
all the processes to see "is this pid in use" (like I think the original 
Linux kernel did), we have a bitmap of used pids. When you raise pid_max, 
that bitmap obviously still needs to be big enough. Right now we allocate 
that statically (rather than growing it dynamically), so we end up having 
a _hard_ limit of PID_MAX_LIMIT too.

On 32-bit, I think that still maximum limit ends up being basically 32767. 
So again, on a _legacy_ system, you end up being limited in the number of 
pid_t entries.

				Linus

  reply	other threads:[~2010-04-25 17:16 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-21  1:40 [Patch 1/1] init: Provide a kernel start parameter to increase pid_max Mike Travis
2010-04-21  1:52 ` [Patch 1/1] init: Provide a kernel start parameter to increase pid_max v2 Mike Travis
2010-04-21  9:23   ` Alan Cox
2010-04-21 16:59     ` Hedi Berriche
2010-04-21 17:18       ` Rik van Riel
2010-04-21 17:54         ` Mike Travis
2010-04-21 19:14         ` John Stoffel
2010-04-21 19:33           ` Hedi Berriche
2010-04-21 20:10             ` John Stoffel
2010-04-21 22:24               ` Greg KH
2010-04-21 22:49                 ` Rik van Riel
2010-04-21 23:22                   ` Greg KH
2010-04-22  9:28                     ` Alan Cox
2010-04-22 12:58                       ` Jack Steiner
2010-04-22 13:57                       ` Robin Holt
2010-04-22 14:48                       ` Linus Torvalds
2010-04-22 17:08                         ` Robin Holt
2010-04-22 18:10                           ` John Stoffel
2010-04-22 20:35                           ` Andrew Morton
2010-04-25  7:16                         ` Pavel Machek
2010-04-25 17:15                           ` Linus Torvalds [this message]
2010-04-25 17:27                             ` Linus Torvalds
2010-04-25 12:13                               ` Pavel Machek
2010-04-26 19:48                             ` [Patch 1/1] init: Provide a kernel start parameter to increase pid_max v3 Mike Travis
2010-04-26 20:46                               ` Greg KH
2010-04-27  0:43                                 ` Mike Travis
2010-04-27  0:42                               ` [Patch 1/1] init: Increase pid_max based on num_possible_cpus v4 Mike Travis
2010-04-21 17:58       ` [Patch 1/1] init: Provide a kernel start parameter to increase pid_max v2 Alan Cox
2010-04-21 19:12         ` Hedi Berriche
2010-04-21 19:51           ` Greg KH
2010-04-21 20:12             ` Hedi Berriche
2010-04-21 22:05           ` Jack Steiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1004251002480.3739@i5.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=gregkh@suse.de \
    --cc=hedi@sgi.com \
    --cc=holt@sgi.com \
    --cc=john@stoffel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=pavel@ucw.cz \
    --cc=riel@redhat.com \
    --cc=steiner@sgi.com \
    --cc=travis@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®