* Re: [tip:irq/core] genirq: Add IRQCHIP_SET_TYPE_MASKED flag [not found] <tip-d4d5e08960844a062da8387ee5f16ca7a33200d0@git.kernel.org> @ 2011-02-21 13:17 ` Lars-Peter Clausen 2011-02-21 13:18 ` Thomas Gleixner 0 siblings, 1 reply; 2+ messages in thread From: Lars-Peter Clausen @ 2011-02-21 13:17 UTC (permalink / raw) To: linux-kernel, mingo, hpa, linus.walleij, tglx, lars; +Cc: linux-tip-commits > @@ -588,11 +596,13 @@ int __irq_set_trigger(struct irq_desc *desc, unsigned int irq, > > if (chip != desc->irq_data.chip) > irq_chip_set_defaults(desc->irq_data.chip); > - return 0; > + ret = 0; I've just tested the patch and noticed that a 'break' is missing here. > default: > pr_err("setting trigger mode %lu for irq %u failed (%pF)\n", > flags, irq, chip->irq_set_type); > } > + if (unmask) > + unmask_irq(desc); > return ret; > } > > @@ -669,7 +679,7 @@ again: > > #ifdef CONFIG_SMP > /* > - * Check whether we need to change the affinity of the interrupt thread. > + * Check whether we need to chasnge the affinity of the interrupt thread. > */ > static void > irq_thread_check_affinity(struct irq_desc *desc, struct irqaction *action) ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [tip:irq/core] genirq: Add IRQCHIP_SET_TYPE_MASKED flag 2011-02-21 13:17 ` [tip:irq/core] genirq: Add IRQCHIP_SET_TYPE_MASKED flag Lars-Peter Clausen @ 2011-02-21 13:18 ` Thomas Gleixner 0 siblings, 0 replies; 2+ messages in thread From: Thomas Gleixner @ 2011-02-21 13:18 UTC (permalink / raw) To: Lars-Peter Clausen Cc: linux-kernel, mingo, hpa, linus.walleij, linux-tip-commits On Mon, 21 Feb 2011, Lars-Peter Clausen wrote: > > @@ -588,11 +596,13 @@ int __irq_set_trigger(struct irq_desc *desc, unsigned > int irq, > > > > if (chip != desc->irq_data.chip) > > irq_chip_set_defaults(desc->irq_data.chip); > > - return 0; > > + ret = 0; > > I've just tested the patch and noticed that a 'break' is missing here. Grmbl. Thanks for catching that ! Thanks, tglx ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-21 13:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <tip-d4d5e08960844a062da8387ee5f16ca7a33200d0@git.kernel.org>
2011-02-21 13:17 ` [tip:irq/core] genirq: Add IRQCHIP_SET_TYPE_MASKED flag Lars-Peter Clausen
2011-02-21 13:18 ` Thomas Gleixner
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®