mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Benjamin Coddington <bcodding@redhat.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Ian Kent <ikent@redhat.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	David Howells <dhowells@redhat.com>,
	Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Oleg Nesterov <onestero@redhat.com>,
	Trond Myklebust <trond.myklebust@primarydata.com>,
	Al Viro <viro@ZenIV.linux.org.uk>,
	Jeff Layton <jeff.layton@primarydata.com>
Subject: Re: [RFC PATCH 5/8] KEYS: exec request-key within the requesting task's init namespace
Date: Tue, 24 Feb 2015 16:41:04 -0800 (PST)	[thread overview]
Message-ID: <alpine.OSX.2.19.9992.1502241604080.486@planck.local> (raw)
In-Reply-To: <20150224153329.GA2415@fieldses.org>

On Tue, 24 Feb 2015, J. Bruce Fields wrote:

> On Mon, Feb 23, 2015 at 05:22:12PM -0800, Benjamin Coddington wrote:
> > That sounds a lot closer to some of the work I've been doing to see if I can
> > come up with a way to solve the "where's the namespace I need?" problem.
> >
> > I agree with Greg's very early comments that the easiest way to determine
> > which namespace context a process should use is to keep it as a copy of
> > the task -- and the place that copy should be done is fork().
>
> So you're suggesting that the key_agent could be that copy?  But:
>
> > ... If not, then the calling process itself is forked/execve-ed into a
> > new persistent key_agent that is installed on the calling process'
> > keyrings just like a key, and with the same lifetime and GC
> > expectations of a key.
> >
> > A key_agent is a user-space process...
>
> If the key_agent can die before it's needed, then we have to keep around
> some other context information to allow regenerating a new one.  So what
> is that piece of information?  Aren't we back where we started?

Yes.  It would seem to make sense then to keep a copy of task which would be
used to create the user-space key_agent.  If that's the standard behavior,
it doubles the number of tasks for the average use case.  The average use
case (I anticipate) would be to just always fork the caller if a key_agent
is not found.

It would probably make sense provide the key_agent_type the option of
binding a key_agent reference task to another structure -- like a mount.
And, if so, that reservied reference task would be used to create/re-create the
user-space key_agent.  The trouble there is how to have the caller
communicate the object bound to the task.. a reference to the object could
be guessed, which would give any caller access to a that reserved task..

In order to keep further verbose speculation to a minimum, I'll say: good
point.. there may be a way to authorize the usage of a reference task by
means of the possession of an authkey.  I'll keep hacking at this.

Ben

  reply	other threads:[~2015-02-25  0:41 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-05  2:33 [RFC PATCH 0/8] v3 contained usermode helper execution Ian Kent
2015-02-05  2:33 ` [RFC PATCH 1/8] nsproxy - refactor setns() Ian Kent
2015-02-05  2:34 ` [RFC PATCH 2/8] kmod - rename call_usermodehelper() flags parameter Ian Kent
2015-02-05  2:34 ` [RFC PATCH 3/8] kmod - teach call_usermodehelper() to use a namespace Ian Kent
2015-02-06 12:08   ` Jeff Layton
2015-02-08  3:07     ` Ian Kent
2015-02-08 15:22       ` Jeff Layton
2015-02-08 18:12       ` Oleg Nesterov
2015-02-08 19:00   ` Oleg Nesterov
2015-02-09  1:43     ` Ian Kent
2015-02-09 16:03       ` Oleg Nesterov
2015-02-10  0:08         ` Ian Kent
2015-02-10 16:55           ` Oleg Nesterov
2015-02-11  0:40             ` Ian Kent
2015-02-16  6:16             ` Ian Kent
2015-02-16 17:13               ` Oleg Nesterov
2015-02-16 18:24                 ` Oleg Nesterov
2015-02-18  2:09                   ` Ian Kent
2015-02-18  1:42                 ` Ian Kent
2015-02-05  2:34 ` [RFC PATCH 4/8] KEYS - rename call_usermodehelper_keys() flags parameter Ian Kent
2015-02-05  2:34 ` [RFC PATCH 5/8] KEYS: exec request-key within the requesting task's init namespace Ian Kent
2015-02-05  2:34 ` [RFC PATCH 6/8] nfsd - use namespace if not executing in " Ian Kent
2015-02-18 17:37   ` J. Bruce Fields
2015-02-05  2:34 ` [RFC PATCH 7/8] nfs - cache_lib " Ian Kent
2015-02-05  2:34 ` [RFC PATCH 8/8] nfs - objlayout " Ian Kent
2015-02-05 15:01 ` [RFC PATCH 2/8] kmod - rename call_usermodehelper() flags parameter David Howells
2015-02-06  0:01   ` Ian Kent
2015-02-05 15:14 ` [RFC PATCH 5/8] KEYS: exec request-key within the requesting task's init namespace David Howells
2015-02-06  1:47   ` Ian Kent
2015-02-18 17:06     ` J. Bruce Fields
2015-02-18 17:31       ` J. Bruce Fields
2015-02-18 20:59         ` J. Bruce Fields
2015-02-19  0:39           ` Ian Kent
2015-02-19  1:31             ` J. Bruce Fields
2015-02-19  3:18               ` Ian Kent
2015-02-20  9:33               ` Ian Kent
2015-02-20 17:25                 ` J. Bruce Fields
2015-02-20 18:07                   ` Eric W. Biederman
2015-02-20 18:58                     ` Jeff Layton
2015-02-20 19:05                     ` J. Bruce Fields
2015-02-21  3:58                       ` Ian Kent
2015-02-23 14:52                         ` J. Bruce Fields
2015-02-24  0:50                           ` Ian Kent
2015-02-24  1:22                             ` Benjamin Coddington
2015-02-24  8:01                               ` Ian Kent
2015-02-24 15:33                               ` J. Bruce Fields
2015-02-25  0:41                                 ` Benjamin Coddington [this message]
2015-02-05 15:24 ` [RFC PATCH 3/8] kmod - teach call_usermodehelper() to use a namespace David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.OSX.2.19.9992.1502241604080.486@planck.local \
    --to=bcodding@redhat.com \
    --cc=bfields@fieldses.org \
    --cc=dhowells@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=ikent@redhat.com \
    --cc=jeff.layton@primarydata.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=onestero@redhat.com \
    --cc=trond.myklebust@primarydata.com \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome