* [PATCH 1/1] staging: nvec: check return value
@ 2019-12-18 5:56 Xidong Wang
2019-12-19 17:40 ` Marc Dietrich
0 siblings, 1 reply; 2+ messages in thread
From: Xidong Wang @ 2019-12-18 5:56 UTC (permalink / raw)
To: Xidong Wang, Marc Dietrich, Greg Kroah-Hartman
Cc: ac100, linux-tegra, devel, linux-kernel
In nvec_kbd_probe(), the return value of devm_input_allocate_device()
should be checked before it is used.
Signed-off-by: Xidong Wang <wangxidong_97@163.com>
---
drivers/staging/nvec/nvec_kbd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/nvec/nvec_kbd.c b/drivers/staging/nvec/nvec_kbd.c
index 01dbb66..386d619 100644
--- a/drivers/staging/nvec/nvec_kbd.c
+++ b/drivers/staging/nvec/nvec_kbd.c
@@ -123,6 +123,8 @@ static int nvec_kbd_probe(struct platform_device *pdev)
keycodes[j++] = extcode_tab_us102[i];
idev = devm_input_allocate_device(&pdev->dev);
+ if (!idev)
+ return -ENOMEM;
idev->name = "nvec keyboard";
idev->phys = "nvec";
idev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_REP) | BIT_MASK(EV_LED);
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] staging: nvec: check return value
2019-12-18 5:56 [PATCH 1/1] staging: nvec: check return value Xidong Wang
@ 2019-12-19 17:40 ` Marc Dietrich
0 siblings, 0 replies; 2+ messages in thread
From: Marc Dietrich @ 2019-12-19 17:40 UTC (permalink / raw)
To: Xidong Wang
Cc: Marc Dietrich, Greg Kroah-Hartman, ac100, linux-tegra, devel,
linux-kernel
Hello Xidong,
On Wed, 18 Dec 2019, Xidong Wang wrote:
> In nvec_kbd_probe(), the return value of devm_input_allocate_device()
> should be checked before it is used.
>
> Signed-off-by: Xidong Wang <wangxidong_97@163.com>
looks good to me. Thanks!
Acked-by: Marc Dietrich <marvin24@gmx.de>
> ---
> drivers/staging/nvec/nvec_kbd.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/nvec/nvec_kbd.c b/drivers/staging/nvec/nvec_kbd.c
> index 01dbb66..386d619 100644
> --- a/drivers/staging/nvec/nvec_kbd.c
> +++ b/drivers/staging/nvec/nvec_kbd.c
> @@ -123,6 +123,8 @@ static int nvec_kbd_probe(struct platform_device *pdev)
> keycodes[j++] = extcode_tab_us102[i];
>
> idev = devm_input_allocate_device(&pdev->dev);
> + if (!idev)
> + return -ENOMEM;
> idev->name = "nvec keyboard";
> idev->phys = "nvec";
> idev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_REP) | BIT_MASK(EV_LED);
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-19 17:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-18 5:56 [PATCH 1/1] staging: nvec: check return value Xidong Wang
2019-12-19 17:40 ` Marc Dietrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®