* [PATCH] sched/fair: remove the wrong check is_vm_hugetlb_page
@ 2026-07-23 7:34 Huang Shijie
2026-07-23 11:30 ` Huang Shijie
0 siblings, 1 reply; 2+ messages in thread
From: Huang Shijie @ 2026-07-23 7:34 UTC (permalink / raw)
To: mingo, peterz, juri.lelli, vincent.guittot
Cc: zhongyuan, fangbaoshun, yingzhiwei, dietmar.eggemann, rostedt,
bsegall, mgorman, vschneid, kprateek.nayak, linux-kernel,
Huang Shijie
In vma_migratable(), we do strictly check with hugetlb mapping:
hugepage_migration_supported()
When vma_migratable() returns true, it means the hugetlb mapping
passes the hugepage_migration_supported(). So we should not
skip this hugetlb mapping.
Remove the wrong is_vm_hugetlb_page() check in task_numa_work().
Signed-off-by: Huang Shijie <huangsj@hygon.cn>
---
kernel/sched/fair.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index d78467ec6ee1..0582e0cfba36 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -4167,7 +4167,7 @@ static void task_numa_work(struct callback_head *work)
for (; vma; vma = vma_next(&vmi)) {
if (!vma_migratable(vma) || !vma_policy_mof(vma) ||
- is_vm_hugetlb_page(vma) || (vma->vm_flags & VM_MIXEDMAP)) {
+ (vma->vm_flags & VM_MIXEDMAP)) {
trace_sched_skip_vma_numa(mm, vma, NUMAB_SKIP_UNSUITABLE);
continue;
}
--
2.53.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] sched/fair: remove the wrong check is_vm_hugetlb_page
2026-07-23 7:34 [PATCH] sched/fair: remove the wrong check is_vm_hugetlb_page Huang Shijie
@ 2026-07-23 11:30 ` Huang Shijie
0 siblings, 0 replies; 2+ messages in thread
From: Huang Shijie @ 2026-07-23 11:30 UTC (permalink / raw)
To: mingo, peterz, juri.lelli, vincent.guittot
Cc: zhongyuan, fangbaoshun, yingzhiwei, dietmar.eggemann, rostedt,
bsegall, mgorman, vschneid, kprateek.nayak, linux-kernel
On Thu, Jul 23, 2026 at 03:34:49PM +0800, Huang Shijie wrote:
> +++ b/kernel/sched/fair.c
> @@ -4167,7 +4167,7 @@ static void task_numa_work(struct callback_head *work)
>
> for (; vma; vma = vma_next(&vmi)) {
> if (!vma_migratable(vma) || !vma_policy_mof(vma) ||
> - is_vm_hugetlb_page(vma) || (vma->vm_flags & VM_MIXEDMAP)) {
> + (vma->vm_flags & VM_MIXEDMAP)) {
> trace_sched_skip_vma_numa(mm, vma, NUMAB_SKIP_UNSUITABLE);
> continue;
> }
> --
> 2.53.0
>
Please ignore this patch. The code disables the hugetlb migration on purpose.
Thanks
Huang Shijie
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-23 11:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-23 7:34 [PATCH] sched/fair: remove the wrong check is_vm_hugetlb_page Huang Shijie
2026-07-23 11:30 ` Huang Shijie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®