[PATCH v4] auxdisplay: arm-charlcd: Use DEFINE_SIMPLE_DEV_PM_OPS for power management

[PATCH v4] auxdisplay: arm-charlcd: Use DEFINE_SIMPLE_DEV_PM_OPS for power management

[Li Jun]

Replace the manually defined dev_pm_ops structure with the
DEFINE_SIMPLE_DEV_PM_OPS macro to simplify the power management code.
This macro automatically handles CONFIG_PM_SLEEP configuration
and generates freeze/thaw/poweroff/restore callbacks, reducing
boilerplate code.

Changes:
-Replace SIMPLE_DEV_PM_OPS() in v1 v2 with DEFINE_SIMPLE_DEV_PM_OPS() for pm.
-Corrected grammar errors in v1 comment.

Signed-off-by: Li Jun <lijun01@kylinos.cn>
---
 drivers/auxdisplay/arm-charlcd.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/auxdisplay/arm-charlcd.c b/drivers/auxdisplay/arm-charlcd.c
index 70efda4f767e..cdd6a0bfca05 100644
--- a/drivers/auxdisplay/arm-charlcd.c
+++ b/drivers/auxdisplay/arm-charlcd.c
@@ -306,10 +306,7 @@ static int charlcd_resume(struct device *dev)
 	return 0;
 }
 
-static const struct dev_pm_ops charlcd_pm_ops = {
-	.suspend = charlcd_suspend,
-	.resume = charlcd_resume,
-};
+static DEFINE_SIMPLE_DEV_PM_OPS(charlcd_pm_ops, charlcd_suspend, charlcd_resume);
 
 static const struct of_device_id charlcd_match[] = {
 	{ .compatible = "arm,versatile-lcd", },
-- 
2.25.1

Re: [PATCH v4] auxdisplay: arm-charlcd: Use DEFINE_SIMPLE_DEV_PM_OPS for power management

[Andy Shevchenko]

On Thu, Aug 20, 2026 at 10:32:12AM +0800, Li Jun wrote:
> Replace the manually defined dev_pm_ops structure with the
> DEFINE_SIMPLE_DEV_PM_OPS macro to simplify the power management code.
> This macro automatically handles CONFIG_PM_SLEEP configuration
> and generates freeze/thaw/poweroff/restore callbacks, reducing
> boilerplate code.

> Changes:
> -Replace SIMPLE_DEV_PM_OPS() in v1 v2 with DEFINE_SIMPLE_DEV_PM_OPS() for pm.
> -Corrected grammar errors in v1 comment.

As Dan (IIRC) said, please move changelog to the below '---' cutter line and
address all my comments.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v4] auxdisplay: arm-charlcd: Use DEFINE_SIMPLE_DEV_PM_OPS for power management

[lijun]

My subsequent commits，i will add changlog below '---' cutter line.

and address all your comments.


2026/8/21 17:17, Andy Shevchenko :
> On Thu, Aug 20, 2026 at 10:32:12AM +0800, Li Jun wrote:
>> Replace the manually defined dev_pm_ops structure with the
>> DEFINE_SIMPLE_DEV_PM_OPS macro to simplify the power management code.
>> This macro automatically handles CONFIG_PM_SLEEP configuration
>> and generates freeze/thaw/poweroff/restore callbacks, reducing
>> boilerplate code.
>> Changes:
>> -Replace SIMPLE_DEV_PM_OPS() in v1 v2 with DEFINE_SIMPLE_DEV_PM_OPS() for pm.
>> -Corrected grammar errors in v1 comment.
> As Dan (IIRC) said, please move changelog to the below '---' cutter line and
> address all my comments.
>